)]}'
{"metropolis/test/launch/cli/launch/main.go":[{"author":{"_account_id":1000001,"name":"Lorenz Brun","display_name":"Lorenz","email":"lorenz@monogon.tech","username":"lorenz","avatars":[{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"ecef90405c6a42d46da3150cd7a888d39dd5eaa0","unresolved":true,"context_lines":[{"line_number":34,"context_line":"\t}"},{"line_number":35,"context_line":"\tctx :\u003d clicontext.WithInterrupt(context.Background())"},{"line_number":36,"context_line":"\terr :\u003d cluster.LaunchNode(ctx, cluster.NodeOptions{"},{"line_number":37,"context_line":"\t\tPorts:      launch.IdentityPortMap(ports),"},{"line_number":38,"context_line":"\t\tSerialPort: os.Stdout,"},{"line_number":39,"context_line":"\t\tNodeParameters: \u0026apb.NodeParameters{"},{"line_number":40,"context_line":"\t\t\tCluster: \u0026apb.NodeParameters_ClusterBootstrap_{"}],"source_content_type":"text/x-go","patch_set":2,"id":"05da9817_bbf5948d","line":37,"range":{"start_line":37,"start_character":21,"end_line":37,"end_character":36},"updated":"2022-04-05 14:06:00.000000000","message":"Any reason why this doesn\u0027t just take []uint16 now?","commit_id":"98d5b511add7b6c4e4f8875659c806509763cfbf"},{"author":{"_account_id":1000002,"name":"Serge Bazanski","display_name":"Serge","email":"serge@monogon.tech","username":"serge","avatars":[{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"a77b5f19e7d12a25f2c991a5dde0f578a96859dd","unresolved":true,"context_lines":[{"line_number":34,"context_line":"\t}"},{"line_number":35,"context_line":"\tctx :\u003d clicontext.WithInterrupt(context.Background())"},{"line_number":36,"context_line":"\terr :\u003d cluster.LaunchNode(ctx, cluster.NodeOptions{"},{"line_number":37,"context_line":"\t\tPorts:      launch.IdentityPortMap(ports),"},{"line_number":38,"context_line":"\t\tSerialPort: os.Stdout,"},{"line_number":39,"context_line":"\t\tNodeParameters: \u0026apb.NodeParameters{"},{"line_number":40,"context_line":"\t\t\tCluster: \u0026apb.NodeParameters_ClusterBootstrap_{"}],"source_content_type":"text/x-go","patch_set":2,"id":"83c1b5e1_48e7eada","line":37,"range":{"start_line":37,"start_character":21,"end_line":37,"end_character":36},"in_reply_to":"05da9817_bbf5948d","updated":"2022-04-05 14:44:30.000000000","message":"Why doesn\u0027t what take []uint16? IdentityPortMap takes a []uint16 now (as I made it non-metropolis-specific), and that\u0027s why I\u0027m doing this conversion.","commit_id":"98d5b511add7b6c4e4f8875659c806509763cfbf"},{"author":{"_account_id":1000001,"name":"Lorenz Brun","display_name":"Lorenz","email":"lorenz@monogon.tech","username":"lorenz","avatars":[{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"0fa2d94392042b9d76897137bf6cb07cd8c45ab7","unresolved":false,"context_lines":[{"line_number":34,"context_line":"\t}"},{"line_number":35,"context_line":"\tctx :\u003d clicontext.WithInterrupt(context.Background())"},{"line_number":36,"context_line":"\terr :\u003d cluster.LaunchNode(ctx, cluster.NodeOptions{"},{"line_number":37,"context_line":"\t\tPorts:      launch.IdentityPortMap(ports),"},{"line_number":38,"context_line":"\t\tSerialPort: os.Stdout,"},{"line_number":39,"context_line":"\t\tNodeParameters: \u0026apb.NodeParameters{"},{"line_number":40,"context_line":"\t\t\tCluster: \u0026apb.NodeParameters_ClusterBootstrap_{"}],"source_content_type":"text/x-go","patch_set":2,"id":"c6ee4439_649da2a9","line":37,"range":{"start_line":37,"start_character":21,"end_line":37,"end_character":36},"in_reply_to":"83c1b5e1_48e7eada","updated":"2022-04-05 15:22:53.000000000","message":"I see. I misread the code thinking it converts the other way.","commit_id":"98d5b511add7b6c4e4f8875659c806509763cfbf"}],"metropolis/test/launch/cluster/cluster.go":[{"author":{"_account_id":1000001,"name":"Lorenz Brun","display_name":"Lorenz","email":"lorenz@monogon.tech","username":"lorenz","avatars":[{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"ecef90405c6a42d46da3150cd7a888d39dd5eaa0","unresolved":true,"context_lines":[{"line_number":356,"context_line":"\t\treturn nil, nil, fmt.Errorf(\"NewEphemeralCredentials: %w\", err)"},{"line_number":357,"context_line":"\t}"},{"line_number":358,"context_line":"\tinitDialer :\u003d func(_ context.Context, addr string) (net.Conn, error) {"},{"line_number":359,"context_line":"\t\treturn socksDialer.Dial(\"tcp\", addr)"},{"line_number":360,"context_line":"\t}"},{"line_number":361,"context_line":"\tinitClient, err :\u003d grpc.Dial(remote, grpc.WithContextDialer(initDialer), grpc.WithTransportCredentials(initCreds))"},{"line_number":362,"context_line":"\tif err !\u003d nil {"}],"source_content_type":"text/x-go","patch_set":2,"id":"6d3db307_2c73926b","line":359,"range":{"start_line":359,"start_character":21,"end_line":359,"end_character":25},"updated":"2022-04-05 14:06:00.000000000","message":"Can we not use DialContext here? Would save you some wrapping.","commit_id":"98d5b511add7b6c4e4f8875659c806509763cfbf"},{"author":{"_account_id":1000002,"name":"Serge Bazanski","display_name":"Serge","email":"serge@monogon.tech","username":"serge","avatars":[{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"a77b5f19e7d12a25f2c991a5dde0f578a96859dd","unresolved":true,"context_lines":[{"line_number":356,"context_line":"\t\treturn nil, nil, fmt.Errorf(\"NewEphemeralCredentials: %w\", err)"},{"line_number":357,"context_line":"\t}"},{"line_number":358,"context_line":"\tinitDialer :\u003d func(_ context.Context, addr string) (net.Conn, error) {"},{"line_number":359,"context_line":"\t\treturn socksDialer.Dial(\"tcp\", addr)"},{"line_number":360,"context_line":"\t}"},{"line_number":361,"context_line":"\tinitClient, err :\u003d grpc.Dial(remote, grpc.WithContextDialer(initDialer), grpc.WithTransportCredentials(initCreds))"},{"line_number":362,"context_line":"\tif err !\u003d nil {"}],"source_content_type":"text/x-go","patch_set":2,"id":"ee1738f0_30eaeb05","line":359,"range":{"start_line":359,"start_character":21,"end_line":359,"end_character":25},"in_reply_to":"6d3db307_2c73926b","updated":"2022-04-05 14:44:30.000000000","message":"golang.org/x/net/proxy.Dialer (as returned by proxy.SOCKS5) does not implement a gRPC Dial(Context)-like interface. The gRPC Dial functions are in fact quite different from the Go net Dialer interfaces.","commit_id":"98d5b511add7b6c4e4f8875659c806509763cfbf"},{"author":{"_account_id":1000001,"name":"Lorenz Brun","display_name":"Lorenz","email":"lorenz@monogon.tech","username":"lorenz","avatars":[{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"0fa2d94392042b9d76897137bf6cb07cd8c45ab7","unresolved":false,"context_lines":[{"line_number":356,"context_line":"\t\treturn nil, nil, fmt.Errorf(\"NewEphemeralCredentials: %w\", err)"},{"line_number":357,"context_line":"\t}"},{"line_number":358,"context_line":"\tinitDialer :\u003d func(_ context.Context, addr string) (net.Conn, error) {"},{"line_number":359,"context_line":"\t\treturn socksDialer.Dial(\"tcp\", addr)"},{"line_number":360,"context_line":"\t}"},{"line_number":361,"context_line":"\tinitClient, err :\u003d grpc.Dial(remote, grpc.WithContextDialer(initDialer), grpc.WithTransportCredentials(initCreds))"},{"line_number":362,"context_line":"\tif err !\u003d nil {"}],"source_content_type":"text/x-go","patch_set":2,"id":"404f9652_855777ec","line":359,"range":{"start_line":359,"start_character":21,"end_line":359,"end_character":25},"in_reply_to":"ee1738f0_30eaeb05","updated":"2022-04-05 15:22:53.000000000","message":"Ack","commit_id":"98d5b511add7b6c4e4f8875659c806509763cfbf"}]}