)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000002,"name":"Serge Bazanski","display_name":"Serge","email":"serge@monogon.tech","username":"serge","avatars":[{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"3c6c8be2ebec0d8b3f1575e980e4e5c286172060","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"47bfc70e_a77d9a3c","updated":"2022-02-07 12:55:21.000000000","message":"Looks good. Two small comments.","commit_id":"c5b8e1ce42af4e14c4cd2a05ae8a494d8d66027a"}],"metropolis/node/build/def.bzl":[{"author":{"_account_id":1000002,"name":"Serge Bazanski","display_name":"Serge","email":"serge@monogon.tech","username":"serge","avatars":[{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"3c6c8be2ebec0d8b3f1575e980e4e5c286172060","unresolved":true,"context_lines":[{"line_number":58,"context_line":"    },"},{"line_number":59,"context_line":")"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"def _fsspec_core_impl(ctx, tool, output_file, builtin_fsspec):"},{"line_number":62,"context_line":"    \"\"\""},{"line_number":63,"context_line":"    _fsspec_core_impl implements the core of an fsspec-based rule. It takes"},{"line_number":64,"context_line":"    input from the `files`,`files_cc`, `extra_dirs`, `symlinks` and `fsspecs`"}],"source_content_type":"text/x-python","patch_set":5,"id":"d11db6aa_5d415098","line":61,"range":{"start_line":61,"start_character":4,"end_line":61,"end_character":21},"updated":"2022-02-07 12:55:21.000000000","message":"If it\u0027s not too much effort I\u0027d probably split up the \u0027generate fsspec from files/files_cc/extra_dirs/symlinks\u0027 from the \u0027call tool with fsspecs\u0027 part. But this is also fine.","commit_id":"c5b8e1ce42af4e14c4cd2a05ae8a494d8d66027a"},{"author":{"_account_id":1000001,"name":"Lorenz Brun","display_name":"Lorenz","email":"lorenz@monogon.tech","username":"lorenz","avatars":[{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"1bcfd0739b7aa6333675e75ce01e8257213c0ceb","unresolved":true,"context_lines":[{"line_number":58,"context_line":"    },"},{"line_number":59,"context_line":")"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"def _fsspec_core_impl(ctx, tool, output_file, builtin_fsspec):"},{"line_number":62,"context_line":"    \"\"\""},{"line_number":63,"context_line":"    _fsspec_core_impl implements the core of an fsspec-based rule. It takes"},{"line_number":64,"context_line":"    input from the `files`,`files_cc`, `extra_dirs`, `symlinks` and `fsspecs`"}],"source_content_type":"text/x-python","patch_set":5,"id":"e4093c71_500f397a","line":61,"range":{"start_line":61,"start_character":4,"end_line":61,"end_character":21},"in_reply_to":"d11db6aa_5d415098","updated":"2022-02-07 19:28:32.000000000","message":"I tried doing this but it made the code more complicated and longer. Main issue is that _fsspec_run_tool gets a lot of arguments (6) which need to be passed.","commit_id":"c5b8e1ce42af4e14c4cd2a05ae8a494d8d66027a"},{"author":{"_account_id":1000002,"name":"Serge Bazanski","display_name":"Serge","email":"serge@monogon.tech","username":"serge","avatars":[{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"19c1ee757561b84d90c08fea50fc752f404711e6","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    },"},{"line_number":59,"context_line":")"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"def _fsspec_core_impl(ctx, tool, output_file, builtin_fsspec):"},{"line_number":62,"context_line":"    \"\"\""},{"line_number":63,"context_line":"    _fsspec_core_impl implements the core of an fsspec-based rule. It takes"},{"line_number":64,"context_line":"    input from the `files`,`files_cc`, `extra_dirs`, `symlinks` and `fsspecs`"}],"source_content_type":"text/x-python","patch_set":5,"id":"ea9cca46_3be524f5","line":61,"range":{"start_line":61,"start_character":4,"end_line":61,"end_character":21},"in_reply_to":"e4093c71_500f397a","updated":"2022-02-08 12:04:30.000000000","message":"Ack. You could use more starlark magic here to make this less painful (typically, a Context struct), but the recipe for more readable starlark isn\u0027t to write more starlark :).","commit_id":"c5b8e1ce42af4e14c4cd2a05ae8a494d8d66027a"},{"author":{"_account_id":1000002,"name":"Serge Bazanski","display_name":"Serge","email":"serge@monogon.tech","username":"serge","avatars":[{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"3c6c8be2ebec0d8b3f1575e980e4e5c286172060","unresolved":true,"context_lines":[{"line_number":134,"context_line":""},{"line_number":135,"context_line":"def _node_initramfs_impl(ctx):"},{"line_number":136,"context_line":"    # This is here mostly because it was previously. Eventually this should"},{"line_number":137,"context_line":"    # move to separate rule dedicated to doing this and the output of that"},{"line_number":138,"context_line":"    # rule should be fed into this one."},{"line_number":139,"context_line":"    builtin_fsspec \u003d struct(special_file \u003d ["},{"line_number":140,"context_line":"        struct(path \u003d \"/dev/console\", mode \u003d 0o600, major \u003d 5, minor \u003d 1),"}],"source_content_type":"text/x-python","patch_set":5,"id":"1d928a0b_1e555541","line":137,"range":{"start_line":137,"start_character":47,"end_line":137,"end_character":51},"updated":"2022-02-07 12:55:21.000000000","message":"Expand/clarify \u0027this\u0027 and \u0027that\u0027 as it\u0027s quite ambiguous.","commit_id":"c5b8e1ce42af4e14c4cd2a05ae8a494d8d66027a"},{"author":{"_account_id":1000001,"name":"Lorenz Brun","display_name":"Lorenz","email":"lorenz@monogon.tech","username":"lorenz","avatars":[{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"9f1808d5dd1219b643fa08006f32711f5b2031d8","unresolved":false,"context_lines":[{"line_number":134,"context_line":""},{"line_number":135,"context_line":"def _node_initramfs_impl(ctx):"},{"line_number":136,"context_line":"    # This is here mostly because it was previously. Eventually this should"},{"line_number":137,"context_line":"    # move to separate rule dedicated to doing this and the output of that"},{"line_number":138,"context_line":"    # rule should be fed into this one."},{"line_number":139,"context_line":"    builtin_fsspec \u003d struct(special_file \u003d ["},{"line_number":140,"context_line":"        struct(path \u003d \"/dev/console\", mode \u003d 0o600, major \u003d 5, minor \u003d 1),"}],"source_content_type":"text/x-python","patch_set":5,"id":"6cbf16ff_02493452","line":137,"range":{"start_line":137,"start_character":47,"end_line":137,"end_character":51},"in_reply_to":"1d928a0b_1e555541","updated":"2022-02-07 16:26:33.000000000","message":"I thought about this and came to the conclusion that this rule will probably not be split up in the way I originally thought. So I just replaced it with a comment explaining why the builtin fsspec exists.","commit_id":"c5b8e1ce42af4e14c4cd2a05ae8a494d8d66027a"}]}