)]}'
{"metropolis/node/build/mkverity/mkverity.go":[{"author":{"_account_id":1000002,"name":"Serge Bazanski","display_name":"Serge","email":"serge@monogon.tech","username":"serge","avatars":[{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"d023f1f7ae02e39b071b713f3f603d9f55628cb2","unresolved":true,"context_lines":[{"line_number":99,"context_line":"\t// Return an encoder-generated verity mapping table, containing the salt and"},{"line_number":100,"context_line":"\t// the root hash. First, calculate the starting hash block by dividing the"},{"line_number":101,"context_line":"\t// data image size by the encoder data block size."},{"line_number":102,"context_line":"\thashStart :\u003d ds.Size() / int64(bs)"},{"line_number":103,"context_line":"\tmt, err :\u003d v.MappingTable(dataImagePath, outputImagePath, hashStart)"},{"line_number":104,"context_line":"\tif err !\u003d nil {"},{"line_number":105,"context_line":"\t\treturn nil, fmt.Errorf(\"while querying for the mapping table: %w\", err)"}],"source_content_type":"text/x-go","patch_set":1,"id":"218a31b5_cdfa05ac","line":102,"range":{"start_line":102,"start_character":14,"end_line":102,"end_character":23},"updated":"2022-01-26 10:00:02.000000000","message":"Do we have checks somewhere to make sure ds.Size() is a multiple of 4096?","commit_id":"7dc44b266b4529dc14a702cdc5d6cfa7c76980eb"},{"author":{"_account_id":1000010,"name":"Mateusz Zalega","display_name":"msgctl","email":"mateusz@monogon.tech","username":"mateusz","avatars":[{"url":"https://www.gravatar.com/avatar/30cae8ca0782f23ce0a60ac80fda3dd9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/30cae8ca0782f23ce0a60ac80fda3dd9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/30cae8ca0782f23ce0a60ac80fda3dd9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/30cae8ca0782f23ce0a60ac80fda3dd9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"ca02137a599831689af419766472af5d13fdb230","unresolved":true,"context_lines":[{"line_number":99,"context_line":"\t// Return an encoder-generated verity mapping table, containing the salt and"},{"line_number":100,"context_line":"\t// the root hash. First, calculate the starting hash block by dividing the"},{"line_number":101,"context_line":"\t// data image size by the encoder data block size."},{"line_number":102,"context_line":"\thashStart :\u003d ds.Size() / int64(bs)"},{"line_number":103,"context_line":"\tmt, err :\u003d v.MappingTable(dataImagePath, outputImagePath, hashStart)"},{"line_number":104,"context_line":"\tif err !\u003d nil {"},{"line_number":105,"context_line":"\t\treturn nil, fmt.Errorf(\"while querying for the mapping table: %w\", err)"}],"source_content_type":"text/x-go","patch_set":1,"id":"9993f382_2f2dbe9b","line":102,"range":{"start_line":102,"start_character":14,"end_line":102,"end_character":23},"in_reply_to":"218a31b5_cdfa05ac","updated":"2022-01-28 16:51:38.000000000","message":"Yes, at line 60.","commit_id":"7dc44b266b4529dc14a702cdc5d6cfa7c76980eb"},{"author":{"_account_id":1000002,"name":"Serge Bazanski","display_name":"Serge","email":"serge@monogon.tech","username":"serge","avatars":[{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"899039d05025467f3922ae4f22ab7334f426362f","unresolved":false,"context_lines":[{"line_number":99,"context_line":"\t// Return an encoder-generated verity mapping table, containing the salt and"},{"line_number":100,"context_line":"\t// the root hash. First, calculate the starting hash block by dividing the"},{"line_number":101,"context_line":"\t// data image size by the encoder data block size."},{"line_number":102,"context_line":"\thashStart :\u003d ds.Size() / int64(bs)"},{"line_number":103,"context_line":"\tmt, err :\u003d v.MappingTable(dataImagePath, outputImagePath, hashStart)"},{"line_number":104,"context_line":"\tif err !\u003d nil {"},{"line_number":105,"context_line":"\t\treturn nil, fmt.Errorf(\"while querying for the mapping table: %w\", err)"}],"source_content_type":"text/x-go","patch_set":1,"id":"cca849b2_7cf09959","line":102,"range":{"start_line":102,"start_character":14,"end_line":102,"end_character":23},"in_reply_to":"9993f382_2f2dbe9b","updated":"2022-01-28 17:33:15.000000000","message":"Ack","commit_id":"7dc44b266b4529dc14a702cdc5d6cfa7c76980eb"},{"author":{"_account_id":1000002,"name":"Serge Bazanski","display_name":"Serge","email":"serge@monogon.tech","username":"serge","avatars":[{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"d023f1f7ae02e39b071b713f3f603d9f55628cb2","unresolved":true,"context_lines":[{"line_number":120,"context_line":""},{"line_number":121,"context_line":"\t// If the required parameters weren\u0027t provided, print the usage information."},{"line_number":122,"context_line":"\tif *input \u003d\u003d \"\" || *output \u003d\u003d \"\" {"},{"line_number":123,"context_line":"\t\tfmt.Println(\"Usage:\")"},{"line_number":124,"context_line":"\t\tflag.PrintDefaults()"},{"line_number":125,"context_line":"\t\tos.Exit(2)"},{"line_number":126,"context_line":"\t}"}],"source_content_type":"text/x-go","patch_set":1,"id":"75ea589f_c98c8658","line":123,"range":{"start_line":123,"start_character":2,"end_line":123,"end_character":23},"updated":"2022-01-26 10:00:02.000000000","message":"Since this is going to be called by the build system, the error should be IMO more precise:\n\n  if *input \u003d\u003d \"\" {\n     log.Fatalf(\"-input must be set\")\n  }\n  if *output \u003d\u003d \"\" {\n     log.Fatalf(\"-output must be set\")\n  }","commit_id":"7dc44b266b4529dc14a702cdc5d6cfa7c76980eb"},{"author":{"_account_id":1000010,"name":"Mateusz Zalega","display_name":"msgctl","email":"mateusz@monogon.tech","username":"mateusz","avatars":[{"url":"https://www.gravatar.com/avatar/30cae8ca0782f23ce0a60ac80fda3dd9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/30cae8ca0782f23ce0a60ac80fda3dd9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/30cae8ca0782f23ce0a60ac80fda3dd9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/30cae8ca0782f23ce0a60ac80fda3dd9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"ca02137a599831689af419766472af5d13fdb230","unresolved":false,"context_lines":[{"line_number":120,"context_line":""},{"line_number":121,"context_line":"\t// If the required parameters weren\u0027t provided, print the usage information."},{"line_number":122,"context_line":"\tif *input \u003d\u003d \"\" || *output \u003d\u003d \"\" {"},{"line_number":123,"context_line":"\t\tfmt.Println(\"Usage:\")"},{"line_number":124,"context_line":"\t\tflag.PrintDefaults()"},{"line_number":125,"context_line":"\t\tos.Exit(2)"},{"line_number":126,"context_line":"\t}"}],"source_content_type":"text/x-go","patch_set":1,"id":"b053621a_b27f668b","line":123,"range":{"start_line":123,"start_character":2,"end_line":123,"end_character":23},"in_reply_to":"75ea589f_c98c8658","updated":"2022-01-28 16:51:38.000000000","message":"Done","commit_id":"7dc44b266b4529dc14a702cdc5d6cfa7c76980eb"},{"author":{"_account_id":1000002,"name":"Serge Bazanski","display_name":"Serge","email":"serge@monogon.tech","username":"serge","avatars":[{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"d023f1f7ae02e39b071b713f3f603d9f55628cb2","unresolved":false,"context_lines":[{"line_number":132,"context_line":"\t}"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"\t// Patch the device names, if alternatives were provided."},{"line_number":135,"context_line":"\tif *dataDeviceAlias !\u003d \"\" {"},{"line_number":136,"context_line":"\t\tmt.DataDevicePath \u003d *dataDeviceAlias"},{"line_number":137,"context_line":"\t}"},{"line_number":138,"context_line":"\tif *hashDeviceAlias !\u003d \"\" {"}],"source_content_type":"text/x-go","patch_set":1,"id":"4d48d740_c91c6332","line":135,"range":{"start_line":135,"start_character":4,"end_line":135,"end_character":5},"updated":"2022-01-26 10:00:02.000000000","message":"If you\u0027re tired of seeing all stars, let me remind you about flag.StringVar.","commit_id":"7dc44b266b4529dc14a702cdc5d6cfa7c76980eb"},{"author":{"_account_id":1000010,"name":"Mateusz Zalega","display_name":"msgctl","email":"mateusz@monogon.tech","username":"mateusz","avatars":[{"url":"https://www.gravatar.com/avatar/30cae8ca0782f23ce0a60ac80fda3dd9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/30cae8ca0782f23ce0a60ac80fda3dd9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/30cae8ca0782f23ce0a60ac80fda3dd9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/30cae8ca0782f23ce0a60ac80fda3dd9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"ca02137a599831689af419766472af5d13fdb230","unresolved":false,"context_lines":[{"line_number":132,"context_line":"\t}"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"\t// Patch the device names, if alternatives were provided."},{"line_number":135,"context_line":"\tif *dataDeviceAlias !\u003d \"\" {"},{"line_number":136,"context_line":"\t\tmt.DataDevicePath \u003d *dataDeviceAlias"},{"line_number":137,"context_line":"\t}"},{"line_number":138,"context_line":"\tif *hashDeviceAlias !\u003d \"\" {"}],"source_content_type":"text/x-go","patch_set":1,"id":"4a505de5_3b569c39","line":135,"range":{"start_line":135,"start_character":4,"end_line":135,"end_character":5},"in_reply_to":"4d48d740_c91c6332","updated":"2022-01-28 16:51:38.000000000","message":"I\u0027m good. It looks clearer this way.","commit_id":"7dc44b266b4529dc14a702cdc5d6cfa7c76980eb"}]}