)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000010,"name":"Mateusz Zalega","display_name":"msgctl","email":"mateusz@monogon.tech","username":"mateusz","avatars":[{"url":"https://www.gravatar.com/avatar/30cae8ca0782f23ce0a60ac80fda3dd9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/30cae8ca0782f23ce0a60ac80fda3dd9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/30cae8ca0782f23ce0a60ac80fda3dd9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/30cae8ca0782f23ce0a60ac80fda3dd9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"e47b16545b9febac31d44a23e608c78ac766faf5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2366ecbc_6e0bf9da","updated":"2022-01-25 19:24:59.000000000","message":"Would mkefi sound better?","commit_id":"3c2e53f4ba51e1004bf8b88aebca2f368f2fd571"}],"metropolis/node/build/mkpayload/mkpayload.go":[{"author":{"_account_id":1000002,"name":"Serge Bazanski","display_name":"Serge","email":"serge@monogon.tech","username":"serge","avatars":[{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"10d9cb5cdbcd8b0db421c22db72a15f0111e3420","unresolved":true,"context_lines":[{"line_number":38,"context_line":"\t\tdescr    string"},{"line_number":39,"context_line":"\t\tvma      string"},{"line_number":40,"context_line":"\t\trequired bool"},{"line_number":41,"context_line":"\t\tfile     *string"},{"line_number":42,"context_line":"\t}{"},{"line_number":43,"context_line":"\t\t\"linux\":   {\"Linux kernel image\", \"0x2000000\", true, nil},"},{"line_number":44,"context_line":"\t\t\"initrd\":  {\"initramfs\", \"0x5000000\", false, nil},"}],"source_content_type":"text/x-go","patch_set":1,"id":"36f4bf86_f166bf2e","line":41,"range":{"start_line":41,"start_character":2,"end_line":41,"end_character":18},"updated":"2022-01-26 09:48:55.000000000","message":"You can make the code cleaner (no need to dereference file/value) by using a string here and creating the flags with StringVar instead.","commit_id":"3c2e53f4ba51e1004bf8b88aebca2f368f2fd571"},{"author":{"_account_id":1000010,"name":"Mateusz Zalega","display_name":"msgctl","email":"mateusz@monogon.tech","username":"mateusz","avatars":[{"url":"https://www.gravatar.com/avatar/30cae8ca0782f23ce0a60ac80fda3dd9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/30cae8ca0782f23ce0a60ac80fda3dd9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/30cae8ca0782f23ce0a60ac80fda3dd9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/30cae8ca0782f23ce0a60ac80fda3dd9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"df8062ea1fa4c22405672824c4d6266e2b35face","unresolved":true,"context_lines":[{"line_number":38,"context_line":"\t\tdescr    string"},{"line_number":39,"context_line":"\t\tvma      string"},{"line_number":40,"context_line":"\t\trequired bool"},{"line_number":41,"context_line":"\t\tfile     *string"},{"line_number":42,"context_line":"\t}{"},{"line_number":43,"context_line":"\t\t\"linux\":   {\"Linux kernel image\", \"0x2000000\", true, nil},"},{"line_number":44,"context_line":"\t\t\"initrd\":  {\"initramfs\", \"0x5000000\", false, nil},"}],"source_content_type":"text/x-go","patch_set":1,"id":"49c9eef3_73d31472","line":41,"range":{"start_line":41,"start_character":2,"end_line":41,"end_character":18},"in_reply_to":"36f4bf86_f166bf2e","updated":"2022-01-28 16:49:20.000000000","message":"StringVar was what I started with, however AFAIR to make this setup work it required me to take a pointer to a map member, which is prohibited by Go.","commit_id":"3c2e53f4ba51e1004bf8b88aebca2f368f2fd571"},{"author":{"_account_id":1000002,"name":"Serge Bazanski","display_name":"Serge","email":"serge@monogon.tech","username":"serge","avatars":[{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"86dc30fa470928dd9ab591a76b58978f8a21aa12","unresolved":false,"context_lines":[{"line_number":38,"context_line":"\t\tdescr    string"},{"line_number":39,"context_line":"\t\tvma      string"},{"line_number":40,"context_line":"\t\trequired bool"},{"line_number":41,"context_line":"\t\tfile     *string"},{"line_number":42,"context_line":"\t}{"},{"line_number":43,"context_line":"\t\t\"linux\":   {\"Linux kernel image\", \"0x2000000\", true, nil},"},{"line_number":44,"context_line":"\t\t\"initrd\":  {\"initramfs\", \"0x5000000\", false, nil},"}],"source_content_type":"text/x-go","patch_set":1,"id":"5845ad76_8f82a173","line":41,"range":{"start_line":41,"start_character":2,"end_line":41,"end_character":18},"in_reply_to":"49c9eef3_73d31472","updated":"2022-01-28 17:32:44.000000000","message":"Oh, I didn\u0027t know that. Interesting.","commit_id":"3c2e53f4ba51e1004bf8b88aebca2f368f2fd571"},{"author":{"_account_id":1000002,"name":"Serge Bazanski","display_name":"Serge","email":"serge@monogon.tech","username":"serge","avatars":[{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"10d9cb5cdbcd8b0db421c22db72a15f0111e3420","unresolved":true,"context_lines":[{"line_number":46,"context_line":"\t\t\"cmdline\": {\"a file containting additional kernel command line parameters\", \"0x30000\", false, nil},"},{"line_number":47,"context_line":"\t\t\"splash\":  {\"a splash screen image in BMP format\", \"0x40000\", false, nil},"},{"line_number":48,"context_line":"\t}"},{"line_number":49,"context_line":"\t// flags contains parameters that are not related to the aforementioned"},{"line_number":50,"context_line":"\t// payload sections."},{"line_number":51,"context_line":"\tflags \u003d map[string]struct {"},{"line_number":52,"context_line":"\t\tdescr    string"},{"line_number":53,"context_line":"\t\trequired bool"},{"line_number":54,"context_line":"\t\tvalue    *string"},{"line_number":55,"context_line":"\t}{"},{"line_number":56,"context_line":"\t\t\"objcopy\":         {\"objcopy executable\", true, nil},"},{"line_number":57,"context_line":"\t\t\"stub\":            {\"the EFI stub executable\", true, nil},"},{"line_number":58,"context_line":"\t\t\"output\":          {\"objcopy output\", true, nil},"},{"line_number":59,"context_line":"\t\t\"rootfs_dm_table\": {\"a text file containing the DeviceMapper rootfs target table\", false, nil},"},{"line_number":60,"context_line":"\t}"},{"line_number":61,"context_line":")"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"func usage() {"}],"source_content_type":"text/x-go","patch_set":1,"id":"60e13777_03c8e1d5","line":60,"range":{"start_line":49,"start_character":1,"end_line":60,"end_character":2},"updated":"2022-01-26 09:48:55.000000000","message":"Pretty sure four flag.String calls and three if statements (to check for flags being set) are shorter than this and the loop below.","commit_id":"3c2e53f4ba51e1004bf8b88aebca2f368f2fd571"},{"author":{"_account_id":1000010,"name":"Mateusz Zalega","display_name":"msgctl","email":"mateusz@monogon.tech","username":"mateusz","avatars":[{"url":"https://www.gravatar.com/avatar/30cae8ca0782f23ce0a60ac80fda3dd9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/30cae8ca0782f23ce0a60ac80fda3dd9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/30cae8ca0782f23ce0a60ac80fda3dd9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/30cae8ca0782f23ce0a60ac80fda3dd9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"df8062ea1fa4c22405672824c4d6266e2b35face","unresolved":false,"context_lines":[{"line_number":46,"context_line":"\t\t\"cmdline\": {\"a file containting additional kernel command line parameters\", \"0x30000\", false, nil},"},{"line_number":47,"context_line":"\t\t\"splash\":  {\"a splash screen image in BMP format\", \"0x40000\", false, nil},"},{"line_number":48,"context_line":"\t}"},{"line_number":49,"context_line":"\t// flags contains parameters that are not related to the aforementioned"},{"line_number":50,"context_line":"\t// payload sections."},{"line_number":51,"context_line":"\tflags \u003d map[string]struct {"},{"line_number":52,"context_line":"\t\tdescr    string"},{"line_number":53,"context_line":"\t\trequired bool"},{"line_number":54,"context_line":"\t\tvalue    *string"},{"line_number":55,"context_line":"\t}{"},{"line_number":56,"context_line":"\t\t\"objcopy\":         {\"objcopy executable\", true, nil},"},{"line_number":57,"context_line":"\t\t\"stub\":            {\"the EFI stub executable\", true, nil},"},{"line_number":58,"context_line":"\t\t\"output\":          {\"objcopy output\", true, nil},"},{"line_number":59,"context_line":"\t\t\"rootfs_dm_table\": {\"a text file containing the DeviceMapper rootfs target table\", false, nil},"},{"line_number":60,"context_line":"\t}"},{"line_number":61,"context_line":")"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"func usage() {"}],"source_content_type":"text/x-go","patch_set":1,"id":"5744e503_aae6f6e7","line":60,"range":{"start_line":49,"start_character":1,"end_line":60,"end_character":2},"in_reply_to":"60e13777_03c8e1d5","updated":"2022-01-28 16:49:20.000000000","message":"Done","commit_id":"3c2e53f4ba51e1004bf8b88aebca2f368f2fd571"},{"author":{"_account_id":1000002,"name":"Serge Bazanski","display_name":"Serge","email":"serge@monogon.tech","username":"serge","avatars":[{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"10d9cb5cdbcd8b0db421c22db72a15f0111e3420","unresolved":true,"context_lines":[{"line_number":80,"context_line":"\t// Ensure all the required parameters are filled in."},{"line_number":81,"context_line":"\tfor n, s :\u003d range sections {"},{"line_number":82,"context_line":"\t\tif s.required \u0026\u0026 *s.file \u003d\u003d \"\" {"},{"line_number":83,"context_line":"\t\t\tfmt.Printf(\"Please provide the mandatory \\\"--%s\\\" flag.\\n\", n)"},{"line_number":84,"context_line":"\t\t\tusage()"},{"line_number":85,"context_line":"\t\t\tos.Exit(2)"},{"line_number":86,"context_line":"\t\t}"}],"source_content_type":"text/x-go","patch_set":1,"id":"52bb8377_9cf6664b","line":83,"range":{"start_line":83,"start_character":3,"end_line":83,"end_character":13},"updated":"2022-01-26 09:48:55.000000000","message":"log.Fatalf and don\u0027t bother with usage() (this isn\u0027t an end-user tool, it will just end up polluting Bazel build logs).","commit_id":"3c2e53f4ba51e1004bf8b88aebca2f368f2fd571"},{"author":{"_account_id":1000010,"name":"Mateusz Zalega","display_name":"msgctl","email":"mateusz@monogon.tech","username":"mateusz","avatars":[{"url":"https://www.gravatar.com/avatar/30cae8ca0782f23ce0a60ac80fda3dd9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/30cae8ca0782f23ce0a60ac80fda3dd9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/30cae8ca0782f23ce0a60ac80fda3dd9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/30cae8ca0782f23ce0a60ac80fda3dd9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"df8062ea1fa4c22405672824c4d6266e2b35face","unresolved":false,"context_lines":[{"line_number":80,"context_line":"\t// Ensure all the required parameters are filled in."},{"line_number":81,"context_line":"\tfor n, s :\u003d range sections {"},{"line_number":82,"context_line":"\t\tif s.required \u0026\u0026 *s.file \u003d\u003d \"\" {"},{"line_number":83,"context_line":"\t\t\tfmt.Printf(\"Please provide the mandatory \\\"--%s\\\" flag.\\n\", n)"},{"line_number":84,"context_line":"\t\t\tusage()"},{"line_number":85,"context_line":"\t\t\tos.Exit(2)"},{"line_number":86,"context_line":"\t\t}"}],"source_content_type":"text/x-go","patch_set":1,"id":"72f05719_96b6356b","line":83,"range":{"start_line":83,"start_character":3,"end_line":83,"end_character":13},"in_reply_to":"52bb8377_9cf6664b","updated":"2022-01-28 16:49:20.000000000","message":"Done","commit_id":"3c2e53f4ba51e1004bf8b88aebca2f368f2fd571"}]}