)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1000002,"name":"Serge Bazanski","display_name":"Serge","email":"serge@monogon.tech","username":"serge","avatars":[{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"a311c387a91550fa04a015fe390630b52c3682c1","unresolved":true,"context_lines":[{"line_number":15,"context_line":"both the installer and testos kernels."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"m/t/installer/BUILD.bazel now defines its own unified kernel image"},{"line_number":18,"context_line":"target with a custom kernel cmdline needed for test purposes. The"},{"line_number":19,"context_line":"previously used target in m/n/installer is left for reference."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I43547b6c81f8a1ebc4facb841a600b155af581df"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"02060c14_c58f13fb","line":19,"range":{"start_line":18,"start_character":62,"end_line":19,"end_character":62},"updated":"2021-12-09 13:26:44.000000000","message":"If nothing\u0027s using it, remove it. We have git history for historical/reference reasons.","commit_id":"d465602801214e46f57874519b53e2515bdf6516"},{"author":{"_account_id":1000010,"name":"Mateusz Zalega","display_name":"msgctl","email":"mateusz@monogon.tech","username":"mateusz","avatars":[{"url":"https://www.gravatar.com/avatar/30cae8ca0782f23ce0a60ac80fda3dd9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/30cae8ca0782f23ce0a60ac80fda3dd9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/30cae8ca0782f23ce0a60ac80fda3dd9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/30cae8ca0782f23ce0a60ac80fda3dd9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"fe98dcc482d7e37462c95466c1ef0db866caf361","unresolved":true,"context_lines":[{"line_number":15,"context_line":"both the installer and testos kernels."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"m/t/installer/BUILD.bazel now defines its own unified kernel image"},{"line_number":18,"context_line":"target with a custom kernel cmdline needed for test purposes. The"},{"line_number":19,"context_line":"previously used target in m/n/installer is left for reference."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I43547b6c81f8a1ebc4facb841a600b155af581df"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"4f2c45c4_f4d0e641","line":19,"range":{"start_line":18,"start_character":62,"end_line":19,"end_character":62},"in_reply_to":"02060c14_c58f13fb","updated":"2021-12-15 17:18:21.000000000","message":"I didn\u0027t notice/remember metroctl started using it. I\u0027ve updated the commit message.","commit_id":"d465602801214e46f57874519b53e2515bdf6516"},{"author":{"_account_id":1000010,"name":"Mateusz Zalega","display_name":"msgctl","email":"mateusz@monogon.tech","username":"mateusz","avatars":[{"url":"https://www.gravatar.com/avatar/30cae8ca0782f23ce0a60ac80fda3dd9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/30cae8ca0782f23ce0a60ac80fda3dd9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/30cae8ca0782f23ce0a60ac80fda3dd9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/30cae8ca0782f23ce0a60ac80fda3dd9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"7b0c33edc859a27002a38ad8c4edece15d7755c9","unresolved":false,"context_lines":[{"line_number":15,"context_line":"both the installer and testos kernels."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"m/t/installer/BUILD.bazel now defines its own unified kernel image"},{"line_number":18,"context_line":"target with a custom kernel cmdline needed for test purposes. The"},{"line_number":19,"context_line":"previously used target in m/n/installer is left for reference."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I43547b6c81f8a1ebc4facb841a600b155af581df"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3bb9e5e5_94ca34b0","line":19,"range":{"start_line":18,"start_character":62,"end_line":19,"end_character":62},"in_reply_to":"4f2c45c4_f4d0e641","updated":"2021-12-15 19:12:10.000000000","message":"Done","commit_id":"d465602801214e46f57874519b53e2515bdf6516"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":1000010,"name":"Mateusz Zalega","display_name":"msgctl","email":"mateusz@monogon.tech","username":"mateusz","avatars":[{"url":"https://www.gravatar.com/avatar/30cae8ca0782f23ce0a60ac80fda3dd9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/30cae8ca0782f23ce0a60ac80fda3dd9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/30cae8ca0782f23ce0a60ac80fda3dd9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/30cae8ca0782f23ce0a60ac80fda3dd9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"79bd312b53db38da88f8d5bbe674b6c63840e286","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"751f2dea_89401e9a","updated":"2021-12-08 15:13:38.000000000","message":"I\u0027d considered fixing it by redirecting to another serial console, but have found it to be impractical due to necessity of rigging installer and testos code for tests and lack of otherwise accomodating kernel parameters that would let me send output of the init process elsewhere.","commit_id":"d465602801214e46f57874519b53e2515bdf6516"},{"author":{"_account_id":1000000,"name":"Leopold Schabel","display_name":"Leo","email":"leo@monogon.tech","username":"leo","avatars":[{"url":"https://www.gravatar.com/avatar/98f8f79a6bb45adef37defa7ead8f3d2.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/98f8f79a6bb45adef37defa7ead8f3d2.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/98f8f79a6bb45adef37defa7ead8f3d2.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/98f8f79a6bb45adef37defa7ead8f3d2.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"70622998cb8b5cf0690c8f551824040fa0f862cb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"62153feb_7d4fa3de","in_reply_to":"751f2dea_89401e9a","updated":"2021-12-09 12:13:18.000000000","message":"Presumably, we don\u0027t actually care about the kernel logs or surface them anywhere? LGTM.","commit_id":"d465602801214e46f57874519b53e2515bdf6516"}],"metropolis/node/installer/BUILD.bazel":[{"author":{"_account_id":1000002,"name":"Serge Bazanski","display_name":"Serge","email":"serge@monogon.tech","username":"serge","avatars":[{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"a311c387a91550fa04a015fe390630b52c3682c1","unresolved":true,"context_lines":[{"line_number":27,"context_line":"    files \u003d {"},{"line_number":28,"context_line":"        \"//metropolis/node/installer\": \"/init\","},{"line_number":29,"context_line":"    },"},{"line_number":30,"context_line":"    visibility \u003d [\"//visibility:public\"],"},{"line_number":31,"context_line":")"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"os_release("}],"source_content_type":"text/x-python","patch_set":1,"id":"3d83e1e5_0c3f3d99","line":30,"range":{"start_line":30,"start_character":4,"end_line":30,"end_character":41},"updated":"2021-12-09 13:26:44.000000000","message":"[\"//metropolis/test/installer:__pkg__\"]\n\nAlso, this reflects what I\u0027ve mentioned earlier: that this should live in //metropolis/installer, and its tests in //metropolis/installer/test. Cross-cutting through subtrees like that is a sign of poor code organisation.","commit_id":"d465602801214e46f57874519b53e2515bdf6516"},{"author":{"_account_id":1000010,"name":"Mateusz Zalega","display_name":"msgctl","email":"mateusz@monogon.tech","username":"mateusz","avatars":[{"url":"https://www.gravatar.com/avatar/30cae8ca0782f23ce0a60ac80fda3dd9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/30cae8ca0782f23ce0a60ac80fda3dd9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/30cae8ca0782f23ce0a60ac80fda3dd9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/30cae8ca0782f23ce0a60ac80fda3dd9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"fe98dcc482d7e37462c95466c1ef0db866caf361","unresolved":true,"context_lines":[{"line_number":27,"context_line":"    files \u003d {"},{"line_number":28,"context_line":"        \"//metropolis/node/installer\": \"/init\","},{"line_number":29,"context_line":"    },"},{"line_number":30,"context_line":"    visibility \u003d [\"//visibility:public\"],"},{"line_number":31,"context_line":")"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"os_release("}],"source_content_type":"text/x-python","patch_set":1,"id":"a5511799_3e988f08","line":30,"range":{"start_line":30,"start_character":4,"end_line":30,"end_character":41},"in_reply_to":"3d83e1e5_0c3f3d99","updated":"2021-12-15 17:18:21.000000000","message":"I\u0027ll move it after the datafile patch goes in.","commit_id":"d465602801214e46f57874519b53e2515bdf6516"},{"author":{"_account_id":1000010,"name":"Mateusz Zalega","display_name":"msgctl","email":"mateusz@monogon.tech","username":"mateusz","avatars":[{"url":"https://www.gravatar.com/avatar/30cae8ca0782f23ce0a60ac80fda3dd9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/30cae8ca0782f23ce0a60ac80fda3dd9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/30cae8ca0782f23ce0a60ac80fda3dd9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/30cae8ca0782f23ce0a60ac80fda3dd9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"7b0c33edc859a27002a38ad8c4edece15d7755c9","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    files \u003d {"},{"line_number":28,"context_line":"        \"//metropolis/node/installer\": \"/init\","},{"line_number":29,"context_line":"    },"},{"line_number":30,"context_line":"    visibility \u003d [\"//visibility:public\"],"},{"line_number":31,"context_line":")"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"os_release("}],"source_content_type":"text/x-python","patch_set":1,"id":"9cc822b7_0733b226","line":30,"range":{"start_line":30,"start_character":4,"end_line":30,"end_character":41},"in_reply_to":"a5511799_3e988f08","updated":"2021-12-15 19:12:10.000000000","message":"Done","commit_id":"d465602801214e46f57874519b53e2515bdf6516"}]}