)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1000001,"name":"Lorenz Brun","display_name":"Lorenz","email":"lorenz@monogon.tech","username":"lorenz","avatars":[{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"27e4b119c96409ddd0a0aee4fda69e9205bf1f4a","unresolved":true,"context_lines":[{"line_number":10,"context_line":"format [1], enabling it to produce correct boot entries. Its interface"},{"line_number":11,"context_line":"was changed in the process, leading to further changes in osimage."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"In addition, osimage was passing the GPT GUID to CreateBootEntry"},{"line_number":14,"context_line":"instead of the ESP GUID. This was fixed as well."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"[1] https://en.wikipedia.org/wiki/Universally_unique_identifier#Encoding"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Ib8300e01fd1664d0c08bb033b1dc36addb925b20"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"8ad87788_a7d09950","line":15,"range":{"start_line":13,"start_character":0,"end_line":15,"end_character":0},"updated":"2021-12-02 12:00:18.000000000","message":"I don\u0027t see this change. Previously it was passsing esp.GUID, now it parses it (because of the encoding changes) and passes it.","commit_id":"46786cb17cca2949c5974ba38bbba86aa356061e"},{"author":{"_account_id":1000010,"name":"Mateusz Zalega","display_name":"msgctl","email":"mateusz@monogon.tech","username":"mateusz","avatars":[{"url":"https://www.gravatar.com/avatar/30cae8ca0782f23ce0a60ac80fda3dd9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/30cae8ca0782f23ce0a60ac80fda3dd9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/30cae8ca0782f23ce0a60ac80fda3dd9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/30cae8ca0782f23ce0a60ac80fda3dd9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"58d3370d13e26ce161f9990ebbc83c172e21eaf9","unresolved":false,"context_lines":[{"line_number":10,"context_line":"format [1], enabling it to produce correct boot entries. Its interface"},{"line_number":11,"context_line":"was changed in the process, leading to further changes in osimage."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"In addition, osimage was passing the GPT GUID to CreateBootEntry"},{"line_number":14,"context_line":"instead of the ESP GUID. This was fixed as well."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"[1] https://en.wikipedia.org/wiki/Universally_unique_identifier#Encoding"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Ib8300e01fd1664d0c08bb033b1dc36addb925b20"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"db5b6c34_03c990af","line":15,"range":{"start_line":13,"start_character":0,"end_line":15,"end_character":0},"in_reply_to":"8ad87788_a7d09950","updated":"2021-12-02 18:02:43.000000000","message":"That ended up getting fixed in another patch while I was sitting on this one. Thanks for catching it.","commit_id":"46786cb17cca2949c5974ba38bbba86aa356061e"}],"metropolis/pkg/efivarfs/boot.go":[{"author":{"_account_id":1000001,"name":"Lorenz Brun","display_name":"Lorenz","email":"lorenz@monogon.tech","username":"lorenz","avatars":[{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"27e4b119c96409ddd0a0aee4fda69e9205bf1f4a","unresolved":true,"context_lines":[{"line_number":87,"context_line":"\tdp \u003d append64(dp, t.PartitionStart)"},{"line_number":88,"context_line":"\tdp \u003d append64(dp, t.PartitionSize)"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"\t// Append the partition GUID in the mixed-endian variant."},{"line_number":91,"context_line":"\t// See: https://en.wikipedia.org/wiki/Universally_unique_identifier#Encoding"},{"line_number":92,"context_line":"\tid, _ :\u003d t.PartitionGUID.MarshalBinary()"},{"line_number":93,"context_line":"\tdp \u003d append32(dp, binary.BigEndian.Uint32(id[0:4]))"}],"source_content_type":"text/x-go","patch_set":1,"id":"ad1f1f60_34f27812","line":90,"range":{"start_line":90,"start_character":37,"end_line":90,"end_character":57},"updated":"2021-12-02 12:00:18.000000000","message":"Please reference the actual UEFI spec, Version 2.9 Appendix A where the encoding is defined, even if it might be the same as mixed endian on Wikipedia.","commit_id":"46786cb17cca2949c5974ba38bbba86aa356061e"},{"author":{"_account_id":1000010,"name":"Mateusz Zalega","display_name":"msgctl","email":"mateusz@monogon.tech","username":"mateusz","avatars":[{"url":"https://www.gravatar.com/avatar/30cae8ca0782f23ce0a60ac80fda3dd9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/30cae8ca0782f23ce0a60ac80fda3dd9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/30cae8ca0782f23ce0a60ac80fda3dd9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/30cae8ca0782f23ce0a60ac80fda3dd9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"58d3370d13e26ce161f9990ebbc83c172e21eaf9","unresolved":false,"context_lines":[{"line_number":87,"context_line":"\tdp \u003d append64(dp, t.PartitionStart)"},{"line_number":88,"context_line":"\tdp \u003d append64(dp, t.PartitionSize)"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"\t// Append the partition GUID in the mixed-endian variant."},{"line_number":91,"context_line":"\t// See: https://en.wikipedia.org/wiki/Universally_unique_identifier#Encoding"},{"line_number":92,"context_line":"\tid, _ :\u003d t.PartitionGUID.MarshalBinary()"},{"line_number":93,"context_line":"\tdp \u003d append32(dp, binary.BigEndian.Uint32(id[0:4]))"}],"source_content_type":"text/x-go","patch_set":1,"id":"ef886098_419f4a83","line":90,"range":{"start_line":90,"start_character":37,"end_line":90,"end_character":57},"in_reply_to":"ad1f1f60_34f27812","updated":"2021-12-02 18:02:43.000000000","message":"I\u0027ll reference both, since the linked Wikipedia article chapter is more readable.","commit_id":"46786cb17cca2949c5974ba38bbba86aa356061e"},{"author":{"_account_id":1000001,"name":"Lorenz Brun","display_name":"Lorenz","email":"lorenz@monogon.tech","username":"lorenz","avatars":[{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"27e4b119c96409ddd0a0aee4fda69e9205bf1f4a","unresolved":true,"context_lines":[{"line_number":89,"context_line":""},{"line_number":90,"context_line":"\t// Append the partition GUID in the mixed-endian variant."},{"line_number":91,"context_line":"\t// See: https://en.wikipedia.org/wiki/Universally_unique_identifier#Encoding"},{"line_number":92,"context_line":"\tid, _ :\u003d t.PartitionGUID.MarshalBinary()"},{"line_number":93,"context_line":"\tdp \u003d append32(dp, binary.BigEndian.Uint32(id[0:4]))"},{"line_number":94,"context_line":"\tdp \u003d append16(dp, binary.BigEndian.Uint16(id[4:6]))"},{"line_number":95,"context_line":"\tdp \u003d append16(dp, binary.BigEndian.Uint16(id[6:8]))"}],"source_content_type":"text/x-go","patch_set":1,"id":"f1c143ea_278f5c77","line":92,"range":{"start_line":92,"start_character":26,"end_line":92,"end_character":39},"updated":"2021-12-02 12:00:18.000000000","message":"I recommend using [:] to make it clear why this can never fail.","commit_id":"46786cb17cca2949c5974ba38bbba86aa356061e"},{"author":{"_account_id":1000010,"name":"Mateusz Zalega","display_name":"msgctl","email":"mateusz@monogon.tech","username":"mateusz","avatars":[{"url":"https://www.gravatar.com/avatar/30cae8ca0782f23ce0a60ac80fda3dd9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/30cae8ca0782f23ce0a60ac80fda3dd9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/30cae8ca0782f23ce0a60ac80fda3dd9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/30cae8ca0782f23ce0a60ac80fda3dd9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"58d3370d13e26ce161f9990ebbc83c172e21eaf9","unresolved":false,"context_lines":[{"line_number":89,"context_line":""},{"line_number":90,"context_line":"\t// Append the partition GUID in the mixed-endian variant."},{"line_number":91,"context_line":"\t// See: https://en.wikipedia.org/wiki/Universally_unique_identifier#Encoding"},{"line_number":92,"context_line":"\tid, _ :\u003d t.PartitionGUID.MarshalBinary()"},{"line_number":93,"context_line":"\tdp \u003d append32(dp, binary.BigEndian.Uint32(id[0:4]))"},{"line_number":94,"context_line":"\tdp \u003d append16(dp, binary.BigEndian.Uint16(id[4:6]))"},{"line_number":95,"context_line":"\tdp \u003d append16(dp, binary.BigEndian.Uint16(id[6:8]))"}],"source_content_type":"text/x-go","patch_set":1,"id":"b384595f_77087e52","line":92,"range":{"start_line":92,"start_character":26,"end_line":92,"end_character":39},"in_reply_to":"f1c143ea_278f5c77","updated":"2021-12-02 18:02:43.000000000","message":"Done","commit_id":"46786cb17cca2949c5974ba38bbba86aa356061e"},{"author":{"_account_id":1000001,"name":"Lorenz Brun","display_name":"Lorenz","email":"lorenz@monogon.tech","username":"lorenz","avatars":[{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"27e4b119c96409ddd0a0aee4fda69e9205bf1f4a","unresolved":true,"context_lines":[{"line_number":90,"context_line":"\t// Append the partition GUID in the mixed-endian variant."},{"line_number":91,"context_line":"\t// See: https://en.wikipedia.org/wiki/Universally_unique_identifier#Encoding"},{"line_number":92,"context_line":"\tid, _ :\u003d t.PartitionGUID.MarshalBinary()"},{"line_number":93,"context_line":"\tdp \u003d append32(dp, binary.BigEndian.Uint32(id[0:4]))"},{"line_number":94,"context_line":"\tdp \u003d append16(dp, binary.BigEndian.Uint16(id[4:6]))"},{"line_number":95,"context_line":"\tdp \u003d append16(dp, binary.BigEndian.Uint16(id[6:8]))"},{"line_number":96,"context_line":"\tdp \u003d append(dp, id[8:16]...)"}],"source_content_type":"text/x-go","patch_set":1,"id":"842b76d5_79ff8d69","line":93,"range":{"start_line":93,"start_character":19,"end_line":93,"end_character":42},"updated":"2021-12-02 12:00:18.000000000","message":"Unless I\u0027m missing something this is wrongly encoded. The first 4 bytes are little endian, but we\u0027re encoding them as big endian.","commit_id":"46786cb17cca2949c5974ba38bbba86aa356061e"},{"author":{"_account_id":1000010,"name":"Mateusz Zalega","display_name":"msgctl","email":"mateusz@monogon.tech","username":"mateusz","avatars":[{"url":"https://www.gravatar.com/avatar/30cae8ca0782f23ce0a60ac80fda3dd9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/30cae8ca0782f23ce0a60ac80fda3dd9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/30cae8ca0782f23ce0a60ac80fda3dd9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/30cae8ca0782f23ce0a60ac80fda3dd9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"17ae1fb6d4a23acc44e295f4d38153720d3423fa","unresolved":false,"context_lines":[{"line_number":90,"context_line":"\t// Append the partition GUID in the mixed-endian variant."},{"line_number":91,"context_line":"\t// See: https://en.wikipedia.org/wiki/Universally_unique_identifier#Encoding"},{"line_number":92,"context_line":"\tid, _ :\u003d t.PartitionGUID.MarshalBinary()"},{"line_number":93,"context_line":"\tdp \u003d append32(dp, binary.BigEndian.Uint32(id[0:4]))"},{"line_number":94,"context_line":"\tdp \u003d append16(dp, binary.BigEndian.Uint16(id[4:6]))"},{"line_number":95,"context_line":"\tdp \u003d append16(dp, binary.BigEndian.Uint16(id[6:8]))"},{"line_number":96,"context_line":"\tdp \u003d append(dp, id[8:16]...)"}],"source_content_type":"text/x-go","patch_set":1,"id":"47977dba_4f18a375","line":93,"range":{"start_line":93,"start_character":19,"end_line":93,"end_character":42},"in_reply_to":"549b1122_58176b4d","updated":"2021-12-06 16:23:10.000000000","message":"I\u0027m leaving a couple of points here after discussing this with Lorenz:\n- go-diskfs performs a correct transform from a string to binary representation of EFI GUID.\n- The problem stemmed from Google\u0027s golang UUID library not doing the same, because why should it - it\u0027s an EFI-only concept.\n- We still need to apply a binary permutation to the EFI UUID around the highlighted part of code.\n- …but that\u0027s irrelevant to the host byte order, since Google UUID\u0027s internal representation is, correctly, a byte array.\n- This permutation will be refactored outside this function.","commit_id":"46786cb17cca2949c5974ba38bbba86aa356061e"},{"author":{"_account_id":1000010,"name":"Mateusz Zalega","display_name":"msgctl","email":"mateusz@monogon.tech","username":"mateusz","avatars":[{"url":"https://www.gravatar.com/avatar/30cae8ca0782f23ce0a60ac80fda3dd9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/30cae8ca0782f23ce0a60ac80fda3dd9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/30cae8ca0782f23ce0a60ac80fda3dd9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/30cae8ca0782f23ce0a60ac80fda3dd9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"58d3370d13e26ce161f9990ebbc83c172e21eaf9","unresolved":false,"context_lines":[{"line_number":90,"context_line":"\t// Append the partition GUID in the mixed-endian variant."},{"line_number":91,"context_line":"\t// See: https://en.wikipedia.org/wiki/Universally_unique_identifier#Encoding"},{"line_number":92,"context_line":"\tid, _ :\u003d t.PartitionGUID.MarshalBinary()"},{"line_number":93,"context_line":"\tdp \u003d append32(dp, binary.BigEndian.Uint32(id[0:4]))"},{"line_number":94,"context_line":"\tdp \u003d append16(dp, binary.BigEndian.Uint16(id[4:6]))"},{"line_number":95,"context_line":"\tdp \u003d append16(dp, binary.BigEndian.Uint16(id[6:8]))"},{"line_number":96,"context_line":"\tdp \u003d append(dp, id[8:16]...)"}],"source_content_type":"text/x-go","patch_set":1,"id":"549b1122_58176b4d","line":93,"range":{"start_line":93,"start_character":19,"end_line":93,"end_character":42},"in_reply_to":"842b76d5_79ff8d69","updated":"2021-12-02 18:02:43.000000000","message":"That\u0027s true. The funny thing is, this produces correct boot entries that OVMF could boot from.\n\nI was working on this piece of code in an attempt to write proper boot entry tests, ~2 weeks ago. I might\u0027ve adjusted this conversion in confusion, assuming I got it wrong, then being too glad it worked to look twice.\n\nI looked at go-diskfs today. I found that it performs endianness conversion incorrectly upon writing the GPT, which led to the on-disk GUID being different than the one advertised by the go-diskfs GPT data structure, as used in osimage. This, in conjunction with a bad conversion here, caused the whole thing to appear OK.\n\nhttps://github.com/diskfs/go-diskfs/blob/master/partition/gpt/common.go#L4 (comments here look quite bizzare to me)\nhttps://github.com/diskfs/go-diskfs/blob/master/partition/gpt/table.go#L295\n\nI\u0027ll rewrite efivarfs to be correct. We\u0027ll need either a fix in go-diskfs or a workaround in osimage to make boot entry creation work as a whole.\n\nIt looks like I never even needed to fix efivarfs - it would work fine as long as it ran on little endian machines. Still, I think this change should go in to ensure correctness.","commit_id":"46786cb17cca2949c5974ba38bbba86aa356061e"},{"author":{"_account_id":1000001,"name":"Lorenz Brun","display_name":"Lorenz","email":"lorenz@monogon.tech","username":"lorenz","avatars":[{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"e5989a344fed37e2ab0dde534af0f2baf52b605b","unresolved":true,"context_lines":[{"line_number":87,"context_line":"\tdp \u003d append64(dp, t.PartitionSize)"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"\t// Append the partition GUID in the EFI format."},{"line_number":90,"context_line":"\t// See: UEFI specification, version 2.9, appendix A"},{"line_number":91,"context_line":"\t// https://uefi.org/sites/default/files/resources/UEFI_Spec_2_9_2021_03_18.pdf"},{"line_number":92,"context_line":"\tdp \u003d append(dp, MarshalEFIGUID(t.PartitionGUID)...)"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"\tdp \u003d append(dp,"}],"source_content_type":"text/x-go","patch_set":4,"id":"dbecc139_4b16626e","line":91,"range":{"start_line":90,"start_character":4,"end_line":91,"end_character":79},"updated":"2021-12-07 10:54:44.000000000","message":"This should be part of the function documentation.","commit_id":"8c0a56e127767a2886925d72a8ba1debf5462164"},{"author":{"_account_id":1000010,"name":"Mateusz Zalega","display_name":"msgctl","email":"mateusz@monogon.tech","username":"mateusz","avatars":[{"url":"https://www.gravatar.com/avatar/30cae8ca0782f23ce0a60ac80fda3dd9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/30cae8ca0782f23ce0a60ac80fda3dd9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/30cae8ca0782f23ce0a60ac80fda3dd9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/30cae8ca0782f23ce0a60ac80fda3dd9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"790c9db28004e851fb081afafa677a3b78392259","unresolved":false,"context_lines":[{"line_number":87,"context_line":"\tdp \u003d append64(dp, t.PartitionSize)"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"\t// Append the partition GUID in the EFI format."},{"line_number":90,"context_line":"\t// See: UEFI specification, version 2.9, appendix A"},{"line_number":91,"context_line":"\t// https://uefi.org/sites/default/files/resources/UEFI_Spec_2_9_2021_03_18.pdf"},{"line_number":92,"context_line":"\tdp \u003d append(dp, MarshalEFIGUID(t.PartitionGUID)...)"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"\tdp \u003d append(dp,"}],"source_content_type":"text/x-go","patch_set":4,"id":"9a6809b3_1e564b44","line":91,"range":{"start_line":90,"start_character":4,"end_line":91,"end_character":79},"in_reply_to":"dbecc139_4b16626e","updated":"2021-12-08 15:29:29.000000000","message":"Done","commit_id":"8c0a56e127767a2886925d72a8ba1debf5462164"}]}