)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000001,"name":"Lorenz Brun","display_name":"Lorenz","email":"lorenz@monogon.tech","username":"lorenz","avatars":[{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"14b327b942c110b833b945a74660b8fd90230760","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"af4ee0b3_fd0bd983","updated":"2025-06-24 16:08:24.000000000","message":"You can change the BlockSize in fat32 to get the alignment to 4096. For development at least that shouldn\u0027t be a problem AFAIK.","commit_id":"4c77bb3c7eb110c30783d662d362d0ebded5a363"},{"author":{"_account_id":1000038,"name":"Jan Schär","display_name":"Jan","email":"jan@monogon.tech","username":"jan","avatars":[{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"128c47c6cf5dcb4dd86ff059c42e08f76ecf44e0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3bc0454d_51e9d97c","in_reply_to":"4629f0fa_988cdb8b","updated":"2025-06-25 08:36:37.000000000","message":"Instead of changing the block size, we could also leave gaps in the allocated blocks to align files to 4096. But I think this is not worth it, it\u0027s already fast enough.","commit_id":"4c77bb3c7eb110c30783d662d362d0ebded5a363"},{"author":{"_account_id":1000001,"name":"Lorenz Brun","display_name":"Lorenz","email":"lorenz@monogon.tech","username":"lorenz","avatars":[{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"d8af1d11cea97beb9552d2885c2a45ced7ae3ba9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4629f0fa_988cdb8b","in_reply_to":"af4ee0b3_fd0bd983","updated":"2025-06-24 16:38:44.000000000","message":"This would require a disk geometry change, so out of scope here.","commit_id":"4c77bb3c7eb110c30783d662d362d0ebded5a363"}],"osbase/fat32/utils.go":[{"author":{"_account_id":1000001,"name":"Lorenz Brun","display_name":"Lorenz","email":"lorenz@monogon.tech","username":"lorenz","avatars":[{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"14b327b942c110b833b945a74660b8fd90230760","unresolved":true,"context_lines":[{"line_number":27,"context_line":"}"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"func (b *blockWriter) ReadFrom(r io.Reader) (n int64, err error) {"},{"line_number":30,"context_line":"\tn, err \u003d io.Copy(b.w, r)"},{"line_number":31,"context_line":"\tb.n +\u003d n"},{"line_number":32,"context_line":"\treturn"},{"line_number":33,"context_line":"}"}],"source_content_type":"text/x-go","patch_set":1,"id":"f2896152_8250b219","line":30,"range":{"start_line":30,"start_character":10,"end_line":30,"end_character":17},"updated":"2025-06-24 16:08:24.000000000","message":"At first glance this makes little sense (why not just io.Copy into the blockWriter?). But you\u0027re using it because io.Copy does a bunch of dynamic type assertions to try to offload the copy operation. Put a small (not more than 1-2 lines) comment either on the function or in it to note this.","commit_id":"4c77bb3c7eb110c30783d662d362d0ebded5a363"},{"author":{"_account_id":1000038,"name":"Jan Schär","display_name":"Jan","email":"jan@monogon.tech","username":"jan","avatars":[{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"128c47c6cf5dcb4dd86ff059c42e08f76ecf44e0","unresolved":false,"context_lines":[{"line_number":27,"context_line":"}"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"func (b *blockWriter) ReadFrom(r io.Reader) (n int64, err error) {"},{"line_number":30,"context_line":"\tn, err \u003d io.Copy(b.w, r)"},{"line_number":31,"context_line":"\tb.n +\u003d n"},{"line_number":32,"context_line":"\treturn"},{"line_number":33,"context_line":"}"}],"source_content_type":"text/x-go","patch_set":1,"id":"da755298_710b2aec","line":30,"range":{"start_line":30,"start_character":10,"end_line":30,"end_character":17},"in_reply_to":"f2896152_8250b219","updated":"2025-06-25 08:36:37.000000000","message":"Done","commit_id":"4c77bb3c7eb110c30783d662d362d0ebded5a363"}]}