)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000001,"name":"Lorenz Brun","display_name":"Lorenz","email":"lorenz@monogon.tech","username":"lorenz","avatars":[{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"02a9e04e3d9feb5098cf1675559ec8c9e1adc8a1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3b1ca6b8_a87a0d2d","updated":"2021-11-09 16:20:07.000000000","message":"This does not build, pushing it back into your queue\n","commit_id":"b0368c923ec16cc539df492bb7b209ac71e7751a"},{"author":{"_account_id":1000001,"name":"Lorenz Brun","display_name":"Lorenz","email":"lorenz@monogon.tech","username":"lorenz","avatars":[{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"5d5ac45df4902e881068869d6ce6006617549c18","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"87073923_0157d8a1","updated":"2021-11-18 12:27:18.000000000","message":"One more small thing, rest LGTM","commit_id":"6a8c225a75f40e85671167155f71162fb21477a6"}],"metropolis/pkg/efivarfs/boot.go":[{"author":{"_account_id":1000001,"name":"Lorenz Brun","display_name":"Lorenz","email":"lorenz@monogon.tech","username":"lorenz","avatars":[{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"e998c4cae1abe141aeec078eac8ddcd33b1cf893","unresolved":true,"context_lines":[{"line_number":49,"context_line":"const defaultAttrsByte0 uint8 \u003d 7"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"// TODO understand which parts of UTF16 are not supported by EFI (officially UCS2)"},{"line_number":52,"context_line":"var encoding \u003d unicode.UTF16(unicode.LittleEndian, unicode.IgnoreBOM)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"// BootEntry represents a subset of the contents of a Boot#### EFI variable."},{"line_number":55,"context_line":"type BootEntry struct {"}],"source_content_type":"text/x-go","patch_set":5,"id":"69770549_f05a8988","line":52,"updated":"2021-11-16 17:11:05.000000000","message":"Please deduplicate this with the definition from ExtractString() in this package. Also take the comment from there which contains a bit more information.","commit_id":"d972626c7ad91b9df369d4eb592ee2b233fe64bb"},{"author":{"_account_id":1000010,"name":"Mateusz Zalega","display_name":"msgctl","email":"mateusz@monogon.tech","username":"mateusz","avatars":[{"url":"https://www.gravatar.com/avatar/30cae8ca0782f23ce0a60ac80fda3dd9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/30cae8ca0782f23ce0a60ac80fda3dd9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/30cae8ca0782f23ce0a60ac80fda3dd9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/30cae8ca0782f23ce0a60ac80fda3dd9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"1ae6696d5e67865f5f32cb40343eed8f93a61562","unresolved":false,"context_lines":[{"line_number":49,"context_line":"const defaultAttrsByte0 uint8 \u003d 7"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"// TODO understand which parts of UTF16 are not supported by EFI (officially UCS2)"},{"line_number":52,"context_line":"var encoding \u003d unicode.UTF16(unicode.LittleEndian, unicode.IgnoreBOM)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"// BootEntry represents a subset of the contents of a Boot#### EFI variable."},{"line_number":55,"context_line":"type BootEntry struct {"}],"source_content_type":"text/x-go","patch_set":5,"id":"5794f425_450349c4","line":52,"in_reply_to":"69770549_f05a8988","updated":"2021-11-17 21:00:58.000000000","message":"Done","commit_id":"d972626c7ad91b9df369d4eb592ee2b233fe64bb"}],"metropolis/pkg/efivarfs/efivarfs.go":[{"author":{"_account_id":1000001,"name":"Lorenz Brun","display_name":"Lorenz","email":"lorenz@monogon.tech","username":"lorenz","avatars":[{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"152a1824c342d8b8d5733e151733cb2311138dc0","unresolved":true,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"// Encoding returns an interface that can be used to encode and decode UCS-2"},{"line_number":39,"context_line":"// strings used by EFI."},{"line_number":40,"context_line":"func Encoding() encoding.Encoding {"},{"line_number":41,"context_line":"\t// This defines the Unicode encoding used by UEFI which is UCS-2 Little"},{"line_number":42,"context_line":"\t// Endian. For BMP characters UTF-16 is equivalent to UCS-2. See the UEFI"},{"line_number":43,"context_line":"\t// Spec 2.9, Sections 33.2.6 and 1.8.1.// supported by EFI (officially UCS2)"}],"source_content_type":"text/x-go","patch_set":7,"id":"7b8db02f_59564ce5","line":40,"range":{"start_line":40,"start_character":5,"end_line":40,"end_character":13},"updated":"2021-11-18 11:37:13.000000000","message":"This can just be a variable, the encoding.Encoder interface itself doesn\u0027t keep state.","commit_id":"2763ad5dfaee30e338aedf634cf1514c273c0f72"},{"author":{"_account_id":1000010,"name":"Mateusz Zalega","display_name":"msgctl","email":"mateusz@monogon.tech","username":"mateusz","avatars":[{"url":"https://www.gravatar.com/avatar/30cae8ca0782f23ce0a60ac80fda3dd9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/30cae8ca0782f23ce0a60ac80fda3dd9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/30cae8ca0782f23ce0a60ac80fda3dd9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/30cae8ca0782f23ce0a60ac80fda3dd9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"9677a60e571ec84af73ecbcba017bca28c2d4c03","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"// Encoding returns an interface that can be used to encode and decode UCS-2"},{"line_number":39,"context_line":"// strings used by EFI."},{"line_number":40,"context_line":"func Encoding() encoding.Encoding {"},{"line_number":41,"context_line":"\t// This defines the Unicode encoding used by UEFI which is UCS-2 Little"},{"line_number":42,"context_line":"\t// Endian. For BMP characters UTF-16 is equivalent to UCS-2. See the UEFI"},{"line_number":43,"context_line":"\t// Spec 2.9, Sections 33.2.6 and 1.8.1.// supported by EFI (officially UCS2)"}],"source_content_type":"text/x-go","patch_set":7,"id":"8fc8a1ea_bf6d81e9","line":40,"range":{"start_line":40,"start_character":5,"end_line":40,"end_character":13},"in_reply_to":"7b8db02f_59564ce5","updated":"2021-11-18 11:57:15.000000000","message":"Done","commit_id":"2763ad5dfaee30e338aedf634cf1514c273c0f72"},{"author":{"_account_id":1000001,"name":"Lorenz Brun","display_name":"Lorenz","email":"lorenz@monogon.tech","username":"lorenz","avatars":[{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"5d5ac45df4902e881068869d6ce6006617549c18","unresolved":true,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"// Encoding defines the Unicode encoding used by UEFI, which is UCS-2 Little"},{"line_number":38,"context_line":"// Endian. For BMP characters UTF-16 is equivalent to UCS-2. See the UEFI"},{"line_number":39,"context_line":"// Spec 2.9, Sections 33.2.6 and 1.8.1.// supported by EFI (officially UCS2)"},{"line_number":40,"context_line":"var Encoding \u003d unicode.UTF16(unicode.LittleEndian, unicode.IgnoreBOM)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"// ExtractString returns EFI variable data based on raw variable file contents."}],"source_content_type":"text/x-go","patch_set":9,"id":"33cb261f_bac1f536","line":39,"range":{"start_line":39,"start_character":39,"end_line":39,"end_character":76},"updated":"2021-11-18 12:27:18.000000000","message":"Could you drop this?","commit_id":"6a8c225a75f40e85671167155f71162fb21477a6"},{"author":{"_account_id":1000010,"name":"Mateusz Zalega","display_name":"msgctl","email":"mateusz@monogon.tech","username":"mateusz","avatars":[{"url":"https://www.gravatar.com/avatar/30cae8ca0782f23ce0a60ac80fda3dd9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/30cae8ca0782f23ce0a60ac80fda3dd9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/30cae8ca0782f23ce0a60ac80fda3dd9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/30cae8ca0782f23ce0a60ac80fda3dd9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"e686ca13885f1e3823015faa72ef6d005f911389","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"// Encoding defines the Unicode encoding used by UEFI, which is UCS-2 Little"},{"line_number":38,"context_line":"// Endian. For BMP characters UTF-16 is equivalent to UCS-2. See the UEFI"},{"line_number":39,"context_line":"// Spec 2.9, Sections 33.2.6 and 1.8.1.// supported by EFI (officially UCS2)"},{"line_number":40,"context_line":"var Encoding \u003d unicode.UTF16(unicode.LittleEndian, unicode.IgnoreBOM)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"// ExtractString returns EFI variable data based on raw variable file contents."}],"source_content_type":"text/x-go","patch_set":9,"id":"62788d36_618eee27","line":39,"range":{"start_line":39,"start_character":39,"end_line":39,"end_character":76},"in_reply_to":"33cb261f_bac1f536","updated":"2021-11-18 12:59:08.000000000","message":"Done","commit_id":"6a8c225a75f40e85671167155f71162fb21477a6"}]}