)]}'
{"metropolis/test/e2e/suites/core/run_test.go":[{"author":{"_account_id":1000038,"name":"Jan Schär","display_name":"Jan","email":"jan@monogon.tech","username":"jan","avatars":[{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"88a25d90412a28831bb70f3566170777a248d06b","unresolved":true,"context_lines":[{"line_number":99,"context_line":"\t\t}"},{"line_number":100,"context_line":"\t}()"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"\tt.Log(\"E2E: Cluster running, starting tests...\")"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"\t// Dial first node\u0027s curator."},{"line_number":105,"context_line":"\tcreds :\u003d rpc.NewAuthenticatedCredentials(cluster.Owner, rpc.WantInsecure())"}],"source_content_type":"text/x-go","patch_set":1,"id":"796dbcf5_9a271479","line":102,"range":{"start_line":102,"start_character":1,"end_line":102,"end_character":49},"updated":"2025-03-27 17:12:23.000000000","message":"You can just remove this log in all three test suites. LaunchCluster already logs almost the same thing just before it returns:\n\n```\nTT|          test launch ! Cluster: want 2 up nodes, have 2\nTT|          test launch ! Cluster: all nodes up:\nTT|          test launch ! Cluster:  0. metropolis-f63b1f29116d77aa1c5757af2266e84f at 10.1.0.2\nTT|          test launch ! Cluster:  1. metropolis-2b433f335d384e8489370a2672058a76 at 10.1.0.3\nTT|          test launch ! Cluster: starting tests...\nTT|          test launch ! E2E: Cluster running, starting tests...\n```","commit_id":"55810fd0b8abbd1a39bf78ebe1801365ebb05c8f"},{"author":{"_account_id":1000019,"name":"Tim Windelschmidt","display_name":"Tim","email":"tim@monogon.tech","username":"fionera","avatars":[{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"3413ab92c463c8a9015bb902a5596551a7ba2365","unresolved":false,"context_lines":[{"line_number":99,"context_line":"\t\t}"},{"line_number":100,"context_line":"\t}()"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"\tt.Log(\"E2E: Cluster running, starting tests...\")"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"\t// Dial first node\u0027s curator."},{"line_number":105,"context_line":"\tcreds :\u003d rpc.NewAuthenticatedCredentials(cluster.Owner, rpc.WantInsecure())"}],"source_content_type":"text/x-go","patch_set":1,"id":"d667eb8b_8dc25454","line":102,"range":{"start_line":102,"start_character":1,"end_line":102,"end_character":49},"in_reply_to":"796dbcf5_9a271479","updated":"2025-03-27 20:36:59.000000000","message":"Done","commit_id":"55810fd0b8abbd1a39bf78ebe1801365ebb05c8f"}],"metropolis/test/util/runners.go":[{"author":{"_account_id":1000038,"name":"Jan Schär","display_name":"Jan","email":"jan@monogon.tech","username":"jan","avatars":[{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"88a25d90412a28831bb70f3566170777a248d06b","unresolved":true,"context_lines":[{"line_number":21,"context_line":"\tstart :\u003d time.Now()"},{"line_number":22,"context_line":"\tctx, cancel :\u003d context.WithTimeout(ctx, timeout)"},{"line_number":23,"context_line":"\tt.Helper()"},{"line_number":24,"context_line":"\tt.Logf(\"Test: %s: starting...\", name)"},{"line_number":25,"context_line":"\treturn t.Run(name, func(t *testing.T) {"},{"line_number":26,"context_line":"\t\tdefer cancel()"},{"line_number":27,"context_line":"\t\tvar lastErr \u003d errors.New(\"test didn\u0027t run to completion at least once\")"}],"source_content_type":"text/x-go","patch_set":1,"id":"49a426c3_b2777766","line":24,"range":{"start_line":24,"start_character":1,"end_line":24,"end_character":7},"updated":"2025-03-27 17:12:23.000000000","message":"I would change these two logs to fmt.Printf (and add a \\n at the end). Test logs are buffered and only shown at the end, but it\u0027s better if these two logs are shown inline with the test launch and machine logs.","commit_id":"55810fd0b8abbd1a39bf78ebe1801365ebb05c8f"},{"author":{"_account_id":1000019,"name":"Tim Windelschmidt","display_name":"Tim","email":"tim@monogon.tech","username":"fionera","avatars":[{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"3413ab92c463c8a9015bb902a5596551a7ba2365","unresolved":false,"context_lines":[{"line_number":21,"context_line":"\tstart :\u003d time.Now()"},{"line_number":22,"context_line":"\tctx, cancel :\u003d context.WithTimeout(ctx, timeout)"},{"line_number":23,"context_line":"\tt.Helper()"},{"line_number":24,"context_line":"\tt.Logf(\"Test: %s: starting...\", name)"},{"line_number":25,"context_line":"\treturn t.Run(name, func(t *testing.T) {"},{"line_number":26,"context_line":"\t\tdefer cancel()"},{"line_number":27,"context_line":"\t\tvar lastErr \u003d errors.New(\"test didn\u0027t run to completion at least once\")"}],"source_content_type":"text/x-go","patch_set":1,"id":"7de663d9_0a2c61cb","line":24,"range":{"start_line":24,"start_character":1,"end_line":24,"end_character":7},"in_reply_to":"49a426c3_b2777766","updated":"2025-03-27 20:36:59.000000000","message":"Done","commit_id":"55810fd0b8abbd1a39bf78ebe1801365ebb05c8f"}]}