)]}'
{"metropolis/installer/test/run_test.go":[{"author":{"_account_id":1000038,"name":"Jan Schär","display_name":"Jan","email":"jan@monogon.tech","username":"jan","avatars":[{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"e87109648df03d4976541aa1d7774d48f4ca914e","unresolved":true,"context_lines":[{"line_number":165,"context_line":"\t// ESP contents are in order."},{"line_number":166,"context_line":"\timage, err :\u003d diskfs.OpenWithMode(installerImage, diskfs.ReadOnly)"},{"line_number":167,"context_line":"\tif err !\u003d nil {"},{"line_number":168,"context_line":"\t\tt.Errorf(\"Couldn\u0027t open the installer image at %q: %s\", installerImage, err.Error())"},{"line_number":169,"context_line":"\t}"},{"line_number":170,"context_line":"\t// Verify that GPT exists."},{"line_number":171,"context_line":"\tti, err :\u003d image.GetPartitionTable()"}],"source_content_type":"text/x-go","patch_set":2,"id":"aaba4c7c_1cdce974","line":168,"range":{"start_line":168,"start_character":4,"end_line":168,"end_character":10},"updated":"2025-03-27 10:06:53.000000000","message":"This should also be fatal, because image is nil if we are here.","commit_id":"ff6a2bc8fdc22d803b625fb6c407a47febd6d372"},{"author":{"_account_id":1000019,"name":"Tim Windelschmidt","display_name":"Tim","email":"tim@monogon.tech","username":"fionera","avatars":[{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"cdc1be9f76b4a31ff711547d8891447d00c95647","unresolved":false,"context_lines":[{"line_number":165,"context_line":"\t// ESP contents are in order."},{"line_number":166,"context_line":"\timage, err :\u003d diskfs.OpenWithMode(installerImage, diskfs.ReadOnly)"},{"line_number":167,"context_line":"\tif err !\u003d nil {"},{"line_number":168,"context_line":"\t\tt.Errorf(\"Couldn\u0027t open the installer image at %q: %s\", installerImage, err.Error())"},{"line_number":169,"context_line":"\t}"},{"line_number":170,"context_line":"\t// Verify that GPT exists."},{"line_number":171,"context_line":"\tti, err :\u003d image.GetPartitionTable()"}],"source_content_type":"text/x-go","patch_set":2,"id":"89ad8931_e28d87e2","line":168,"range":{"start_line":168,"start_character":4,"end_line":168,"end_character":10},"in_reply_to":"aaba4c7c_1cdce974","updated":"2025-05-28 15:09:02.000000000","message":"Done","commit_id":"ff6a2bc8fdc22d803b625fb6c407a47febd6d372"},{"author":{"_account_id":1000038,"name":"Jan Schär","display_name":"Jan","email":"jan@monogon.tech","username":"jan","avatars":[{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"e87109648df03d4976541aa1d7774d48f4ca914e","unresolved":true,"context_lines":[{"line_number":259,"context_line":"\t// Verify the resulting node image. Check whether the node GPT was created."},{"line_number":260,"context_line":"\tstorage, err :\u003d diskfs.OpenWithMode(storagePath, diskfs.ReadOnly)"},{"line_number":261,"context_line":"\tif err !\u003d nil {"},{"line_number":262,"context_line":"\t\tt.Errorf(\"Couldn\u0027t open the resulting node image at %q: %s\", storagePath, err.Error())"},{"line_number":263,"context_line":"\t}"},{"line_number":264,"context_line":"\t// Verify that GPT exists."},{"line_number":265,"context_line":"\tti, err :\u003d storage.GetPartitionTable()"}],"source_content_type":"text/x-go","patch_set":2,"id":"ea26c6ea_90817f24","line":262,"range":{"start_line":262,"start_character":4,"end_line":262,"end_character":10},"updated":"2025-03-27 10:06:53.000000000","message":"Same here.","commit_id":"ff6a2bc8fdc22d803b625fb6c407a47febd6d372"},{"author":{"_account_id":1000019,"name":"Tim Windelschmidt","display_name":"Tim","email":"tim@monogon.tech","username":"fionera","avatars":[{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"cdc1be9f76b4a31ff711547d8891447d00c95647","unresolved":false,"context_lines":[{"line_number":259,"context_line":"\t// Verify the resulting node image. Check whether the node GPT was created."},{"line_number":260,"context_line":"\tstorage, err :\u003d diskfs.OpenWithMode(storagePath, diskfs.ReadOnly)"},{"line_number":261,"context_line":"\tif err !\u003d nil {"},{"line_number":262,"context_line":"\t\tt.Errorf(\"Couldn\u0027t open the resulting node image at %q: %s\", storagePath, err.Error())"},{"line_number":263,"context_line":"\t}"},{"line_number":264,"context_line":"\t// Verify that GPT exists."},{"line_number":265,"context_line":"\tti, err :\u003d storage.GetPartitionTable()"}],"source_content_type":"text/x-go","patch_set":2,"id":"f5193496_1cd23dc2","line":262,"range":{"start_line":262,"start_character":4,"end_line":262,"end_character":10},"in_reply_to":"ea26c6ea_90817f24","updated":"2025-05-28 15:09:02.000000000","message":"Done","commit_id":"ff6a2bc8fdc22d803b625fb6c407a47febd6d372"}],"metropolis/node/core/curator/state_test.go":[{"author":{"_account_id":1000038,"name":"Jan Schär","display_name":"Jan","email":"jan@monogon.tech","username":"jan","avatars":[{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"e87109648df03d4976541aa1d7774d48f4ca914e","unresolved":true,"context_lines":[{"line_number":48,"context_line":"\t// Test Key() with invalid IDs."},{"line_number":49,"context_line":"\t_, err \u003d p.Key(\"\")"},{"line_number":50,"context_line":"\tif err \u003d\u003d nil {"},{"line_number":51,"context_line":"\t\tt.Fatal(\"Key(bar/baz) returned nil, wanted error\")"},{"line_number":52,"context_line":"\t}"},{"line_number":53,"context_line":"\t_, err \u003d p.Key(\"bar/baz\")"},{"line_number":54,"context_line":"\tif err \u003d\u003d nil {"}],"source_content_type":"text/x-go","patch_set":2,"id":"a403bd17_c8fe8fe2","line":51,"range":{"start_line":51,"start_character":4,"end_line":51,"end_character":9},"updated":"2025-03-27 10:06:53.000000000","message":"These don\u0027t need to be fatal.","commit_id":"ff6a2bc8fdc22d803b625fb6c407a47febd6d372"},{"author":{"_account_id":1000019,"name":"Tim Windelschmidt","display_name":"Tim","email":"tim@monogon.tech","username":"fionera","avatars":[{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"cdc1be9f76b4a31ff711547d8891447d00c95647","unresolved":false,"context_lines":[{"line_number":48,"context_line":"\t// Test Key() with invalid IDs."},{"line_number":49,"context_line":"\t_, err \u003d p.Key(\"\")"},{"line_number":50,"context_line":"\tif err \u003d\u003d nil {"},{"line_number":51,"context_line":"\t\tt.Fatal(\"Key(bar/baz) returned nil, wanted error\")"},{"line_number":52,"context_line":"\t}"},{"line_number":53,"context_line":"\t_, err \u003d p.Key(\"bar/baz\")"},{"line_number":54,"context_line":"\tif err \u003d\u003d nil {"}],"source_content_type":"text/x-go","patch_set":2,"id":"c08933b2_2ecdadd5","line":51,"range":{"start_line":51,"start_character":4,"end_line":51,"end_character":9},"in_reply_to":"a403bd17_c8fe8fe2","updated":"2025-05-28 15:09:02.000000000","message":"Done","commit_id":"ff6a2bc8fdc22d803b625fb6c407a47febd6d372"}],"metropolis/node/kubernetes/networkpolicy/networkpolicy_test.go":[{"author":{"_account_id":1000038,"name":"Jan Schär","display_name":"Jan","email":"jan@monogon.tech","username":"jan","avatars":[{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"e87109648df03d4976541aa1d7774d48f4ca914e","unresolved":true,"context_lines":[{"line_number":810,"context_line":"\t\t\trecorder :\u003d \u0026testRecorder{t: t}"},{"line_number":811,"context_line":"\t\t\tnft, err :\u003d nftctrl.New(recorder, podIfaceGroup)"},{"line_number":812,"context_line":"\t\t\tif err !\u003d nil {"},{"line_number":813,"context_line":"\t\t\t\tt.Errorf(\"Failed to create nftctrl: %v\", err)"},{"line_number":814,"context_line":"\t\t\t\treturn"},{"line_number":815,"context_line":"\t\t\t}"},{"line_number":816,"context_line":"\t\t\tdefer nft.Close()"}],"source_content_type":"text/x-go","patch_set":2,"id":"d9b0c726_cec2c11b","line":813,"range":{"start_line":813,"start_character":6,"end_line":813,"end_character":12},"updated":"2025-03-27 10:06:53.000000000","message":"This and the one below could also be changed to fatal for consistency. There are also more of these in the init test cases further below.","commit_id":"ff6a2bc8fdc22d803b625fb6c407a47febd6d372"},{"author":{"_account_id":1000019,"name":"Tim Windelschmidt","display_name":"Tim","email":"tim@monogon.tech","username":"fionera","avatars":[{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"cdc1be9f76b4a31ff711547d8891447d00c95647","unresolved":false,"context_lines":[{"line_number":810,"context_line":"\t\t\trecorder :\u003d \u0026testRecorder{t: t}"},{"line_number":811,"context_line":"\t\t\tnft, err :\u003d nftctrl.New(recorder, podIfaceGroup)"},{"line_number":812,"context_line":"\t\t\tif err !\u003d nil {"},{"line_number":813,"context_line":"\t\t\t\tt.Errorf(\"Failed to create nftctrl: %v\", err)"},{"line_number":814,"context_line":"\t\t\t\treturn"},{"line_number":815,"context_line":"\t\t\t}"},{"line_number":816,"context_line":"\t\t\tdefer nft.Close()"}],"source_content_type":"text/x-go","patch_set":2,"id":"3ad20710_d879666d","line":813,"range":{"start_line":813,"start_character":6,"end_line":813,"end_character":12},"in_reply_to":"d9b0c726_cec2c11b","updated":"2025-05-28 15:09:02.000000000","message":"Done","commit_id":"ff6a2bc8fdc22d803b625fb6c407a47febd6d372"},{"author":{"_account_id":1000038,"name":"Jan Schär","display_name":"Jan","email":"jan@monogon.tech","username":"jan","avatars":[{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"e87109648df03d4976541aa1d7774d48f4ca914e","unresolved":true,"context_lines":[{"line_number":833,"context_line":"\t\t\t\tcmd.Stderr \u003d os.Stderr"},{"line_number":834,"context_line":"\t\t\t\tcmd.Run()"},{"line_number":835,"context_line":""},{"line_number":836,"context_line":"\t\t\t\tt.Fatal(\"connectivity test failed\")"},{"line_number":837,"context_line":"\t\t\t}"},{"line_number":838,"context_line":""},{"line_number":839,"context_line":"\t\t\tkubernetes.nft \u003d nil"}],"source_content_type":"text/x-go","patch_set":2,"id":"7dd2e047_ecaa7caa","line":836,"range":{"start_line":836,"start_character":6,"end_line":836,"end_character":11},"updated":"2025-03-27 10:06:53.000000000","message":"This should be left as Error, because the reset below should still happen if this fails. We want to run all the testcases, and not stop at the first one that fails.","commit_id":"ff6a2bc8fdc22d803b625fb6c407a47febd6d372"},{"author":{"_account_id":1000019,"name":"Tim Windelschmidt","display_name":"Tim","email":"tim@monogon.tech","username":"fionera","avatars":[{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"cdc1be9f76b4a31ff711547d8891447d00c95647","unresolved":false,"context_lines":[{"line_number":833,"context_line":"\t\t\t\tcmd.Stderr \u003d os.Stderr"},{"line_number":834,"context_line":"\t\t\t\tcmd.Run()"},{"line_number":835,"context_line":""},{"line_number":836,"context_line":"\t\t\t\tt.Fatal(\"connectivity test failed\")"},{"line_number":837,"context_line":"\t\t\t}"},{"line_number":838,"context_line":""},{"line_number":839,"context_line":"\t\t\tkubernetes.nft \u003d nil"}],"source_content_type":"text/x-go","patch_set":2,"id":"c5017b38_d416e936","line":836,"range":{"start_line":836,"start_character":6,"end_line":836,"end_character":11},"in_reply_to":"7dd2e047_ecaa7caa","updated":"2025-05-28 15:09:02.000000000","message":"Done","commit_id":"ff6a2bc8fdc22d803b625fb6c407a47febd6d372"},{"author":{"_account_id":1000038,"name":"Jan Schär","display_name":"Jan","email":"jan@monogon.tech","username":"jan","avatars":[{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"e87109648df03d4976541aa1d7774d48f4ca914e","unresolved":true,"context_lines":[{"line_number":906,"context_line":"\t\t\t\tcmd.Stderr \u003d os.Stderr"},{"line_number":907,"context_line":"\t\t\t\tcmd.Run()"},{"line_number":908,"context_line":""},{"line_number":909,"context_line":"\t\t\t\tt.Fatal(\"connectivity test failed\")"},{"line_number":910,"context_line":"\t\t\t}"},{"line_number":911,"context_line":""},{"line_number":912,"context_line":"\t\t\terr \u003d testCaseState.ResetClusterState()"}],"source_content_type":"text/x-go","patch_set":2,"id":"5e2f25bc_77b3b7ef","line":909,"range":{"start_line":909,"start_character":6,"end_line":909,"end_character":11},"updated":"2025-03-27 10:06:53.000000000","message":"Same thing here.","commit_id":"ff6a2bc8fdc22d803b625fb6c407a47febd6d372"},{"author":{"_account_id":1000019,"name":"Tim Windelschmidt","display_name":"Tim","email":"tim@monogon.tech","username":"fionera","avatars":[{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"cdc1be9f76b4a31ff711547d8891447d00c95647","unresolved":false,"context_lines":[{"line_number":906,"context_line":"\t\t\t\tcmd.Stderr \u003d os.Stderr"},{"line_number":907,"context_line":"\t\t\t\tcmd.Run()"},{"line_number":908,"context_line":""},{"line_number":909,"context_line":"\t\t\t\tt.Fatal(\"connectivity test failed\")"},{"line_number":910,"context_line":"\t\t\t}"},{"line_number":911,"context_line":""},{"line_number":912,"context_line":"\t\t\terr \u003d testCaseState.ResetClusterState()"}],"source_content_type":"text/x-go","patch_set":2,"id":"dbf92bae_b1130636","line":909,"range":{"start_line":909,"start_character":6,"end_line":909,"end_character":11},"in_reply_to":"5e2f25bc_77b3b7ef","updated":"2025-05-28 15:09:02.000000000","message":"Done","commit_id":"ff6a2bc8fdc22d803b625fb6c407a47febd6d372"}],"metropolis/node/kubernetes/reconciler/reconciler_status_test.go":[{"author":{"_account_id":1000038,"name":"Jan Schär","display_name":"Jan","email":"jan@monogon.tech","username":"jan","avatars":[{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"e87109648df03d4976541aa1d7774d48f4ca914e","unresolved":true,"context_lines":[{"line_number":120,"context_line":"\tsupervisor.TestHarness(t, func(ctx context.Context) error {"},{"line_number":121,"context_line":"\t\terr :\u003d WaitReady(ctx, cl)"},{"line_number":122,"context_line":"\t\tif err !\u003d nil {"},{"line_number":123,"context_line":"\t\t\tt.Fatal(err)"},{"line_number":124,"context_line":"\t\t}"},{"line_number":125,"context_line":"\t\tclose(isReady)"},{"line_number":126,"context_line":"\t\tsupervisor.Signal(ctx, supervisor.SignalHealthy)"}],"source_content_type":"text/x-go","patch_set":2,"id":"15d3012c_438d5ea4","line":123,"range":{"start_line":123,"start_character":5,"end_line":123,"end_character":10},"updated":"2025-03-27 10:06:53.000000000","message":"You can\u0027t use Fatal here, because this runs in another goroutine. See https://pkg.go.dev/testing#B.FailNow","commit_id":"ff6a2bc8fdc22d803b625fb6c407a47febd6d372"},{"author":{"_account_id":1000019,"name":"Tim Windelschmidt","display_name":"Tim","email":"tim@monogon.tech","username":"fionera","avatars":[{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"cdc1be9f76b4a31ff711547d8891447d00c95647","unresolved":false,"context_lines":[{"line_number":120,"context_line":"\tsupervisor.TestHarness(t, func(ctx context.Context) error {"},{"line_number":121,"context_line":"\t\terr :\u003d WaitReady(ctx, cl)"},{"line_number":122,"context_line":"\t\tif err !\u003d nil {"},{"line_number":123,"context_line":"\t\t\tt.Fatal(err)"},{"line_number":124,"context_line":"\t\t}"},{"line_number":125,"context_line":"\t\tclose(isReady)"},{"line_number":126,"context_line":"\t\tsupervisor.Signal(ctx, supervisor.SignalHealthy)"}],"source_content_type":"text/x-go","patch_set":2,"id":"6fc913e6_12fe7714","line":123,"range":{"start_line":123,"start_character":5,"end_line":123,"end_character":10},"in_reply_to":"15d3012c_438d5ea4","updated":"2025-05-28 15:09:02.000000000","message":"Done","commit_id":"ff6a2bc8fdc22d803b625fb6c407a47febd6d372"},{"author":{"_account_id":1000038,"name":"Jan Schär","display_name":"Jan","email":"jan@monogon.tech","username":"jan","avatars":[{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"e87109648df03d4976541aa1d7774d48f4ca914e","unresolved":true,"context_lines":[{"line_number":265,"context_line":"\t\tsupervisor.TestHarness(t, func(ctx context.Context) error {"},{"line_number":266,"context_line":"\t\t\terr :\u003d WaitReady(ctx, cl)"},{"line_number":267,"context_line":"\t\t\tif err !\u003d nil {"},{"line_number":268,"context_line":"\t\t\t\tt.Fatal(err)"},{"line_number":269,"context_line":"\t\t\t}"},{"line_number":270,"context_line":"\t\t\tclose(isReady)"},{"line_number":271,"context_line":"\t\t\tsupervisor.Signal(ctx, supervisor.SignalHealthy)"}],"source_content_type":"text/x-go","patch_set":2,"id":"aa3bef64_3c304515","line":268,"range":{"start_line":268,"start_character":6,"end_line":268,"end_character":11},"updated":"2025-03-27 10:06:53.000000000","message":"Same here.","commit_id":"ff6a2bc8fdc22d803b625fb6c407a47febd6d372"},{"author":{"_account_id":1000019,"name":"Tim Windelschmidt","display_name":"Tim","email":"tim@monogon.tech","username":"fionera","avatars":[{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"cdc1be9f76b4a31ff711547d8891447d00c95647","unresolved":false,"context_lines":[{"line_number":265,"context_line":"\t\tsupervisor.TestHarness(t, func(ctx context.Context) error {"},{"line_number":266,"context_line":"\t\t\terr :\u003d WaitReady(ctx, cl)"},{"line_number":267,"context_line":"\t\t\tif err !\u003d nil {"},{"line_number":268,"context_line":"\t\t\t\tt.Fatal(err)"},{"line_number":269,"context_line":"\t\t\t}"},{"line_number":270,"context_line":"\t\t\tclose(isReady)"},{"line_number":271,"context_line":"\t\t\tsupervisor.Signal(ctx, supervisor.SignalHealthy)"}],"source_content_type":"text/x-go","patch_set":2,"id":"d873c6a1_1e4c40b0","line":268,"range":{"start_line":268,"start_character":6,"end_line":268,"end_character":11},"in_reply_to":"aa3bef64_3c304515","updated":"2025-05-28 15:09:02.000000000","message":"Done","commit_id":"ff6a2bc8fdc22d803b625fb6c407a47febd6d372"}],"metropolis/test/e2e/connectivity/connectivity.go":[{"author":{"_account_id":1000038,"name":"Jan Schär","display_name":"Jan","email":"jan@monogon.tech","username":"jan","avatars":[{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"e87109648df03d4976541aa1d7774d48f4ca914e","unresolved":true,"context_lines":[{"line_number":113,"context_line":"\t\tif err \u003d\u003d nil {"},{"line_number":114,"context_line":"\t\t\treturn"},{"line_number":115,"context_line":"\t\t} else if deadline.Before(time.Now()) {"},{"line_number":116,"context_line":"\t\t\tt.Fatal(err)"},{"line_number":117,"context_line":"\t\t}"},{"line_number":118,"context_line":"\t\ttime.Sleep(100 * time.Millisecond)"},{"line_number":119,"context_line":"\t}"}],"source_content_type":"text/x-go","patch_set":2,"id":"dc241136_a04f4f87","line":116,"range":{"start_line":116,"start_character":5,"end_line":116,"end_character":10},"updated":"2025-03-27 10:06:53.000000000","message":"I would leave this as Error so that later connectivity checks can also run if one fails.","commit_id":"ff6a2bc8fdc22d803b625fb6c407a47febd6d372"},{"author":{"_account_id":1000019,"name":"Tim Windelschmidt","display_name":"Tim","email":"tim@monogon.tech","username":"fionera","avatars":[{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"cdc1be9f76b4a31ff711547d8891447d00c95647","unresolved":false,"context_lines":[{"line_number":113,"context_line":"\t\tif err \u003d\u003d nil {"},{"line_number":114,"context_line":"\t\t\treturn"},{"line_number":115,"context_line":"\t\t} else if deadline.Before(time.Now()) {"},{"line_number":116,"context_line":"\t\t\tt.Fatal(err)"},{"line_number":117,"context_line":"\t\t}"},{"line_number":118,"context_line":"\t\ttime.Sleep(100 * time.Millisecond)"},{"line_number":119,"context_line":"\t}"}],"source_content_type":"text/x-go","patch_set":2,"id":"359717b9_08366929","line":116,"range":{"start_line":116,"start_character":5,"end_line":116,"end_character":10},"in_reply_to":"dc241136_a04f4f87","updated":"2025-05-28 15:09:02.000000000","message":"Done","commit_id":"ff6a2bc8fdc22d803b625fb6c407a47febd6d372"},{"author":{"_account_id":1000038,"name":"Jan Schär","display_name":"Jan","email":"jan@monogon.tech","username":"jan","avatars":[{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"ed08a9e3163a9b8cf8eeffef268014b9da5c3a3e","unresolved":true,"context_lines":[{"line_number":114,"context_line":"\t\t\treturn"},{"line_number":115,"context_line":"\t\t} else if deadline.Before(time.Now()) {"},{"line_number":116,"context_line":"\t\t\tt.Error(err)"},{"line_number":117,"context_line":"\t\t\treturn"},{"line_number":118,"context_line":"\t\t}"},{"line_number":119,"context_line":"\t\ttime.Sleep(100 * time.Millisecond)"},{"line_number":120,"context_line":"\t}"}],"source_content_type":"text/x-go","patch_set":3,"id":"e49ce2ed_7413366b","side":"PARENT","line":117,"range":{"start_line":117,"start_character":3,"end_line":117,"end_character":9},"updated":"2025-06-02 08:50:16.000000000","message":"This return should be added back.","commit_id":"b554dd389e51718d5acf084cd706d32e16f3994d"},{"author":{"_account_id":1000019,"name":"Tim Windelschmidt","display_name":"Tim","email":"tim@monogon.tech","username":"fionera","avatars":[{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"55885161e49d7ebd39033a9beced6dc0996f44cf","unresolved":false,"context_lines":[{"line_number":114,"context_line":"\t\t\treturn"},{"line_number":115,"context_line":"\t\t} else if deadline.Before(time.Now()) {"},{"line_number":116,"context_line":"\t\t\tt.Error(err)"},{"line_number":117,"context_line":"\t\t\treturn"},{"line_number":118,"context_line":"\t\t}"},{"line_number":119,"context_line":"\t\ttime.Sleep(100 * time.Millisecond)"},{"line_number":120,"context_line":"\t}"}],"source_content_type":"text/x-go","patch_set":3,"id":"e2717369_82d51e04","side":"PARENT","line":117,"range":{"start_line":117,"start_character":3,"end_line":117,"end_character":9},"in_reply_to":"e49ce2ed_7413366b","updated":"2025-06-02 13:11:58.000000000","message":"Done","commit_id":"b554dd389e51718d5acf084cd706d32e16f3994d"}],"osbase/bringup/test/run_test.go":[{"author":{"_account_id":1000038,"name":"Jan Schär","display_name":"Jan","email":"jan@monogon.tech","username":"jan","avatars":[{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"e87109648df03d4976541aa1d7774d48f4ca914e","unresolved":true,"context_lines":[{"line_number":72,"context_line":"\t\tt.Fatal(err)"},{"line_number":73,"context_line":"\t}"},{"line_number":74,"context_line":"\tif !result {"},{"line_number":75,"context_line":"\t\tt.Errorf(\"QEMU didn\u0027t produce the expected output %q\", expectedOutput)"},{"line_number":76,"context_line":"\t}"},{"line_number":77,"context_line":"}"},{"line_number":78,"context_line":"func TestBringupPanic(t *testing.T) {"}],"source_content_type":"text/x-go","patch_set":2,"id":"b1f6c160_248f2967","line":75,"range":{"start_line":75,"start_character":4,"end_line":75,"end_character":10},"updated":"2025-03-27 10:06:53.000000000","message":"The inconsistency bothers me. I would leave all of the result checks as error.","commit_id":"ff6a2bc8fdc22d803b625fb6c407a47febd6d372"},{"author":{"_account_id":1000019,"name":"Tim Windelschmidt","display_name":"Tim","email":"tim@monogon.tech","username":"fionera","avatars":[{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"cdc1be9f76b4a31ff711547d8891447d00c95647","unresolved":false,"context_lines":[{"line_number":72,"context_line":"\t\tt.Fatal(err)"},{"line_number":73,"context_line":"\t}"},{"line_number":74,"context_line":"\tif !result {"},{"line_number":75,"context_line":"\t\tt.Errorf(\"QEMU didn\u0027t produce the expected output %q\", expectedOutput)"},{"line_number":76,"context_line":"\t}"},{"line_number":77,"context_line":"}"},{"line_number":78,"context_line":"func TestBringupPanic(t *testing.T) {"}],"source_content_type":"text/x-go","patch_set":2,"id":"a0d831fa_6f4a5160","line":75,"range":{"start_line":75,"start_character":4,"end_line":75,"end_character":10},"in_reply_to":"b1f6c160_248f2967","updated":"2025-05-28 15:09:02.000000000","message":"Done","commit_id":"ff6a2bc8fdc22d803b625fb6c407a47febd6d372"}],"osbase/erofs/erofs_test.go":[{"author":{"_account_id":1000038,"name":"Jan Schär","display_name":"Jan","email":"jan@monogon.tech","username":"jan","avatars":[{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"e87109648df03d4976541aa1d7774d48f4ca914e","unresolved":true,"context_lines":[{"line_number":257,"context_line":"\t\t\t\tt.Fatal(err)"},{"line_number":258,"context_line":"\t\t\t}"},{"line_number":259,"context_line":"\t\t\tif err :\u003d test.validate(t); err !\u003d nil {"},{"line_number":260,"context_line":"\t\t\t\tt.Fatalf(\"validation failure: %v\", err)"},{"line_number":261,"context_line":"\t\t\t}"},{"line_number":262,"context_line":"\t\t\tif err :\u003d unix.Unmount(\"/test\", 0); err !\u003d nil {"},{"line_number":263,"context_line":"\t\t\t\tt.Fatalf(\"failed to unmount: %v\", err)"}],"source_content_type":"text/x-go","patch_set":2,"id":"be8a781d_c24084ed","line":260,"range":{"start_line":260,"start_character":6,"end_line":260,"end_character":12},"updated":"2025-03-27 10:06:53.000000000","message":"I think this should be left as error, so it will still unmount.","commit_id":"ff6a2bc8fdc22d803b625fb6c407a47febd6d372"},{"author":{"_account_id":1000038,"name":"Jan Schär","display_name":"Jan","email":"jan@monogon.tech","username":"jan","avatars":[{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"ed08a9e3163a9b8cf8eeffef268014b9da5c3a3e","unresolved":false,"context_lines":[{"line_number":257,"context_line":"\t\t\t\tt.Fatal(err)"},{"line_number":258,"context_line":"\t\t\t}"},{"line_number":259,"context_line":"\t\t\tif err :\u003d test.validate(t); err !\u003d nil {"},{"line_number":260,"context_line":"\t\t\t\tt.Fatalf(\"validation failure: %v\", err)"},{"line_number":261,"context_line":"\t\t\t}"},{"line_number":262,"context_line":"\t\t\tif err :\u003d unix.Unmount(\"/test\", 0); err !\u003d nil {"},{"line_number":263,"context_line":"\t\t\t\tt.Fatalf(\"failed to unmount: %v\", err)"}],"source_content_type":"text/x-go","patch_set":2,"id":"c6af4eca_1a364535","line":260,"range":{"start_line":260,"start_character":6,"end_line":260,"end_character":12},"in_reply_to":"09a3ca75_7d67bc2e","updated":"2025-06-02 08:50:16.000000000","message":"Done","commit_id":"ff6a2bc8fdc22d803b625fb6c407a47febd6d372"},{"author":{"_account_id":1000019,"name":"Tim Windelschmidt","display_name":"Tim","email":"tim@monogon.tech","username":"fionera","avatars":[{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"cdc1be9f76b4a31ff711547d8891447d00c95647","unresolved":true,"context_lines":[{"line_number":257,"context_line":"\t\t\t\tt.Fatal(err)"},{"line_number":258,"context_line":"\t\t\t}"},{"line_number":259,"context_line":"\t\t\tif err :\u003d test.validate(t); err !\u003d nil {"},{"line_number":260,"context_line":"\t\t\t\tt.Fatalf(\"validation failure: %v\", err)"},{"line_number":261,"context_line":"\t\t\t}"},{"line_number":262,"context_line":"\t\t\tif err :\u003d unix.Unmount(\"/test\", 0); err !\u003d nil {"},{"line_number":263,"context_line":"\t\t\t\tt.Fatalf(\"failed to unmount: %v\", err)"}],"source_content_type":"text/x-go","patch_set":2,"id":"09a3ca75_7d67bc2e","line":260,"range":{"start_line":260,"start_character":6,"end_line":260,"end_character":12},"in_reply_to":"be8a781d_c24084ed","updated":"2025-05-28 15:09:02.000000000","message":"This should be a t.Cleanup hook but yeah. Will just revert this.","commit_id":"ff6a2bc8fdc22d803b625fb6c407a47febd6d372"}],"osbase/net/dns/forward/forward_test.go":[{"author":{"_account_id":1000038,"name":"Jan Schär","display_name":"Jan","email":"jan@monogon.tech","username":"jan","avatars":[{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"e87109648df03d4976541aa1d7774d48f4ca914e","unresolved":true,"context_lines":[{"line_number":90,"context_line":"\t\tret.Answer \u003d append(ret.Answer, answerRecord1)"},{"line_number":91,"context_line":"\t\terr :\u003d w.WriteMsg(ret)"},{"line_number":92,"context_line":"\t\tif err !\u003d nil {"},{"line_number":93,"context_line":"\t\t\tt.Fatal(err)"},{"line_number":94,"context_line":"\t\t}"},{"line_number":95,"context_line":"\t})"},{"line_number":96,"context_line":"\tdefer s1.Close()"}],"source_content_type":"text/x-go","patch_set":2,"id":"8f52992e_71559e7f","line":93,"range":{"start_line":93,"start_character":5,"end_line":93,"end_character":10},"updated":"2025-03-27 10:06:53.000000000","message":"You can\u0027t use fatal in test.NewServer, because this runs in another goroutine.","commit_id":"ff6a2bc8fdc22d803b625fb6c407a47febd6d372"},{"author":{"_account_id":1000019,"name":"Tim Windelschmidt","display_name":"Tim","email":"tim@monogon.tech","username":"fionera","avatars":[{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"cdc1be9f76b4a31ff711547d8891447d00c95647","unresolved":false,"context_lines":[{"line_number":90,"context_line":"\t\tret.Answer \u003d append(ret.Answer, answerRecord1)"},{"line_number":91,"context_line":"\t\terr :\u003d w.WriteMsg(ret)"},{"line_number":92,"context_line":"\t\tif err !\u003d nil {"},{"line_number":93,"context_line":"\t\t\tt.Fatal(err)"},{"line_number":94,"context_line":"\t\t}"},{"line_number":95,"context_line":"\t})"},{"line_number":96,"context_line":"\tdefer s1.Close()"}],"source_content_type":"text/x-go","patch_set":2,"id":"0e0b1058_6690108f","line":93,"range":{"start_line":93,"start_character":5,"end_line":93,"end_character":10},"in_reply_to":"8f52992e_71559e7f","updated":"2025-05-28 15:09:02.000000000","message":"Done","commit_id":"ff6a2bc8fdc22d803b625fb6c407a47febd6d372"},{"author":{"_account_id":1000038,"name":"Jan Schär","display_name":"Jan","email":"jan@monogon.tech","username":"jan","avatars":[{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"e87109648df03d4976541aa1d7774d48f4ca914e","unresolved":true,"context_lines":[{"line_number":339,"context_line":"\tforward.HandleDNS(req)"},{"line_number":340,"context_line":""},{"line_number":341,"context_line":"\tif slices.Equal(rrStrings(req.Reply.Answer), rrStrings(testAnswer)) {"},{"line_number":342,"context_line":"\t\tt.Fatal(\"Expected second reply to be shuffled.\")"},{"line_number":343,"context_line":"\t}"},{"line_number":344,"context_line":"\tslices.SortFunc(req.Reply.Answer[2:len(testAnswer)-1], func(a, b dns.RR) int {"},{"line_number":345,"context_line":"\t\treturn int(a.(*dns.A).A[3]) - int(b.(*dns.A).A[3])"}],"source_content_type":"text/x-go","patch_set":2,"id":"dd3e1476_a9731b2a","line":342,"range":{"start_line":342,"start_character":4,"end_line":342,"end_character":9},"updated":"2025-03-27 10:06:53.000000000","message":"This does not need to be fatal. I would revert the entire file, none of the changes look like an improvement.","commit_id":"ff6a2bc8fdc22d803b625fb6c407a47febd6d372"},{"author":{"_account_id":1000019,"name":"Tim Windelschmidt","display_name":"Tim","email":"tim@monogon.tech","username":"fionera","avatars":[{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"cdc1be9f76b4a31ff711547d8891447d00c95647","unresolved":false,"context_lines":[{"line_number":339,"context_line":"\tforward.HandleDNS(req)"},{"line_number":340,"context_line":""},{"line_number":341,"context_line":"\tif slices.Equal(rrStrings(req.Reply.Answer), rrStrings(testAnswer)) {"},{"line_number":342,"context_line":"\t\tt.Fatal(\"Expected second reply to be shuffled.\")"},{"line_number":343,"context_line":"\t}"},{"line_number":344,"context_line":"\tslices.SortFunc(req.Reply.Answer[2:len(testAnswer)-1], func(a, b dns.RR) int {"},{"line_number":345,"context_line":"\t\treturn int(a.(*dns.A).A[3]) - int(b.(*dns.A).A[3])"}],"source_content_type":"text/x-go","patch_set":2,"id":"730887cc_f5e4c7aa","line":342,"range":{"start_line":342,"start_character":4,"end_line":342,"end_character":9},"in_reply_to":"dd3e1476_a9731b2a","updated":"2025-05-28 15:09:02.000000000","message":"Done","commit_id":"ff6a2bc8fdc22d803b625fb6c407a47febd6d372"}]}