)]}'
{"cloud/agent/agent.go":[{"author":{"_account_id":1000038,"name":"Jan Schär","display_name":"Jan","email":"jan@monogon.tech","username":"jan","avatars":[{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"2bb05a9888b6ab15aced646fb95fdba984178306","unresolved":true,"context_lines":[{"line_number":101,"context_line":"\t\tRootCAs:      rootCAs,"},{"line_number":102,"context_line":"\t})))"},{"line_number":103,"context_line":"\tif err !\u003d nil {"},{"line_number":104,"context_line":"\t\treturn fmt.Errorf(\"error dialing BMaaS gRPC endpoint: %w\", err)"},{"line_number":105,"context_line":"\t}"},{"line_number":106,"context_line":"\tc :\u003d bpb.NewAgentCallbackClient(conn)"},{"line_number":107,"context_line":""}],"source_content_type":"text/x-go","patch_set":1,"id":"3c7913de_b9af6195","line":104,"range":{"start_line":104,"start_character":27,"end_line":104,"end_character":34},"updated":"2025-02-17 09:37:25.000000000","message":"All the error messages should be updated, e.g. \"error creating client for ...\". grpc.NewClient is not the same as grpc.Dial; it does not do any I/O and defers dialing until the first RPC is made.","commit_id":"60319fb732fbdb12e57740610fd23655b1e34884"},{"author":{"_account_id":1000019,"name":"Tim Windelschmidt","display_name":"Tim","email":"tim@monogon.tech","username":"fionera","avatars":[{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"06145f0196ea3267bd4342f31672ea98458592bb","unresolved":true,"context_lines":[{"line_number":101,"context_line":"\t\tRootCAs:      rootCAs,"},{"line_number":102,"context_line":"\t})))"},{"line_number":103,"context_line":"\tif err !\u003d nil {"},{"line_number":104,"context_line":"\t\treturn fmt.Errorf(\"error dialing BMaaS gRPC endpoint: %w\", err)"},{"line_number":105,"context_line":"\t}"},{"line_number":106,"context_line":"\tc :\u003d bpb.NewAgentCallbackClient(conn)"},{"line_number":107,"context_line":""}],"source_content_type":"text/x-go","patch_set":1,"id":"78f4c2c4_f59f8888","line":104,"range":{"start_line":104,"start_character":27,"end_line":104,"end_character":34},"in_reply_to":"3c7913de_b9af6195","updated":"2025-02-17 20:07:45.000000000","message":"Yeah. And we should probably also rename functions e.g. dialAuthenticated, DialNode etc.","commit_id":"60319fb732fbdb12e57740610fd23655b1e34884"},{"author":{"_account_id":1000019,"name":"Tim Windelschmidt","display_name":"Tim","email":"tim@monogon.tech","username":"fionera","avatars":[{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"be97af47f0279ab9ff63b9df6a226448e640a354","unresolved":false,"context_lines":[{"line_number":101,"context_line":"\t\tRootCAs:      rootCAs,"},{"line_number":102,"context_line":"\t})))"},{"line_number":103,"context_line":"\tif err !\u003d nil {"},{"line_number":104,"context_line":"\t\treturn fmt.Errorf(\"error dialing BMaaS gRPC endpoint: %w\", err)"},{"line_number":105,"context_line":"\t}"},{"line_number":106,"context_line":"\tc :\u003d bpb.NewAgentCallbackClient(conn)"},{"line_number":107,"context_line":""}],"source_content_type":"text/x-go","patch_set":1,"id":"5ee83a3b_8e83cf3a","line":104,"range":{"start_line":104,"start_character":27,"end_line":104,"end_character":34},"in_reply_to":"74fb3631_639dbf0d","updated":"2025-02-25 11:49:58.000000000","message":"Done","commit_id":"60319fb732fbdb12e57740610fd23655b1e34884"},{"author":{"_account_id":1000038,"name":"Jan Schär","display_name":"Jan","email":"jan@monogon.tech","username":"jan","avatars":[{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"3d0ea4becafda07220634f6dda52f0e457167e2c","unresolved":true,"context_lines":[{"line_number":101,"context_line":"\t\tRootCAs:      rootCAs,"},{"line_number":102,"context_line":"\t})))"},{"line_number":103,"context_line":"\tif err !\u003d nil {"},{"line_number":104,"context_line":"\t\treturn fmt.Errorf(\"error dialing BMaaS gRPC endpoint: %w\", err)"},{"line_number":105,"context_line":"\t}"},{"line_number":106,"context_line":"\tc :\u003d bpb.NewAgentCallbackClient(conn)"},{"line_number":107,"context_line":""}],"source_content_type":"text/x-go","patch_set":1,"id":"74fb3631_639dbf0d","line":104,"range":{"start_line":104,"start_character":27,"end_line":104,"end_character":34},"in_reply_to":"78f4c2c4_f59f8888","updated":"2025-02-24 10:18:04.000000000","message":"You updated some of the error messages, but others still need to be updated. Renaming the functions is also a good idea.","commit_id":"60319fb732fbdb12e57740610fd23655b1e34884"}],"cloud/bmaas/server/agent_callback_service_test.go":[{"author":{"_account_id":1000038,"name":"Jan Schär","display_name":"Jan","email":"jan@monogon.tech","username":"jan","avatars":[{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"a51864227688014ccbc1c8a3e4407c86fd488f07","unresolved":true,"context_lines":[{"line_number":67,"context_line":"\t\t}"},{"line_number":68,"context_line":"\t\tconn, err :\u003d grpc.NewClient(s.ListenPublic, grpc.WithTransportCredentials(creds))"},{"line_number":69,"context_line":"\t\tif err !\u003d nil {"},{"line_number":70,"context_line":"\t\t\tt.Fatalf(\"Dial failed: %v\", err)"},{"line_number":71,"context_line":"\t\t}"},{"line_number":72,"context_line":"\t\tdefer conn.Close()"},{"line_number":73,"context_line":""}],"source_content_type":"text/x-go","patch_set":6,"id":"d64ec072_8766e197","line":70,"range":{"start_line":70,"start_character":13,"end_line":70,"end_character":17},"updated":"2025-02-25 16:07:45.000000000","message":"Change to NewClient here and further down in this file.","commit_id":"4fe3dcac4a2f1a5e1b712c70444adcd2272eb16c"},{"author":{"_account_id":1000019,"name":"Tim Windelschmidt","display_name":"Tim","email":"tim@monogon.tech","username":"fionera","avatars":[{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"cf25acd2924e5912730765b5caca93f69b298af7","unresolved":false,"context_lines":[{"line_number":67,"context_line":"\t\t}"},{"line_number":68,"context_line":"\t\tconn, err :\u003d grpc.NewClient(s.ListenPublic, grpc.WithTransportCredentials(creds))"},{"line_number":69,"context_line":"\t\tif err !\u003d nil {"},{"line_number":70,"context_line":"\t\t\tt.Fatalf(\"Dial failed: %v\", err)"},{"line_number":71,"context_line":"\t\t}"},{"line_number":72,"context_line":"\t\tdefer conn.Close()"},{"line_number":73,"context_line":""}],"source_content_type":"text/x-go","patch_set":6,"id":"faeec0bb_16d585e1","line":70,"range":{"start_line":70,"start_character":13,"end_line":70,"end_character":17},"in_reply_to":"d64ec072_8766e197","updated":"2025-02-26 12:38:40.000000000","message":"Done","commit_id":"4fe3dcac4a2f1a5e1b712c70444adcd2272eb16c"}],"metropolis/cli/dbg/main.go":[{"author":{"_account_id":1000038,"name":"Jan Schär","display_name":"Jan","email":"jan@monogon.tech","username":"jan","avatars":[{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"a51864227688014ccbc1c8a3e4407c86fd488f07","unresolved":true,"context_lines":[{"line_number":31,"context_line":"\t// production node because of missing encryption \u0026 authentication"},{"line_number":32,"context_line":"\tgrpcClient, err :\u003d grpc.NewClient(\"localhost:7837\", grpc.WithTransportCredentials(insecure.NewCredentials()))"},{"line_number":33,"context_line":"\tif err !\u003d nil {"},{"line_number":34,"context_line":"\t\tfmt.Printf(\"Failed to dial debug service (is it running): %v\\n\", err)"},{"line_number":35,"context_line":"\t}"},{"line_number":36,"context_line":"\tdebugClient :\u003d apb.NewNodeDebugServiceClient(grpcClient)"},{"line_number":37,"context_line":"\tif len(os.Args) \u003c 2 {"}],"source_content_type":"text/x-go","patch_set":6,"id":"316acc3d_a0d084b3","line":34,"range":{"start_line":34,"start_character":24,"end_line":34,"end_character":28},"updated":"2025-02-25 16:07:45.000000000","message":"Update the message.","commit_id":"4fe3dcac4a2f1a5e1b712c70444adcd2272eb16c"},{"author":{"_account_id":1000019,"name":"Tim Windelschmidt","display_name":"Tim","email":"tim@monogon.tech","username":"fionera","avatars":[{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"cf25acd2924e5912730765b5caca93f69b298af7","unresolved":false,"context_lines":[{"line_number":31,"context_line":"\t// production node because of missing encryption \u0026 authentication"},{"line_number":32,"context_line":"\tgrpcClient, err :\u003d grpc.NewClient(\"localhost:7837\", grpc.WithTransportCredentials(insecure.NewCredentials()))"},{"line_number":33,"context_line":"\tif err !\u003d nil {"},{"line_number":34,"context_line":"\t\tfmt.Printf(\"Failed to dial debug service (is it running): %v\\n\", err)"},{"line_number":35,"context_line":"\t}"},{"line_number":36,"context_line":"\tdebugClient :\u003d apb.NewNodeDebugServiceClient(grpcClient)"},{"line_number":37,"context_line":"\tif len(os.Args) \u003c 2 {"}],"source_content_type":"text/x-go","patch_set":6,"id":"143912b1_eea07746","line":34,"range":{"start_line":34,"start_character":24,"end_line":34,"end_character":28},"in_reply_to":"316acc3d_a0d084b3","updated":"2025-02-26 12:38:40.000000000","message":"Done","commit_id":"4fe3dcac4a2f1a5e1b712c70444adcd2272eb16c"}],"metropolis/node/core/rpc/server_authentication_test.go":[{"author":{"_account_id":1000038,"name":"Jan Schär","display_name":"Jan","email":"jan@monogon.tech","username":"jan","avatars":[{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"f1c7cd83fe575959e2bdff81d25ccc979a49fa43","unresolved":true,"context_lines":[{"line_number":66,"context_line":"\t})"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"\t// Authenticate as manager externally, ensure that GetRegisterTicket runs."},{"line_number":69,"context_line":"\tcl, err :\u003d grpc.NewClient(\"passthrough://local\","},{"line_number":70,"context_line":"\t\tgrpc.WithTransportCredentials(NewAuthenticatedCredentials(eph.Manager, WantRemoteCluster(eph.CA))),"},{"line_number":71,"context_line":"\t\twithLocalDialer)"},{"line_number":72,"context_line":"\tif err !\u003d nil {"}],"source_content_type":"text/x-go","patch_set":2,"id":"0c134828_eae96bc0","line":69,"range":{"start_line":69,"start_character":40,"end_line":69,"end_character":42},"updated":"2025-02-18 08:52:15.000000000","message":"It should be three slashes, otherwise the dialer gets an empty string. It doesn\u0027t really matter here because the dialer ignores the address, but it\u0027s confusing.","commit_id":"a12849517f26574f364b280935acf3b49168c791"},{"author":{"_account_id":1000019,"name":"Tim Windelschmidt","display_name":"Tim","email":"tim@monogon.tech","username":"fionera","avatars":[{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"f740f6094dcc4dba81fb1efd91503f630f0fa7da","unresolved":false,"context_lines":[{"line_number":66,"context_line":"\t})"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"\t// Authenticate as manager externally, ensure that GetRegisterTicket runs."},{"line_number":69,"context_line":"\tcl, err :\u003d grpc.NewClient(\"passthrough://local\","},{"line_number":70,"context_line":"\t\tgrpc.WithTransportCredentials(NewAuthenticatedCredentials(eph.Manager, WantRemoteCluster(eph.CA))),"},{"line_number":71,"context_line":"\t\twithLocalDialer)"},{"line_number":72,"context_line":"\tif err !\u003d nil {"}],"source_content_type":"text/x-go","patch_set":2,"id":"94b18df8_0bdc20ab","line":69,"range":{"start_line":69,"start_character":40,"end_line":69,"end_character":42},"in_reply_to":"0c134828_eae96bc0","updated":"2025-02-21 03:34:05.000000000","message":"Done","commit_id":"a12849517f26574f364b280935acf3b49168c791"}],"metropolis/test/launch/cluster.go":[{"author":{"_account_id":1000038,"name":"Jan Schär","display_name":"Jan","email":"jan@monogon.tech","username":"jan","avatars":[{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"2bb05a9888b6ab15aced646fb95fdba984178306","unresolved":true,"context_lines":[{"line_number":1258,"context_line":"//"},{"line_number":1259,"context_line":"// For example:"},{"line_number":1260,"context_line":"//"},{"line_number":1261,"context_line":"//\tgrpc.NewClient(\"metropolis-deadbeef:1234\", grpc.WithContextDialer(c.DialNode))"},{"line_number":1262,"context_line":"func (c *Cluster) DialNode(_ context.Context, addr string) (net.Conn, error) {"},{"line_number":1263,"context_line":"\thost, port, err :\u003d net.SplitHostPort(addr)"},{"line_number":1264,"context_line":"\tif err !\u003d nil {"}],"source_content_type":"text/x-go","patch_set":1,"id":"7de89f1e_02a8b9f4","line":1261,"range":{"start_line":1261,"start_character":19,"end_line":1261,"end_character":38},"updated":"2025-02-17 09:37:25.000000000","message":"This is probably the reason for your test failure. I think this should be changed to \"passthrough:///metropolis-deadbeef:1234\" here and everywhere it\u0027s used (but I have not tested this).\n\nSee https://github.com/grpc/grpc-go/blob/v1.70.0/clientconn.go#L218-L222","commit_id":"60319fb732fbdb12e57740610fd23655b1e34884"},{"author":{"_account_id":1000019,"name":"Tim Windelschmidt","display_name":"Tim","email":"tim@monogon.tech","username":"fionera","avatars":[{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"06145f0196ea3267bd4342f31672ea98458592bb","unresolved":false,"context_lines":[{"line_number":1258,"context_line":"//"},{"line_number":1259,"context_line":"// For example:"},{"line_number":1260,"context_line":"//"},{"line_number":1261,"context_line":"//\tgrpc.NewClient(\"metropolis-deadbeef:1234\", grpc.WithContextDialer(c.DialNode))"},{"line_number":1262,"context_line":"func (c *Cluster) DialNode(_ context.Context, addr string) (net.Conn, error) {"},{"line_number":1263,"context_line":"\thost, port, err :\u003d net.SplitHostPort(addr)"},{"line_number":1264,"context_line":"\tif err !\u003d nil {"}],"source_content_type":"text/x-go","patch_set":1,"id":"20edff46_35de7cee","line":1261,"range":{"start_line":1261,"start_character":19,"end_line":1261,"end_character":38},"in_reply_to":"7de89f1e_02a8b9f4","updated":"2025-02-17 20:07:45.000000000","message":"No we are also using it for other connections.","commit_id":"60319fb732fbdb12e57740610fd23655b1e34884"},{"author":{"_account_id":1000038,"name":"Jan Schär","display_name":"Jan","email":"jan@monogon.tech","username":"jan","avatars":[{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"3d0ea4becafda07220634f6dda52f0e457167e2c","unresolved":true,"context_lines":[{"line_number":1254,"context_line":"//"},{"line_number":1255,"context_line":"// For example:"},{"line_number":1256,"context_line":"//"},{"line_number":1257,"context_line":"//\tgrpc.NewClient(\"passthrough:////metropolis-deadbeef:1234\", grpc.WithContextDialer(c.DialNode))"},{"line_number":1258,"context_line":"func (c *Cluster) DialNode(_ context.Context, addr string) (net.Conn, error) {"},{"line_number":1259,"context_line":"\thost, port, err :\u003d net.SplitHostPort(addr)"},{"line_number":1260,"context_line":"\tif err !\u003d nil {"}],"source_content_type":"text/x-go","patch_set":3,"id":"084a8d87_bd5ea41e","line":1257,"range":{"start_line":1257,"start_character":31,"end_line":1257,"end_character":35},"updated":"2025-02-24 10:18:04.000000000","message":"That\u0027s too many slashes","commit_id":"614cc7a0404955c6414f028bfacb479d47ac2eae"},{"author":{"_account_id":1000019,"name":"Tim Windelschmidt","display_name":"Tim","email":"tim@monogon.tech","username":"fionera","avatars":[{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"acc7e4aaffc3add116d37373190421b5e8617016","unresolved":false,"context_lines":[{"line_number":1254,"context_line":"//"},{"line_number":1255,"context_line":"// For example:"},{"line_number":1256,"context_line":"//"},{"line_number":1257,"context_line":"//\tgrpc.NewClient(\"passthrough:////metropolis-deadbeef:1234\", grpc.WithContextDialer(c.DialNode))"},{"line_number":1258,"context_line":"func (c *Cluster) DialNode(_ context.Context, addr string) (net.Conn, error) {"},{"line_number":1259,"context_line":"\thost, port, err :\u003d net.SplitHostPort(addr)"},{"line_number":1260,"context_line":"\tif err !\u003d nil {"}],"source_content_type":"text/x-go","patch_set":3,"id":"c5179ed8_f2563057","line":1257,"range":{"start_line":1257,"start_character":31,"end_line":1257,"end_character":35},"in_reply_to":"084a8d87_bd5ea41e","updated":"2025-02-25 11:49:37.000000000","message":"Done","commit_id":"614cc7a0404955c6414f028bfacb479d47ac2eae"},{"author":{"_account_id":1000038,"name":"Jan Schär","display_name":"Jan","email":"jan@monogon.tech","username":"jan","avatars":[{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"a51864227688014ccbc1c8a3e4407c86fd488f07","unresolved":true,"context_lines":[{"line_number":1255,"context_line":"//"},{"line_number":1256,"context_line":"// For example:"},{"line_number":1257,"context_line":"//"},{"line_number":1258,"context_line":"//\tgrpc.NewClient(\"passthrough:///metropolis-deadbeef:1234\", grpc.WithContextDialer(c.NewNodeClient))"},{"line_number":1259,"context_line":"func (c *Cluster) DialNode(_ context.Context, addr string) (net.Conn, error) {"},{"line_number":1260,"context_line":"\thost, port, err :\u003d net.SplitHostPort(addr)"},{"line_number":1261,"context_line":"\tif err !\u003d nil {"}],"source_content_type":"text/x-go","patch_set":6,"id":"434f03eb_86a33f99","line":1258,"range":{"start_line":1258,"start_character":86,"end_line":1258,"end_character":99},"updated":"2025-02-25 16:07:45.000000000","message":"Change this back to DialNode.","commit_id":"4fe3dcac4a2f1a5e1b712c70444adcd2272eb16c"},{"author":{"_account_id":1000019,"name":"Tim Windelschmidt","display_name":"Tim","email":"tim@monogon.tech","username":"fionera","avatars":[{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"cf25acd2924e5912730765b5caca93f69b298af7","unresolved":false,"context_lines":[{"line_number":1255,"context_line":"//"},{"line_number":1256,"context_line":"// For example:"},{"line_number":1257,"context_line":"//"},{"line_number":1258,"context_line":"//\tgrpc.NewClient(\"passthrough:///metropolis-deadbeef:1234\", grpc.WithContextDialer(c.NewNodeClient))"},{"line_number":1259,"context_line":"func (c *Cluster) DialNode(_ context.Context, addr string) (net.Conn, error) {"},{"line_number":1260,"context_line":"\thost, port, err :\u003d net.SplitHostPort(addr)"},{"line_number":1261,"context_line":"\tif err !\u003d nil {"}],"source_content_type":"text/x-go","patch_set":6,"id":"23ec43c7_e1883c58","line":1258,"range":{"start_line":1258,"start_character":86,"end_line":1258,"end_character":99},"in_reply_to":"434f03eb_86a33f99","updated":"2025-02-26 12:38:40.000000000","message":"Done","commit_id":"4fe3dcac4a2f1a5e1b712c70444adcd2272eb16c"}]}