)]}'
{"build/analysis/BUILD.bazel":[{"author":{"_account_id":1000019,"name":"Tim Windelschmidt","display_name":"Tim","email":"tim@monogon.tech","username":"fionera","avatars":[{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"9b2e7dd4321427ba096a4c99bf167f5e6ae20b6e","unresolved":true,"context_lines":[{"line_number":195,"context_line":"            \"bazel-out/\": \"generated_output\","},{"line_number":196,"context_line":"            \"cgo/\": \"cgo\","},{"line_number":197,"context_line":"        },"},{"line_number":198,"context_line":"    },"},{"line_number":199,"context_line":"    \"haslicense\": {"},{"line_number":200,"context_line":"        \"exclude_files\": {"},{"line_number":201,"context_line":"            \"metropolis/node/kubernetes/metricsprovider\": \"Multi-Party copyright statement (#376)\","}],"source_content_type":"text/x-python","patch_set":8,"id":"1ae4343c_624ccf5f","line":198,"updated":"2025-02-10 20:59:37.000000000","message":"Shouldnt this be in a separate commit?","commit_id":"cd1b7798f2c674891de917522d84ef274b190892"},{"author":{"_account_id":1000019,"name":"Tim Windelschmidt","display_name":"Tim","email":"tim@monogon.tech","username":"fionera","avatars":[{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"f80c162b35110b4908ff29bdf6aa0b1069031bf6","unresolved":false,"context_lines":[{"line_number":195,"context_line":"            \"bazel-out/\": \"generated_output\","},{"line_number":196,"context_line":"            \"cgo/\": \"cgo\","},{"line_number":197,"context_line":"        },"},{"line_number":198,"context_line":"    },"},{"line_number":199,"context_line":"    \"haslicense\": {"},{"line_number":200,"context_line":"        \"exclude_files\": {"},{"line_number":201,"context_line":"            \"metropolis/node/kubernetes/metricsprovider\": \"Multi-Party copyright statement (#376)\","}],"source_content_type":"text/x-python","patch_set":8,"id":"7454bac0_0802c8a1","line":198,"in_reply_to":"17dfa103_27e1bd5e","updated":"2025-02-11 13:20:42.000000000","message":"Acknowledged","commit_id":"cd1b7798f2c674891de917522d84ef274b190892"},{"author":{"_account_id":1000001,"name":"Lorenz Brun","display_name":"Lorenz","email":"lorenz@monogon.tech","username":"lorenz","avatars":[{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"0fa08326baa16773d195bd07204b3354c4162b66","unresolved":true,"context_lines":[{"line_number":195,"context_line":"            \"bazel-out/\": \"generated_output\","},{"line_number":196,"context_line":"            \"cgo/\": \"cgo\","},{"line_number":197,"context_line":"        },"},{"line_number":198,"context_line":"    },"},{"line_number":199,"context_line":"    \"haslicense\": {"},{"line_number":200,"context_line":"        \"exclude_files\": {"},{"line_number":201,"context_line":"            \"metropolis/node/kubernetes/metricsprovider\": \"Multi-Party copyright statement (#376)\","}],"source_content_type":"text/x-python","patch_set":8,"id":"17dfa103_27e1bd5e","line":198,"in_reply_to":"1ae4343c_624ccf5f","updated":"2025-02-11 12:08:05.000000000","message":"The package it excludes is introduced in this CL. So that can\u0027t be split out. I could first refactor the build file to do better merging which would make this smaller but it\u0027s like 6 lines of diff.","commit_id":"cd1b7798f2c674891de917522d84ef274b190892"}],"metropolis/node/kubernetes/metricsprovider/metricsprovider.go":[{"author":{"_account_id":1000019,"name":"Tim Windelschmidt","display_name":"Tim","email":"tim@monogon.tech","username":"fionera","avatars":[{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"abaa235fb93f4aeacea3dbe6b6500c0e6c7478c2","unresolved":true,"context_lines":[{"line_number":76,"context_line":")"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"func init() {"},{"line_number":79,"context_line":"\tmetrics.CoreRegistry.MustRegister(depth, adds, latency, workDuration, unfinished, longestRunningProcessor, retries)"},{"line_number":80,"context_line":"\tworkqueue.SetProvider(\u0026promProvider{})"},{"line_number":81,"context_line":"}"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-go","patch_set":3,"id":"dad5fb03_1b852238","line":79,"updated":"2025-02-06 14:18:51.000000000","message":"This will result in the metrics being registered and served even when k8s is not enabled. We should not register them inside the init function but in the k8s service startup","commit_id":"c2ffddee68e063d2b859ac536a60d994ffca27f6"},{"author":{"_account_id":1000001,"name":"Lorenz Brun","display_name":"Lorenz","email":"lorenz@monogon.tech","username":"lorenz","avatars":[{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"648c03b1e6e378fa56c4e175cc0607e026ae17b4","unresolved":false,"context_lines":[{"line_number":76,"context_line":")"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"func init() {"},{"line_number":79,"context_line":"\tmetrics.CoreRegistry.MustRegister(depth, adds, latency, workDuration, unfinished, longestRunningProcessor, retries)"},{"line_number":80,"context_line":"\tworkqueue.SetProvider(\u0026promProvider{})"},{"line_number":81,"context_line":"}"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-go","patch_set":3,"id":"005d8f4c_ece6bb68","line":79,"in_reply_to":"ac66b38a_b3d25dc0","updated":"2025-02-10 17:13:20.000000000","message":"Done","commit_id":"c2ffddee68e063d2b859ac536a60d994ffca27f6"},{"author":{"_account_id":1000019,"name":"Tim Windelschmidt","display_name":"Tim","email":"tim@monogon.tech","username":"fionera","avatars":[{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"13e2dae50f1c3ca877dc41ffc0efbc9cd361c428","unresolved":true,"context_lines":[{"line_number":76,"context_line":")"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"func init() {"},{"line_number":79,"context_line":"\tmetrics.CoreRegistry.MustRegister(depth, adds, latency, workDuration, unfinished, longestRunningProcessor, retries)"},{"line_number":80,"context_line":"\tworkqueue.SetProvider(\u0026promProvider{})"},{"line_number":81,"context_line":"}"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-go","patch_set":3,"id":"ac66b38a_b3d25dc0","line":79,"in_reply_to":"af915609_ab46f3e8","updated":"2025-02-10 16:13:17.000000000","message":"You could have a registry in this package and then register/unregister that one at startup","commit_id":"c2ffddee68e063d2b859ac536a60d994ffca27f6"},{"author":{"_account_id":1000001,"name":"Lorenz Brun","display_name":"Lorenz","email":"lorenz@monogon.tech","username":"lorenz","avatars":[{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"ca099062d73373d7bad14d6fea780f3b1e1053ec","unresolved":true,"context_lines":[{"line_number":76,"context_line":")"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"func init() {"},{"line_number":79,"context_line":"\tmetrics.CoreRegistry.MustRegister(depth, adds, latency, workDuration, unfinished, longestRunningProcessor, retries)"},{"line_number":80,"context_line":"\tworkqueue.SetProvider(\u0026promProvider{})"},{"line_number":81,"context_line":"}"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-go","patch_set":3,"id":"af915609_ab46f3e8","line":79,"in_reply_to":"dad5fb03_1b852238","updated":"2025-02-06 17:12:53.000000000","message":"This will generate a race condition, we cannot do this with the way K8s does this.","commit_id":"c2ffddee68e063d2b859ac536a60d994ffca27f6"}]}