)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000019,"name":"Tim Windelschmidt","display_name":"Tim","email":"tim@monogon.tech","username":"fionera","avatars":[{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"f2451709d387551769e140240f5d8eea63c3fb4e","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e443ba75_50c9f398","updated":"2025-01-11 03:20:51.000000000","message":"This may be updated to skip all this override nonsense as I am currently talking to the rules_rust maintainers to merge our patches","commit_id":"464b73002c9d02a0201b8e71c9ab66450a6f23f4"},{"author":{"_account_id":1000019,"name":"Tim Windelschmidt","display_name":"Tim","email":"tim@monogon.tech","username":"fionera","avatars":[{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"c816f1d6444badebd3a1a4961d7f2f282006f131","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9cf4e833_d876036a","in_reply_to":"614ff491_a635fd94","updated":"2025-01-27 15:30:26.000000000","message":"Nah they take forever to respond to the simplest things","commit_id":"464b73002c9d02a0201b8e71c9ab66450a6f23f4"},{"author":{"_account_id":1000019,"name":"Tim Windelschmidt","display_name":"Tim","email":"tim@monogon.tech","username":"fionera","avatars":[{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"46c86c33695552393c06cfe7a0785fb51d243233","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"614ff491_a635fd94","in_reply_to":"e443ba75_50c9f398","updated":"2025-01-20 16:06:53.000000000","message":"Since rules_rust upstream is fairly slow regarding PRs, I would propose to merge this for now.","commit_id":"464b73002c9d02a0201b8e71c9ab66450a6f23f4"}],"MODULE.bazel":[{"author":{"_account_id":1000000,"name":"Leopold Schabel","display_name":"Leo","email":"leo@monogon.tech","username":"leo","avatars":[{"url":"https://www.gravatar.com/avatar/98f8f79a6bb45adef37defa7ead8f3d2.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/98f8f79a6bb45adef37defa7ead8f3d2.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/98f8f79a6bb45adef37defa7ead8f3d2.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/98f8f79a6bb45adef37defa7ead8f3d2.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"47769bf811223d55fc792681c526623cac0ca6ca","unresolved":true,"context_lines":[{"line_number":38,"context_line":"    version \u003d \"0.41.0\","},{"line_number":39,"context_line":")"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"# Rules rust was split into multiple dependencies, sadly this means we have to"},{"line_number":42,"context_line":"# patch each include separately. This overrides them with a fork which has our"},{"line_number":43,"context_line":"# patches applied."},{"line_number":44,"context_line":"RULES_RUST_COMMIT \u003d \"03a09d8e25cbc32b8ad4522e23e104e6a29ba1d0\""}],"source_content_type":"text/x-python","patch_set":3,"id":"7413acff_c6384e90","line":41,"range":{"start_line":41,"start_character":2,"end_line":41,"end_character":12},"updated":"2025-01-22 22:56:20.000000000","message":"```suggestion\n# rules_rust was split into multiple dependencies. Sadly, this means we have to\n```\n\ntypo nit","commit_id":"9db5b527e6b514156a69ccb1a9c812b911d3de1a"},{"author":{"_account_id":1000019,"name":"Tim Windelschmidt","display_name":"Tim","email":"tim@monogon.tech","username":"fionera","avatars":[{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"c816f1d6444badebd3a1a4961d7f2f282006f131","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    version \u003d \"0.41.0\","},{"line_number":39,"context_line":")"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"# Rules rust was split into multiple dependencies, sadly this means we have to"},{"line_number":42,"context_line":"# patch each include separately. This overrides them with a fork which has our"},{"line_number":43,"context_line":"# patches applied."},{"line_number":44,"context_line":"RULES_RUST_COMMIT \u003d \"03a09d8e25cbc32b8ad4522e23e104e6a29ba1d0\""}],"source_content_type":"text/x-python","patch_set":3,"id":"150521d2_84ae6468","line":41,"range":{"start_line":41,"start_character":2,"end_line":41,"end_character":12},"in_reply_to":"7413acff_c6384e90","updated":"2025-01-27 15:30:26.000000000","message":"Done","commit_id":"9db5b527e6b514156a69ccb1a9c812b911d3de1a"},{"author":{"_account_id":1000000,"name":"Leopold Schabel","display_name":"Leo","email":"leo@monogon.tech","username":"leo","avatars":[{"url":"https://www.gravatar.com/avatar/98f8f79a6bb45adef37defa7ead8f3d2.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/98f8f79a6bb45adef37defa7ead8f3d2.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/98f8f79a6bb45adef37defa7ead8f3d2.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/98f8f79a6bb45adef37defa7ead8f3d2.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"261775737f3b859de9891cfa7380d4d5c18db6b1","unresolved":true,"context_lines":[{"line_number":38,"context_line":"    version \u003d \"0.41.0\","},{"line_number":39,"context_line":")"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"# Rules rust was split into multiple dependencies, sadly this means we have to"},{"line_number":42,"context_line":"# patch each include separately. This overrides them with a fork which has our"},{"line_number":43,"context_line":"# patches applied."},{"line_number":44,"context_line":"RULES_RUST_COMMIT \u003d \"03a09d8e25cbc32b8ad4522e23e104e6a29ba1d0\""},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"a8ff98c8_763c81e3","line":42,"range":{"start_line":41,"start_character":51,"end_line":42,"end_character":31},"updated":"2025-01-22 13:04:27.000000000","message":"What is the problem with applying the patches separately vs. maintaining a fork?","commit_id":"9db5b527e6b514156a69ccb1a9c812b911d3de1a"},{"author":{"_account_id":1000000,"name":"Leopold Schabel","display_name":"Leo","email":"leo@monogon.tech","username":"leo","avatars":[{"url":"https://www.gravatar.com/avatar/98f8f79a6bb45adef37defa7ead8f3d2.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/98f8f79a6bb45adef37defa7ead8f3d2.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/98f8f79a6bb45adef37defa7ead8f3d2.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/98f8f79a6bb45adef37defa7ead8f3d2.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"47769bf811223d55fc792681c526623cac0ca6ca","unresolved":true,"context_lines":[{"line_number":38,"context_line":"    version \u003d \"0.41.0\","},{"line_number":39,"context_line":")"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"# Rules rust was split into multiple dependencies, sadly this means we have to"},{"line_number":42,"context_line":"# patch each include separately. This overrides them with a fork which has our"},{"line_number":43,"context_line":"# patches applied."},{"line_number":44,"context_line":"RULES_RUST_COMMIT \u003d \"03a09d8e25cbc32b8ad4522e23e104e6a29ba1d0\""},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"415024a7_40686344","line":42,"range":{"start_line":41,"start_character":51,"end_line":42,"end_character":31},"in_reply_to":"2b92a9d1_43962acd","updated":"2025-01-22 22:56:20.000000000","message":"I see. Wouldn\u0027t `patch_strip` let us apply patches to each?\n\n```\nsingle_version_override(\n    module_name \u003d \"rules_rust\",\n    patch_strip \u003d 1,\n    patches \u003d [\n        \"//third_party/rules_rust:rust-uefi-platform.patch\",\n        \"//third_party/rules_rust:rust-prost-nostd.patch\",\n        \"//third_party/rules_rust:rust-reproducibility.patch\",\n        \"//third_party/rules_rust:Add-extra_rustc_flags-to-module-extension.patch\",\n    ],\n    ...\n)\n\nsingle_version_override(\n    module_name \u003d \"rules_rust_prost\",\n    patch_strip \u003d 3,\n    patches \u003d [\n        \"//third_party/rules_rust:rust-prost-nostd.patch\",\n        \"//third_party/rules_rust:rust-prost-reproducibility.patch\",\n    ],\n    ...\n)\n\nsingle_version_override(\n    module_name \u003d \"rules_rust_protobuf\",\n    patch_strip \u003d 3,\n    ...\n)\n```\n\nMight be cleaner since it\u0027s much easier to review patch diffs vs. a reference to a fork.","commit_id":"9db5b527e6b514156a69ccb1a9c812b911d3de1a"},{"author":{"_account_id":1000019,"name":"Tim Windelschmidt","display_name":"Tim","email":"tim@monogon.tech","username":"fionera","avatars":[{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"c816f1d6444badebd3a1a4961d7f2f282006f131","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    version \u003d \"0.41.0\","},{"line_number":39,"context_line":")"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"# Rules rust was split into multiple dependencies, sadly this means we have to"},{"line_number":42,"context_line":"# patch each include separately. This overrides them with a fork which has our"},{"line_number":43,"context_line":"# patches applied."},{"line_number":44,"context_line":"RULES_RUST_COMMIT \u003d \"03a09d8e25cbc32b8ad4522e23e104e6a29ba1d0\""},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"941337e7_61367188","line":42,"range":{"start_line":41,"start_character":51,"end_line":42,"end_character":31},"in_reply_to":"415024a7_40686344","updated":"2025-01-27 15:30:26.000000000","message":"Done","commit_id":"9db5b527e6b514156a69ccb1a9c812b911d3de1a"},{"author":{"_account_id":1000019,"name":"Tim Windelschmidt","display_name":"Tim","email":"tim@monogon.tech","username":"fionera","avatars":[{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"42ebd210c6d147427cf3252bec3080192314d327","unresolved":true,"context_lines":[{"line_number":38,"context_line":"    version \u003d \"0.41.0\","},{"line_number":39,"context_line":")"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"# Rules rust was split into multiple dependencies, sadly this means we have to"},{"line_number":42,"context_line":"# patch each include separately. This overrides them with a fork which has our"},{"line_number":43,"context_line":"# patches applied."},{"line_number":44,"context_line":"RULES_RUST_COMMIT \u003d \"03a09d8e25cbc32b8ad4522e23e104e6a29ba1d0\""},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"2b92a9d1_43962acd","line":42,"range":{"start_line":41,"start_character":51,"end_line":42,"end_character":31},"in_reply_to":"a8ff98c8_763c81e3","updated":"2025-01-22 19:13:02.000000000","message":"We need to have the patches multiple times as they are applied to different repository roots. With a fork its way simpler as we just have to override the repo with the correct strip_prefix","commit_id":"9db5b527e6b514156a69ccb1a9c812b911d3de1a"}]}