)]}'
{"osbase/efivarfs/osindications.go":[{"author":{"_account_id":1000038,"name":"Jan Schär","display_name":"Jan","email":"jan@monogon.tech","username":"jan","avatars":[{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"aee3cd08eb29413fef39b320b2e4529d635ba57b","unresolved":true,"context_lines":[{"line_number":32,"context_line":"\t// Indicates that firmware should skip Boot# processing on next boot"},{"line_number":33,"context_line":"\t// and instead use PlatformRecovery# for selecting a load option."},{"line_number":34,"context_line":"\tStartPlatformRecovery"},{"line_number":35,"context_line":")"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"// OSIndicationsSupported indicates which of the OS indication features and"},{"line_number":38,"context_line":"// actions that the firmware supports."}],"source_content_type":"text/x-go","patch_set":1,"id":"faa0891d_c86157fb","line":35,"updated":"2024-09-09 16:44:58.000000000","message":"There is an eight bit for `JSON_CONFIG_DATA_REFRESH` in the UEFI spec which is missing here.","commit_id":"00602f9998c256a249f154492181a64302d62393"},{"author":{"_account_id":1000001,"name":"Lorenz Brun","display_name":"Lorenz","email":"lorenz@monogon.tech","username":"lorenz","avatars":[{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"da0407911657fa71d432f6d8bd9e6f0e81da195a","unresolved":false,"context_lines":[{"line_number":32,"context_line":"\t// Indicates that firmware should skip Boot# processing on next boot"},{"line_number":33,"context_line":"\t// and instead use PlatformRecovery# for selecting a load option."},{"line_number":34,"context_line":"\tStartPlatformRecovery"},{"line_number":35,"context_line":")"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"// OSIndicationsSupported indicates which of the OS indication features and"},{"line_number":38,"context_line":"// actions that the firmware supports."}],"source_content_type":"text/x-go","patch_set":1,"id":"80e1fa67_31b5899a","line":35,"in_reply_to":"faa0891d_c86157fb","updated":"2024-09-09 20:36:18.000000000","message":"Done","commit_id":"00602f9998c256a249f154492181a64302d62393"},{"author":{"_account_id":1000038,"name":"Jan Schär","display_name":"Jan","email":"jan@monogon.tech","username":"jan","avatars":[{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"aee3cd08eb29413fef39b320b2e4529d635ba57b","unresolved":true,"context_lines":[{"line_number":63,"context_line":"\t})"},{"line_number":64,"context_line":"}"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"func modifyOSIndications(f func(prev OSIndications) OSIndications) error {"},{"line_number":67,"context_line":"\tosIndicationsRaw, _, err :\u003d Read(ScopeGlobal, \"OsIndications\")"},{"line_number":68,"context_line":"\tif err !\u003d nil {"},{"line_number":69,"context_line":"\t\treturn fmt.Errorf(\"unable to read OsIndications variable: %w\", err)"}],"source_content_type":"text/x-go","patch_set":1,"id":"369ddb42_92fb3b24","line":66,"updated":"2024-09-09 16:44:58.000000000","message":"Would it make sense to add a global Mutex for OsIndications which is taken by this function? Concurrent updates could otherwise get lost.","commit_id":"00602f9998c256a249f154492181a64302d62393"},{"author":{"_account_id":1000001,"name":"Lorenz Brun","display_name":"Lorenz","email":"lorenz@monogon.tech","username":"lorenz","avatars":[{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"da0407911657fa71d432f6d8bd9e6f0e81da195a","unresolved":false,"context_lines":[{"line_number":63,"context_line":"\t})"},{"line_number":64,"context_line":"}"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"func modifyOSIndications(f func(prev OSIndications) OSIndications) error {"},{"line_number":67,"context_line":"\tosIndicationsRaw, _, err :\u003d Read(ScopeGlobal, \"OsIndications\")"},{"line_number":68,"context_line":"\tif err !\u003d nil {"},{"line_number":69,"context_line":"\t\treturn fmt.Errorf(\"unable to read OsIndications variable: %w\", err)"}],"source_content_type":"text/x-go","patch_set":1,"id":"192be0a4_ba1c775e","line":66,"in_reply_to":"369ddb42_92fb3b24","updated":"2024-09-09 20:36:18.000000000","message":"Done","commit_id":"00602f9998c256a249f154492181a64302d62393"}]}