)]}'
{"osbase/blockdev/blockdev_linux.go":[{"author":{"_account_id":1000001,"name":"Lorenz Brun","display_name":"Lorenz","email":"lorenz@monogon.tech","username":"lorenz","avatars":[{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"24c5584131b68a2b61bee51eebfbb9f30a677bc3","unresolved":true,"context_lines":[{"line_number":124,"context_line":"\treturn nil"},{"line_number":125,"context_line":"}"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"// blkpgIoctlArg is a copy unix.BlkpgIoctlArg with the type of the Data field"},{"line_number":128,"context_line":"// changed from *byte to uintptr."},{"line_number":129,"context_line":"type blkpgIoctlArg struct {"},{"line_number":130,"context_line":"\tOp      int32"}],"source_content_type":"text/x-go","patch_set":1,"id":"b136b76d_91e81b27","line":127,"range":{"start_line":127,"start_character":3,"end_line":127,"end_character":16},"updated":"2024-08-28 15:07:46.000000000","message":"Is there a good argument why you can\u0027t do (*byte)(unsafe.Pointer(...)) and use the original struct? I\u0027d generally avoid redefining things in sys/unix if possible.","commit_id":"08823cf5d3ff53e9ac19b797347c7427794039ef"},{"author":{"_account_id":1000038,"name":"Jan Schär","display_name":"Jan","email":"jan@monogon.tech","username":"jan","avatars":[{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"6125de656f4fa6f55e8f694c8c98768b2124ec6b","unresolved":false,"context_lines":[{"line_number":124,"context_line":"\treturn nil"},{"line_number":125,"context_line":"}"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"// blkpgIoctlArg is a copy unix.BlkpgIoctlArg with the type of the Data field"},{"line_number":128,"context_line":"// changed from *byte to uintptr."},{"line_number":129,"context_line":"type blkpgIoctlArg struct {"},{"line_number":130,"context_line":"\tOp      int32"}],"source_content_type":"text/x-go","patch_set":1,"id":"c95261c9_14b47a8d","line":127,"range":{"start_line":127,"start_character":3,"end_line":127,"end_character":16},"in_reply_to":"b136b76d_91e81b27","updated":"2024-09-02 15:52:18.000000000","message":"x/sys/unix is using the `(*byte)(unsafe.Pointer(\u0026someStruct))` pattern itself, so it should be fine and I changed it to that.\nhttps://cs.opensource.google/go/x/sys/+/master:unix/syscall_linux.go;l\u003d1508;drc\u003dcde4660eb9c519b4373bebe3d42deebc744368f2","commit_id":"08823cf5d3ff53e9ac19b797347c7427794039ef"},{"author":{"_account_id":1000001,"name":"Lorenz Brun","display_name":"Lorenz","email":"lorenz@monogon.tech","username":"lorenz","avatars":[{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"24c5584131b68a2b61bee51eebfbb9f30a677bc3","unresolved":true,"context_lines":[{"line_number":133,"context_line":"\tData    uintptr"},{"line_number":134,"context_line":"}"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"// ResizePartition updates the start and length of one partition in the kernel."},{"line_number":137,"context_line":"// This can be used as an alternative to RefreshPartitionTable, which cannot"},{"line_number":138,"context_line":"// be used if any partition on this device is currently mounted."},{"line_number":139,"context_line":"func (d *Device) ResizePartition(partitionNo int32, start, length int64) error {"}],"source_content_type":"text/x-go","patch_set":1,"id":"a1c71fd4_96c0082d","line":136,"range":{"start_line":136,"start_character":3,"end_line":136,"end_character":18},"updated":"2024-08-28 15:07:46.000000000","message":"Needs to specify if start and length are in bytes or blocks. Also this is architecturally terrible but there is nothing you can do about it.","commit_id":"08823cf5d3ff53e9ac19b797347c7427794039ef"},{"author":{"_account_id":1000038,"name":"Jan Schär","display_name":"Jan","email":"jan@monogon.tech","username":"jan","avatars":[{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"6125de656f4fa6f55e8f694c8c98768b2124ec6b","unresolved":false,"context_lines":[{"line_number":133,"context_line":"\tData    uintptr"},{"line_number":134,"context_line":"}"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"// ResizePartition updates the start and length of one partition in the kernel."},{"line_number":137,"context_line":"// This can be used as an alternative to RefreshPartitionTable, which cannot"},{"line_number":138,"context_line":"// be used if any partition on this device is currently mounted."},{"line_number":139,"context_line":"func (d *Device) ResizePartition(partitionNo int32, start, length int64) error {"}],"source_content_type":"text/x-go","patch_set":1,"id":"18ab2416_4373d368","line":136,"range":{"start_line":136,"start_character":3,"end_line":136,"end_character":18},"in_reply_to":"a1c71fd4_96c0082d","updated":"2024-09-02 15:52:18.000000000","message":"Done","commit_id":"08823cf5d3ff53e9ac19b797347c7427794039ef"}]}
