)]}'
{"metropolis/node/core/network/dhcp4c/dhcpc.go":[{"author":{"_account_id":1000001,"name":"Lorenz Brun","display_name":"Lorenz","email":"lorenz@monogon.tech","username":"lorenz","avatars":[{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"d506dc2a16617a34f3e828ef4376c8e0eb767827","unresolved":true,"context_lines":[{"line_number":220,"context_line":"\t}"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"\tdiscoverBackoff :\u003d newDefaultBackoff()"},{"line_number":223,"context_line":"\tdiscoverBackoff.Reset()"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"\tacceptOfferBackoff :\u003d newDefaultBackoff()"},{"line_number":226,"context_line":"\t// Abort after 30s and go back to discovering"}],"source_content_type":"text/x-go","patch_set":2,"id":"a696b669_a1b1b026","line":223,"range":{"start_line":223,"start_character":1,"end_line":223,"end_character":24},"updated":"2024-07-11 12:32:27.000000000","message":"NewExponentialBackOff() already calls Reset(), can we fix this by moving the configuration of the ExponentialBackOff into an argument to its New function instead of calling Reset a second time?","commit_id":"2d3ce2e32cefc8481f1ff9c62a330065ffda56cb"},{"author":{"_account_id":1000038,"name":"Jan Schär","display_name":"Jan","email":"jan@monogon.tech","username":"jan","avatars":[{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"7857a5d229d6c48ce03f94e0e6a3edd9c8fe17a1","unresolved":true,"context_lines":[{"line_number":220,"context_line":"\t}"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"\tdiscoverBackoff :\u003d newDefaultBackoff()"},{"line_number":223,"context_line":"\tdiscoverBackoff.Reset()"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"\tacceptOfferBackoff :\u003d newDefaultBackoff()"},{"line_number":226,"context_line":"\t// Abort after 30s and go back to discovering"}],"source_content_type":"text/x-go","patch_set":2,"id":"953aa892_35cb94e1","line":223,"range":{"start_line":223,"start_character":1,"end_line":223,"end_character":24},"in_reply_to":"293fe3ee_908c0d87","updated":"2024-07-11 15:19:05.000000000","message":"I see, we are currently on v4.2.1 of the backoff library which does not have this feature yet, that\u0027s why I didn\u0027t see it before. Do you want me to update the library and change this to the functional options style?","commit_id":"2d3ce2e32cefc8481f1ff9c62a330065ffda56cb"},{"author":{"_account_id":1000038,"name":"Jan Schär","display_name":"Jan","email":"jan@monogon.tech","username":"jan","avatars":[{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"b2d84bbdbba2f81f09f29733bcac413c8fee8378","unresolved":false,"context_lines":[{"line_number":220,"context_line":"\t}"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"\tdiscoverBackoff :\u003d newDefaultBackoff()"},{"line_number":223,"context_line":"\tdiscoverBackoff.Reset()"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"\tacceptOfferBackoff :\u003d newDefaultBackoff()"},{"line_number":226,"context_line":"\t// Abort after 30s and go back to discovering"}],"source_content_type":"text/x-go","patch_set":2,"id":"ec54a3c8_b707371d","line":223,"range":{"start_line":223,"start_character":1,"end_line":223,"end_character":24},"in_reply_to":"6f375c43_8cfe0301","updated":"2024-07-11 17:35:51.000000000","message":"Done","commit_id":"2d3ce2e32cefc8481f1ff9c62a330065ffda56cb"},{"author":{"_account_id":1000001,"name":"Lorenz Brun","display_name":"Lorenz","email":"lorenz@monogon.tech","username":"lorenz","avatars":[{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"f55376eb56efc992b3553f92518995b011b975de","unresolved":true,"context_lines":[{"line_number":220,"context_line":"\t}"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"\tdiscoverBackoff :\u003d newDefaultBackoff()"},{"line_number":223,"context_line":"\tdiscoverBackoff.Reset()"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"\tacceptOfferBackoff :\u003d newDefaultBackoff()"},{"line_number":226,"context_line":"\t// Abort after 30s and go back to discovering"}],"source_content_type":"text/x-go","patch_set":2,"id":"6f375c43_8cfe0301","line":223,"range":{"start_line":223,"start_character":1,"end_line":223,"end_character":24},"in_reply_to":"953aa892_35cb94e1","updated":"2024-07-11 15:33:55.000000000","message":"Yes, just bump it to the current version and change it.","commit_id":"2d3ce2e32cefc8481f1ff9c62a330065ffda56cb"},{"author":{"_account_id":1000038,"name":"Jan Schär","display_name":"Jan","email":"jan@monogon.tech","username":"jan","avatars":[{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"b838431729137cbaae01a9f9e4ec9a48928770e2","unresolved":true,"context_lines":[{"line_number":220,"context_line":"\t}"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"\tdiscoverBackoff :\u003d newDefaultBackoff()"},{"line_number":223,"context_line":"\tdiscoverBackoff.Reset()"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"\tacceptOfferBackoff :\u003d newDefaultBackoff()"},{"line_number":226,"context_line":"\t// Abort after 30s and go back to discovering"}],"source_content_type":"text/x-go","patch_set":2,"id":"d32ffe42_61e9fa59","line":223,"range":{"start_line":223,"start_character":1,"end_line":223,"end_character":24},"in_reply_to":"a696b669_a1b1b026","updated":"2024-07-11 14:04:17.000000000","message":"Reset() needs to be called after changing InitialInterval. Reset() is cheap, it\u0027s not a problem that it is called twice. I think NewExponentialBackOff() calls it as a convenience so you don\u0027t have to when you don\u0027t change the default. I also don\u0027t really understand your suggestion.","commit_id":"2d3ce2e32cefc8481f1ff9c62a330065ffda56cb"},{"author":{"_account_id":1000001,"name":"Lorenz Brun","display_name":"Lorenz","email":"lorenz@monogon.tech","username":"lorenz","avatars":[{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"8163c3927afadefedb6a6bf49428f11cc3eb7591","unresolved":true,"context_lines":[{"line_number":220,"context_line":"\t}"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"\tdiscoverBackoff :\u003d newDefaultBackoff()"},{"line_number":223,"context_line":"\tdiscoverBackoff.Reset()"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"\tacceptOfferBackoff :\u003d newDefaultBackoff()"},{"line_number":226,"context_line":"\t// Abort after 30s and go back to discovering"}],"source_content_type":"text/x-go","patch_set":2,"id":"293fe3ee_908c0d87","line":223,"range":{"start_line":223,"start_character":1,"end_line":223,"end_character":24},"in_reply_to":"d32ffe42_61e9fa59","updated":"2024-07-11 14:16:24.000000000","message":"NewExponentialBackOff has an opts argument which could be used to set the settings before it internally calls Reset","commit_id":"2d3ce2e32cefc8481f1ff9c62a330065ffda56cb"}]}