)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000038,"name":"Jan Schär","display_name":"Jan","email":"jan@monogon.tech","username":"jan","avatars":[{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"63a1bdf0ba2c35a6046bc335e8cf28c6a79e8ab8","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"bd25f990_df770367","updated":"2024-07-04 09:41:15.000000000","message":"Since swap is enabled, there is now an outdated comment in metropolis/node/kubernetes/kubelet.go:\n\n```\n\t\tFailSwapOn:                   reconciler.False(), // Our kernel doesn\u0027t have swap enabled which breaks Kubelet\u0027s detection\n```\n\nDo I understand correctly that you only enable swap in the kernel build, but do not turn it on at runtime, as I don\u0027t see any call to swapon?","commit_id":"0dcec6d9656b9bb4b634f125df2a34432d1beccd"},{"author":{"_account_id":1000001,"name":"Lorenz Brun","display_name":"Lorenz","email":"lorenz@monogon.tech","username":"lorenz","avatars":[{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"f174cb67fc9703a124e7afb357129f12da640946","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c448107c_37b89d28","in_reply_to":"bd25f990_df770367","updated":"2024-07-04 09:57:19.000000000","message":"Comment is wrong, removed that. But this is still needed, as soon as we actually try to enable swap we\u0027d get a hard error otherwise. I also added an explicit kubelet swapping configuration. And yes, this CL does not actually add any swap space to our kernel.","commit_id":"0dcec6d9656b9bb4b634f125df2a34432d1beccd"}],"metropolis/node/core/mounts.go":[{"author":{"_account_id":1000038,"name":"Jan Schär","display_name":"Jan","email":"jan@monogon.tech","username":"jan","avatars":[{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"63a1bdf0ba2c35a6046bc335e8cf28c6a79e8ab8","unresolved":true,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"\t// Mount all available CGroups for v1 (v2 uses a single unified hierarchy"},{"line_number":54,"context_line":"\t// and is not supported by our runtimes yet)"},{"line_number":55,"context_line":"\tif err :\u003d unix.Mount(\"tmpfs\", \"/sys/fs/cgroup\", \"tmpfs\", unix.MS_NOEXEC|unix.MS_NOSUID|unix.MS_NODEV, \"\"); err !\u003d nil {"},{"line_number":56,"context_line":"\t\tpanic(err)"},{"line_number":57,"context_line":"\t}"},{"line_number":58,"context_line":"\tcgroupsRaw, err :\u003d os.ReadFile(\"/proc/cgroups\")"}],"source_content_type":"text/x-go","patch_set":1,"id":"bec7d0ed_2615a27b","side":"PARENT","line":55,"range":{"start_line":55,"start_character":88,"end_line":55,"end_character":101},"updated":"2024-07-04 09:41:15.000000000","message":"Why is the NODEV flag removed? Systemd sets NODEV for cgroup2: https://github.com/systemd/systemd/blob/92d9d5ca70b0a8b3aea12f24e9cd0f770c31a94c/src/shared/mount-setup.c#L104","commit_id":"f430fbfe35b70283090b6174cf5a920163c0148c"},{"author":{"_account_id":1000001,"name":"Lorenz Brun","display_name":"Lorenz","email":"lorenz@monogon.tech","username":"lorenz","avatars":[{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"f174cb67fc9703a124e7afb357129f12da640946","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"\t// Mount all available CGroups for v1 (v2 uses a single unified hierarchy"},{"line_number":54,"context_line":"\t// and is not supported by our runtimes yet)"},{"line_number":55,"context_line":"\tif err :\u003d unix.Mount(\"tmpfs\", \"/sys/fs/cgroup\", \"tmpfs\", unix.MS_NOEXEC|unix.MS_NOSUID|unix.MS_NODEV, \"\"); err !\u003d nil {"},{"line_number":56,"context_line":"\t\tpanic(err)"},{"line_number":57,"context_line":"\t}"},{"line_number":58,"context_line":"\tcgroupsRaw, err :\u003d os.ReadFile(\"/proc/cgroups\")"}],"source_content_type":"text/x-go","patch_set":1,"id":"73939694_a7ed336e","side":"PARENT","line":55,"range":{"start_line":55,"start_character":88,"end_line":55,"end_character":101},"in_reply_to":"bec7d0ed_2615a27b","updated":"2024-07-04 09:57:19.000000000","message":"Done","commit_id":"f430fbfe35b70283090b6174cf5a920163c0148c"},{"author":{"_account_id":1000038,"name":"Jan Schär","display_name":"Jan","email":"jan@monogon.tech","username":"jan","avatars":[{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"cf90d3a6912f67bed7650426618070a9d39a0160","unresolved":true,"context_lines":[{"line_number":54,"context_line":"\t\tpanic(err)"},{"line_number":55,"context_line":"\t}"},{"line_number":56,"context_line":"\t// Create main cgroup \"everything\" and move ourselves into it."},{"line_number":57,"context_line":"\tif err :\u003d os.Mkdir(\"/sys/fs/cgroup/everything\", 0644); err !\u003d nil {"},{"line_number":58,"context_line":"\t\tpanic(err)"},{"line_number":59,"context_line":"\t}"},{"line_number":60,"context_line":"\tif err :\u003d cgroups.WriteCgroupProc(\"/sys/fs/cgroup/everything\", os.Getpid()); err !\u003d nil {"}],"source_content_type":"text/x-go","patch_set":2,"id":"e0767c88_50b7d192","line":57,"range":{"start_line":57,"start_character":50,"end_line":57,"end_character":53},"updated":"2024-07-04 11:25:31.000000000","message":"Is there a reason to use 644 here? Usually, 755 is used for directories.","commit_id":"f451f0a8790525cd9b981e15135f34af829d32f0"},{"author":{"_account_id":1000001,"name":"Lorenz Brun","display_name":"Lorenz","email":"lorenz@monogon.tech","username":"lorenz","avatars":[{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"85c9aaab749a0f72b4b0416e756c0e71a2db7066","unresolved":false,"context_lines":[{"line_number":54,"context_line":"\t\tpanic(err)"},{"line_number":55,"context_line":"\t}"},{"line_number":56,"context_line":"\t// Create main cgroup \"everything\" and move ourselves into it."},{"line_number":57,"context_line":"\tif err :\u003d os.Mkdir(\"/sys/fs/cgroup/everything\", 0644); err !\u003d nil {"},{"line_number":58,"context_line":"\t\tpanic(err)"},{"line_number":59,"context_line":"\t}"},{"line_number":60,"context_line":"\tif err :\u003d cgroups.WriteCgroupProc(\"/sys/fs/cgroup/everything\", os.Getpid()); err !\u003d nil {"}],"source_content_type":"text/x-go","patch_set":2,"id":"b9bd6c67_0d83414d","line":57,"range":{"start_line":57,"start_character":50,"end_line":57,"end_character":53},"in_reply_to":"e0767c88_50b7d192","updated":"2024-07-04 11:59:33.000000000","message":"Done","commit_id":"f451f0a8790525cd9b981e15135f34af829d32f0"}]}