)]}'
{"metropolis/test/launch/cluster/cluster.go":[{"author":{"_account_id":1000038,"name":"Jan Schär","display_name":"Jan","email":"jan@monogon.tech","username":"jan","avatars":[{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"698106ffe6136162e1a9720e25a2870e667d7255","unresolved":true,"context_lines":[{"line_number":1036,"context_line":"\t\t\t\t\treturn nil, fmt.Errorf(\"node %s has undecodable number label: %w\", n.Id, err)"},{"line_number":1037,"context_line":"\t\t\t\t}"},{"line_number":1038,"context_line":"\t\t\t\tlaunch.Log(\"Cluster: Node %d is %s\", num, n.Id)"},{"line_number":1039,"context_line":"\t\t\t\tnodeNumberToID[num] \u003d n.Id"},{"line_number":1040,"context_line":"\t\t\t}"},{"line_number":1041,"context_line":""},{"line_number":1042,"context_line":"\t\t\tif len(seenNodes) \u003d\u003d opts.NumNodes-1 {"}],"source_content_type":"text/x-go","patch_set":1,"id":"0894df73_4688ed7f","line":1039,"updated":"2024-06-18 15:19:31.000000000","message":"Optional: If you preallocate `cluster.NodeIDs` to the right size, you could directly assign to `cluster.NodeIDs[num]` here and not need the map.","commit_id":"72e15feefa4602a1ea61638853e60bd32a952f67"},{"author":{"_account_id":1000002,"name":"Serge Bazanski","display_name":"Serge","email":"serge@monogon.tech","username":"serge","avatars":[{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"924582376718b8b0c819ac2c6055d47998eb10e6","unresolved":false,"context_lines":[{"line_number":1036,"context_line":"\t\t\t\t\treturn nil, fmt.Errorf(\"node %s has undecodable number label: %w\", n.Id, err)"},{"line_number":1037,"context_line":"\t\t\t\t}"},{"line_number":1038,"context_line":"\t\t\t\tlaunch.Log(\"Cluster: Node %d is %s\", num, n.Id)"},{"line_number":1039,"context_line":"\t\t\t\tnodeNumberToID[num] \u003d n.Id"},{"line_number":1040,"context_line":"\t\t\t}"},{"line_number":1041,"context_line":""},{"line_number":1042,"context_line":"\t\t\tif len(seenNodes) \u003d\u003d opts.NumNodes-1 {"}],"source_content_type":"text/x-go","patch_set":1,"id":"20ca556e_4492369b","line":1039,"in_reply_to":"0244cc93_a17d71e7","updated":"2024-06-24 20:35:28.000000000","message":"Done","commit_id":"72e15feefa4602a1ea61638853e60bd32a952f67"},{"author":{"_account_id":1000002,"name":"Serge Bazanski","display_name":"Serge","email":"serge@monogon.tech","username":"serge","avatars":[{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"96b3318fe74c1f44e6781437e52136dca719df5b","unresolved":true,"context_lines":[{"line_number":1036,"context_line":"\t\t\t\t\treturn nil, fmt.Errorf(\"node %s has undecodable number label: %w\", n.Id, err)"},{"line_number":1037,"context_line":"\t\t\t\t}"},{"line_number":1038,"context_line":"\t\t\t\tlaunch.Log(\"Cluster: Node %d is %s\", num, n.Id)"},{"line_number":1039,"context_line":"\t\t\t\tnodeNumberToID[num] \u003d n.Id"},{"line_number":1040,"context_line":"\t\t\t}"},{"line_number":1041,"context_line":""},{"line_number":1042,"context_line":"\t\t\tif len(seenNodes) \u003d\u003d opts.NumNodes-1 {"}],"source_content_type":"text/x-go","patch_set":1,"id":"7373b2d1_cb3d263c","line":1039,"in_reply_to":"0894df73_4688ed7f","updated":"2024-06-24 13:11:14.000000000","message":"Is that any better now? I feel with NodeIDs potentially containing invalid zero-entries this makes the change not necessarily worth the extra complexity.\n\nIdeally I should just sit down and rewrite the whole cluster test subsystem, it\u0027s getting really janky.","commit_id":"72e15feefa4602a1ea61638853e60bd32a952f67"},{"author":{"_account_id":1000038,"name":"Jan Schär","display_name":"Jan","email":"jan@monogon.tech","username":"jan","avatars":[{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"971ff1f0d245f3b9c5d2f022805b0c60c49f417e","unresolved":true,"context_lines":[{"line_number":1036,"context_line":"\t\t\t\t\treturn nil, fmt.Errorf(\"node %s has undecodable number label: %w\", n.Id, err)"},{"line_number":1037,"context_line":"\t\t\t\t}"},{"line_number":1038,"context_line":"\t\t\t\tlaunch.Log(\"Cluster: Node %d is %s\", num, n.Id)"},{"line_number":1039,"context_line":"\t\t\t\tnodeNumberToID[num] \u003d n.Id"},{"line_number":1040,"context_line":"\t\t\t}"},{"line_number":1041,"context_line":""},{"line_number":1042,"context_line":"\t\t\tif len(seenNodes) \u003d\u003d opts.NumNodes-1 {"}],"source_content_type":"text/x-go","patch_set":1,"id":"0244cc93_a17d71e7","line":1039,"in_reply_to":"7373b2d1_cb3d263c","updated":"2024-06-24 15:21:51.000000000","message":"I didn\u0027t see before that NodeIDs is already accessed when creating the curator client, before adding the other nodes. So I agree that the previous version is better.","commit_id":"72e15feefa4602a1ea61638853e60bd32a952f67"}]}