)]}'
{"metropolis/node/core/network/static.go":[{"author":{"_account_id":1000002,"name":"Serge Bazanski","display_name":"Serge","email":"serge@monogon.tech","username":"serge","avatars":[{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"39a3a7bca40d2b784e6943c826d4ce0c0181d5c2","unresolved":true,"context_lines":[{"line_number":118,"context_line":"\t\t\t}()"},{"line_number":119,"context_line":"\t\t}"},{"line_number":120,"context_line":"\t\tnameLinkMap[i.Name] \u003d newLink"},{"line_number":121,"context_line":"\t\t// Get the link from the kernel again to get all defaulted and"},{"line_number":122,"context_line":"\t\t// hardware-derived attributes."},{"line_number":123,"context_line":"\t\tnewLinkWithAttrs, err :\u003d netlink.LinkByIndex(newLink.Attrs().Index)"},{"line_number":124,"context_line":"\t\tif err !\u003d nil {"}],"source_content_type":"text/x-go","patch_set":2,"id":"fe4ff772_e6e88e9a","line":121,"updated":"2024-06-18 09:13:13.000000000","message":"This function is now 163 lines long and is starting to be difficult to reason about and thus review. I think it\u0027s time to split it up.","commit_id":"df9d8c8cb31cadbed6087f18857c3c935f4d0e84"},{"author":{"_account_id":1000002,"name":"Serge Bazanski","display_name":"Serge","email":"serge@monogon.tech","username":"serge","avatars":[{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"5541a9c9196329da45a216128071b173be538aeb","unresolved":true,"context_lines":[{"line_number":118,"context_line":"\t\t\t}()"},{"line_number":119,"context_line":"\t\t}"},{"line_number":120,"context_line":"\t\tnameLinkMap[i.Name] \u003d newLink"},{"line_number":121,"context_line":"\t\t// Get the link from the kernel again to get all defaulted and"},{"line_number":122,"context_line":"\t\t// hardware-derived attributes."},{"line_number":123,"context_line":"\t\tnewLinkWithAttrs, err :\u003d netlink.LinkByIndex(newLink.Attrs().Index)"},{"line_number":124,"context_line":"\t\tif err !\u003d nil {"}],"source_content_type":"text/x-go","patch_set":2,"id":"dc99bed6_14cd4b23","line":121,"in_reply_to":"10ead14b_3089c20a","updated":"2024-06-20 11:17:47.000000000","message":"Please work on this soon, any more changes to it will be exponentially more difficult to review or even implement bug-free in the first place.","commit_id":"df9d8c8cb31cadbed6087f18857c3c935f4d0e84"},{"author":{"_account_id":1000001,"name":"Lorenz Brun","display_name":"Lorenz","email":"lorenz@monogon.tech","username":"lorenz","avatars":[{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"3476e6f7a5d45f0205c93d7992e76d5042ccbd90","unresolved":false,"context_lines":[{"line_number":118,"context_line":"\t\t\t}()"},{"line_number":119,"context_line":"\t\t}"},{"line_number":120,"context_line":"\t\tnameLinkMap[i.Name] \u003d newLink"},{"line_number":121,"context_line":"\t\t// Get the link from the kernel again to get all defaulted and"},{"line_number":122,"context_line":"\t\t// hardware-derived attributes."},{"line_number":123,"context_line":"\t\tnewLinkWithAttrs, err :\u003d netlink.LinkByIndex(newLink.Attrs().Index)"},{"line_number":124,"context_line":"\t\tif err !\u003d nil {"}],"source_content_type":"text/x-go","patch_set":2,"id":"7fda82ea_f5f3bec0","line":121,"in_reply_to":"dc99bed6_14cd4b23","updated":"2024-06-20 12:04:07.000000000","message":"Acknowledged","commit_id":"df9d8c8cb31cadbed6087f18857c3c935f4d0e84"},{"author":{"_account_id":1000001,"name":"Lorenz Brun","display_name":"Lorenz","email":"lorenz@monogon.tech","username":"lorenz","avatars":[{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"4d65f37bde245303248dd8217f96f7d04c2a44ce","unresolved":true,"context_lines":[{"line_number":118,"context_line":"\t\t\t}()"},{"line_number":119,"context_line":"\t\t}"},{"line_number":120,"context_line":"\t\tnameLinkMap[i.Name] \u003d newLink"},{"line_number":121,"context_line":"\t\t// Get the link from the kernel again to get all defaulted and"},{"line_number":122,"context_line":"\t\t// hardware-derived attributes."},{"line_number":123,"context_line":"\t\tnewLinkWithAttrs, err :\u003d netlink.LinkByIndex(newLink.Attrs().Index)"},{"line_number":124,"context_line":"\t\tif err !\u003d nil {"}],"source_content_type":"text/x-go","patch_set":2,"id":"10ead14b_3089c20a","line":121,"in_reply_to":"fe4ff772_e6e88e9a","updated":"2024-06-18 14:05:51.000000000","message":"This is only adding 6 lines of which 2 are comments and three error handling, in effect this is one new function call. Refactoring this should be done separately.","commit_id":"df9d8c8cb31cadbed6087f18857c3c935f4d0e84"}]}