)]}'
{"metropolis/test/swtpm/README.md":[{"author":{"_account_id":1000001,"name":"Lorenz Brun","display_name":"Lorenz","email":"lorenz@monogon.tech","username":"lorenz","avatars":[{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"724ab271d6e045dd40c91a8a3e39c43fcfe71e93","unresolved":true,"context_lines":[{"line_number":28,"context_line":"----------"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"This is a reimplementation of swtpm_cert in Go. The upstream swtpm_cert is implemented in C and has a hard dependency on"},{"line_number":31,"context_line":"GnuTLS nad libtasn1. Rewriting it in Go and using plain stdlib functions seems like the correct solution here (the"},{"line_number":32,"context_line":"alternative being either bringing in GnuTLS/libtasn1 into `third_party`, or rewriting swtpm_cert to use"},{"line_number":33,"context_line":"OpenSSL/BoringSSL)."},{"line_number":34,"context_line":""}],"source_content_type":"text/x-gfm","patch_set":2,"id":"d6f5e6de_a145ce98","line":31,"range":{"start_line":31,"start_character":7,"end_line":31,"end_character":10},"updated":"2024-06-07 00:06:27.000000000","message":"```suggestion\nGnuTLS and libtasn1. Rewriting it in Go and using plain stdlib functions seems like the correct solution here (the\n```","commit_id":"ea567ee2d8da830fc7ce1a38c524af99a980ef41"},{"author":{"_account_id":1000002,"name":"Serge Bazanski","display_name":"Serge","email":"serge@monogon.tech","username":"serge","avatars":[{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"7d78fb0e458da37a418368199fa96fd53b0690bd","unresolved":false,"context_lines":[{"line_number":28,"context_line":"----------"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"This is a reimplementation of swtpm_cert in Go. The upstream swtpm_cert is implemented in C and has a hard dependency on"},{"line_number":31,"context_line":"GnuTLS nad libtasn1. Rewriting it in Go and using plain stdlib functions seems like the correct solution here (the"},{"line_number":32,"context_line":"alternative being either bringing in GnuTLS/libtasn1 into `third_party`, or rewriting swtpm_cert to use"},{"line_number":33,"context_line":"OpenSSL/BoringSSL)."},{"line_number":34,"context_line":""}],"source_content_type":"text/x-gfm","patch_set":2,"id":"0a4a173a_1635e8c4","line":31,"range":{"start_line":31,"start_character":7,"end_line":31,"end_character":10},"in_reply_to":"d6f5e6de_a145ce98","updated":"2024-06-11 09:25:09.000000000","message":"Done","commit_id":"ea567ee2d8da830fc7ce1a38c524af99a980ef41"}],"metropolis/test/swtpm/swtpm_cert/asn1.go":[{"author":{"_account_id":1000001,"name":"Lorenz Brun","display_name":"Lorenz","email":"lorenz@monogon.tech","username":"lorenz","avatars":[{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"724ab271d6e045dd40c91a8a3e39c43fcfe71e93","unresolved":true,"context_lines":[{"line_number":113,"context_line":"// structure from TCG EK Credential Profile For TPM Family 2.0; Level 0; Version"},{"line_number":114,"context_line":"// 2.4; Revision 3; 16 July 2021)."},{"line_number":115,"context_line":"//"},{"line_number":116,"context_line":"// This is embedded as a directoryName extension in the generated X509"},{"line_number":117,"context_line":"// certificate for an EK."},{"line_number":118,"context_line":"func buildSpecificationInfo(family string, level, revision int) []byte {"},{"line_number":119,"context_line":"\tvar v specificationInfo"}],"source_content_type":"text/x-go","patch_set":2,"id":"ab152cff_b0405275","line":116,"range":{"start_line":116,"start_character":25,"end_line":116,"end_character":48},"updated":"2024-06-07 00:06:27.000000000","message":"```suggestion\n// This is embedded as a directoryName SAN or extension in the generated X509\n```","commit_id":"ea567ee2d8da830fc7ce1a38c524af99a980ef41"},{"author":{"_account_id":1000002,"name":"Serge Bazanski","display_name":"Serge","email":"serge@monogon.tech","username":"serge","avatars":[{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"7d78fb0e458da37a418368199fa96fd53b0690bd","unresolved":false,"context_lines":[{"line_number":113,"context_line":"// structure from TCG EK Credential Profile For TPM Family 2.0; Level 0; Version"},{"line_number":114,"context_line":"// 2.4; Revision 3; 16 July 2021)."},{"line_number":115,"context_line":"//"},{"line_number":116,"context_line":"// This is embedded as a directoryName extension in the generated X509"},{"line_number":117,"context_line":"// certificate for an EK."},{"line_number":118,"context_line":"func buildSpecificationInfo(family string, level, revision int) []byte {"},{"line_number":119,"context_line":"\tvar v specificationInfo"}],"source_content_type":"text/x-go","patch_set":2,"id":"5ac9ee5b_5dd050d1","line":116,"range":{"start_line":116,"start_character":25,"end_line":116,"end_character":48},"in_reply_to":"ab152cff_b0405275","updated":"2024-06-11 09:25:09.000000000","message":"Done","commit_id":"ea567ee2d8da830fc7ce1a38c524af99a980ef41"}],"metropolis/test/swtpm/swtpm_cert/main.go":[{"author":{"_account_id":1000038,"name":"Jan Schär","display_name":"Jan","email":"jan@monogon.tech","username":"jan","avatars":[{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"6fa477cc1bb461aca2487db059e21b259da7f7fd","unresolved":true,"context_lines":[{"line_number":67,"context_line":"\t\tvar x, y big.Int"},{"line_number":68,"context_line":"\t\txBytes, err :\u003d hex.DecodeString(flagECCX)"},{"line_number":69,"context_line":"\t\tif err !\u003d nil {"},{"line_number":70,"context_line":"\t\t\tlog.Fatalf(\"Could not decide ECC X: %v\", err)"},{"line_number":71,"context_line":"\t\t}"},{"line_number":72,"context_line":"\t\tx.SetBytes(xBytes)"},{"line_number":73,"context_line":"\t\tyBytes, err :\u003d hex.DecodeString(flagECCY)"}],"source_content_type":"text/x-go","patch_set":2,"id":"576b7c24_9f828b17","line":70,"range":{"start_line":70,"start_character":25,"end_line":70,"end_character":31},"updated":"2024-06-05 08:04:05.000000000","message":"should be \"decode\"","commit_id":"ea567ee2d8da830fc7ce1a38c524af99a980ef41"},{"author":{"_account_id":1000002,"name":"Serge Bazanski","display_name":"Serge","email":"serge@monogon.tech","username":"serge","avatars":[{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"7d78fb0e458da37a418368199fa96fd53b0690bd","unresolved":false,"context_lines":[{"line_number":67,"context_line":"\t\tvar x, y big.Int"},{"line_number":68,"context_line":"\t\txBytes, err :\u003d hex.DecodeString(flagECCX)"},{"line_number":69,"context_line":"\t\tif err !\u003d nil {"},{"line_number":70,"context_line":"\t\t\tlog.Fatalf(\"Could not decide ECC X: %v\", err)"},{"line_number":71,"context_line":"\t\t}"},{"line_number":72,"context_line":"\t\tx.SetBytes(xBytes)"},{"line_number":73,"context_line":"\t\tyBytes, err :\u003d hex.DecodeString(flagECCY)"}],"source_content_type":"text/x-go","patch_set":2,"id":"03ecaf87_2f714dee","line":70,"range":{"start_line":70,"start_character":25,"end_line":70,"end_character":31},"in_reply_to":"576b7c24_9f828b17","updated":"2024-06-11 09:25:09.000000000","message":"Done","commit_id":"ea567ee2d8da830fc7ce1a38c524af99a980ef41"},{"author":{"_account_id":1000001,"name":"Lorenz Brun","display_name":"Lorenz","email":"lorenz@monogon.tech","username":"lorenz","avatars":[{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"724ab271d6e045dd40c91a8a3e39c43fcfe71e93","unresolved":true,"context_lines":[{"line_number":77,"context_line":"\t\ty.SetBytes(yBytes)"},{"line_number":78,"context_line":"\t\tres :\u003d ecdsa.PublicKey{X: \u0026x, Y: \u0026y}"},{"line_number":79,"context_line":"\t\tswitch flagECCCurveID {"},{"line_number":80,"context_line":"\t\tcase \"secp384r1\":"},{"line_number":81,"context_line":"\t\t\tres.Curve \u003d elliptic.P384()"},{"line_number":82,"context_line":"\t\tdefault:"},{"line_number":83,"context_line":"\t\t\tlog.Fatalf(\"Unknown ECC curve ID %q\", flagECCCurveID)"}],"source_content_type":"text/x-go","patch_set":2,"id":"9cf6e8e2_e0962f7d","line":80,"range":{"start_line":80,"start_character":8,"end_line":80,"end_character":17},"updated":"2024-06-07 00:06:27.000000000","message":"Also implement secp256r1 aka P256 here, it\u0027s by far the most common curve.","commit_id":"ea567ee2d8da830fc7ce1a38c524af99a980ef41"},{"author":{"_account_id":1000002,"name":"Serge Bazanski","display_name":"Serge","email":"serge@monogon.tech","username":"serge","avatars":[{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"7d78fb0e458da37a418368199fa96fd53b0690bd","unresolved":false,"context_lines":[{"line_number":77,"context_line":"\t\ty.SetBytes(yBytes)"},{"line_number":78,"context_line":"\t\tres :\u003d ecdsa.PublicKey{X: \u0026x, Y: \u0026y}"},{"line_number":79,"context_line":"\t\tswitch flagECCCurveID {"},{"line_number":80,"context_line":"\t\tcase \"secp384r1\":"},{"line_number":81,"context_line":"\t\t\tres.Curve \u003d elliptic.P384()"},{"line_number":82,"context_line":"\t\tdefault:"},{"line_number":83,"context_line":"\t\t\tlog.Fatalf(\"Unknown ECC curve ID %q\", flagECCCurveID)"}],"source_content_type":"text/x-go","patch_set":2,"id":"688d5cc6_9284cfe0","line":80,"range":{"start_line":80,"start_character":8,"end_line":80,"end_character":17},"in_reply_to":"9cf6e8e2_e0962f7d","updated":"2024-06-11 09:25:09.000000000","message":"Done","commit_id":"ea567ee2d8da830fc7ce1a38c524af99a980ef41"},{"author":{"_account_id":1000001,"name":"Lorenz Brun","display_name":"Lorenz","email":"lorenz@monogon.tech","username":"lorenz","avatars":[{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"724ab271d6e045dd40c91a8a3e39c43fcfe71e93","unresolved":true,"context_lines":[{"line_number":227,"context_line":"\tif flagDays \u003e 0 {"},{"line_number":228,"context_line":"\t\tcert.NotAfter \u003d time.Now().Add(time.Hour * 24 * time.Duration(flagDays))"},{"line_number":229,"context_line":"\t} else {"},{"line_number":230,"context_line":"\t\tcert.NotAfter \u003d time.Unix(253402300799, 0)"},{"line_number":231,"context_line":"\t}"},{"line_number":232,"context_line":"\tif flagSubject !\u003d \"\" {"},{"line_number":233,"context_line":"\t\tparts :\u003d strings.Split(flagSubject, \",\")"}],"source_content_type":"text/x-go","patch_set":2,"id":"80f9bbe6_7d9dcc7b","line":230,"range":{"start_line":230,"start_character":18,"end_line":230,"end_character":44},"updated":"2024-06-07 00:06:27.000000000","message":"Please move this magic constant to an actual constant.","commit_id":"ea567ee2d8da830fc7ce1a38c524af99a980ef41"},{"author":{"_account_id":1000002,"name":"Serge Bazanski","display_name":"Serge","email":"serge@monogon.tech","username":"serge","avatars":[{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"7d78fb0e458da37a418368199fa96fd53b0690bd","unresolved":false,"context_lines":[{"line_number":227,"context_line":"\tif flagDays \u003e 0 {"},{"line_number":228,"context_line":"\t\tcert.NotAfter \u003d time.Now().Add(time.Hour * 24 * time.Duration(flagDays))"},{"line_number":229,"context_line":"\t} else {"},{"line_number":230,"context_line":"\t\tcert.NotAfter \u003d time.Unix(253402300799, 0)"},{"line_number":231,"context_line":"\t}"},{"line_number":232,"context_line":"\tif flagSubject !\u003d \"\" {"},{"line_number":233,"context_line":"\t\tparts :\u003d strings.Split(flagSubject, \",\")"}],"source_content_type":"text/x-go","patch_set":2,"id":"b8323915_a6cf1987","line":230,"range":{"start_line":230,"start_character":18,"end_line":230,"end_character":44},"in_reply_to":"80f9bbe6_7d9dcc7b","updated":"2024-06-11 09:25:09.000000000","message":"Done","commit_id":"ea567ee2d8da830fc7ce1a38c524af99a980ef41"},{"author":{"_account_id":1000001,"name":"Lorenz Brun","display_name":"Lorenz","email":"lorenz@monogon.tech","username":"lorenz","avatars":[{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"724ab271d6e045dd40c91a8a3e39c43fcfe71e93","unresolved":true,"context_lines":[{"line_number":260,"context_line":"\t}"},{"line_number":261,"context_line":"\tcert.ExtraExtensions \u003d []pkix.Extension{"},{"line_number":262,"context_line":"\t\t{"},{"line_number":263,"context_line":"\t\t\tId:    asn1.ObjectIdentifier{2, 5, 29, 17}, // subjectAltNAme"},{"line_number":264,"context_line":"\t\t\tValue: sanBytes,"},{"line_number":265,"context_line":"\t\t},"},{"line_number":266,"context_line":"\t}"}],"source_content_type":"text/x-go","patch_set":2,"id":"6b545119_6c5218f1","line":263,"range":{"start_line":263,"start_character":50,"end_line":263,"end_character":64},"updated":"2024-06-07 00:06:27.000000000","message":"```suggestion\n\t\t\tId:    asn1.ObjectIdentifier{2, 5, 29, 17}, // subjectAltName\n```","commit_id":"ea567ee2d8da830fc7ce1a38c524af99a980ef41"},{"author":{"_account_id":1000002,"name":"Serge Bazanski","display_name":"Serge","email":"serge@monogon.tech","username":"serge","avatars":[{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"7d78fb0e458da37a418368199fa96fd53b0690bd","unresolved":false,"context_lines":[{"line_number":260,"context_line":"\t}"},{"line_number":261,"context_line":"\tcert.ExtraExtensions \u003d []pkix.Extension{"},{"line_number":262,"context_line":"\t\t{"},{"line_number":263,"context_line":"\t\t\tId:    asn1.ObjectIdentifier{2, 5, 29, 17}, // subjectAltNAme"},{"line_number":264,"context_line":"\t\t\tValue: sanBytes,"},{"line_number":265,"context_line":"\t\t},"},{"line_number":266,"context_line":"\t}"}],"source_content_type":"text/x-go","patch_set":2,"id":"fae0d1c5_97056d0e","line":263,"range":{"start_line":263,"start_character":50,"end_line":263,"end_character":64},"in_reply_to":"6b545119_6c5218f1","updated":"2024-06-11 09:25:09.000000000","message":"Done","commit_id":"ea567ee2d8da830fc7ce1a38c524af99a980ef41"},{"author":{"_account_id":1000001,"name":"Lorenz Brun","display_name":"Lorenz","email":"lorenz@monogon.tech","username":"lorenz","avatars":[{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"724ab271d6e045dd40c91a8a3e39c43fcfe71e93","unresolved":true,"context_lines":[{"line_number":272,"context_line":"\t}"},{"line_number":273,"context_line":"\tcert.BasicConstraintsValid \u003d true"},{"line_number":274,"context_line":"\tcert.IsCA \u003d false"},{"line_number":275,"context_line":"\tcert.AuthorityKeyId \u003d issuercert.AuthorityKeyId"},{"line_number":276,"context_line":"\tswitch ty {"},{"line_number":277,"context_line":"\tcase certTypeEK:"},{"line_number":278,"context_line":"\t\t// tcg-kp-EKCertificate"}],"source_content_type":"text/x-go","patch_set":2,"id":"f6573a5f_eb38b19c","line":275,"range":{"start_line":275,"start_character":0,"end_line":275,"end_character":48},"updated":"2024-06-07 00:06:27.000000000","message":"This is incorrect, AuthorityKeyId of the leaf cert needs to be SubjectKeyId of the parent CA. You can also just drop the line, this is done correctly by Go already.","commit_id":"ea567ee2d8da830fc7ce1a38c524af99a980ef41"},{"author":{"_account_id":1000002,"name":"Serge Bazanski","display_name":"Serge","email":"serge@monogon.tech","username":"serge","avatars":[{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"7d78fb0e458da37a418368199fa96fd53b0690bd","unresolved":false,"context_lines":[{"line_number":272,"context_line":"\t}"},{"line_number":273,"context_line":"\tcert.BasicConstraintsValid \u003d true"},{"line_number":274,"context_line":"\tcert.IsCA \u003d false"},{"line_number":275,"context_line":"\tcert.AuthorityKeyId \u003d issuercert.AuthorityKeyId"},{"line_number":276,"context_line":"\tswitch ty {"},{"line_number":277,"context_line":"\tcase certTypeEK:"},{"line_number":278,"context_line":"\t\t// tcg-kp-EKCertificate"}],"source_content_type":"text/x-go","patch_set":2,"id":"f2fcce04_299c2ab2","line":275,"range":{"start_line":275,"start_character":0,"end_line":275,"end_character":48},"in_reply_to":"f6573a5f_eb38b19c","updated":"2024-06-11 09:25:09.000000000","message":"Done","commit_id":"ea567ee2d8da830fc7ce1a38c524af99a980ef41"}]}