)]}'
{"metropolis/node/core/network/dhcp4c/dhcpc.go":[{"author":{"_account_id":1000002,"name":"Serge Bazanski","display_name":"Serge","email":"serge@monogon.tech","username":"serge","avatars":[{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"043f00c3374497dfe3c23a4462764b5bc26bde2b","unresolved":true,"context_lines":[{"line_number":243,"context_line":"\t\t}"},{"line_number":244,"context_line":"\t}"},{"line_number":245,"context_line":"\tif !hasValidHWAddr {"},{"line_number":246,"context_line":"\t\treturn nil, fmt.Errorf(\"iface HardwareAddr is invalid (only zeroes or invalid length): %x\", iface.HardwareAddr)"},{"line_number":247,"context_line":"\t}"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"\treturn \u0026Client{"}],"source_content_type":"text/x-go","patch_set":1,"id":"d36aa04e_75ce73c1","line":246,"range":{"start_line":246,"start_character":72,"end_line":246,"end_character":86},"updated":"2024-05-28 10:16:49.000000000","message":"Are we checking that?","commit_id":"37a3227acb42a8533e1b75a6d9455611a0b66197"},{"author":{"_account_id":1000002,"name":"Serge Bazanski","display_name":"Serge","email":"serge@monogon.tech","username":"serge","avatars":[{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"a17a5c46671ccb7d536a5b92e035903f2065681f","unresolved":true,"context_lines":[{"line_number":243,"context_line":"\t\t}"},{"line_number":244,"context_line":"\t}"},{"line_number":245,"context_line":"\tif !hasValidHWAddr {"},{"line_number":246,"context_line":"\t\treturn nil, fmt.Errorf(\"iface HardwareAddr is invalid (only zeroes or invalid length): %x\", iface.HardwareAddr)"},{"line_number":247,"context_line":"\t}"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"\treturn \u0026Client{"}],"source_content_type":"text/x-go","patch_set":1,"id":"c5884a02_75dee513","line":246,"range":{"start_line":246,"start_character":72,"end_line":246,"end_character":86},"in_reply_to":"a5966d97_43bee2c6","updated":"2024-05-28 22:13:43.000000000","message":"Mention this in a comment.","commit_id":"37a3227acb42a8533e1b75a6d9455611a0b66197"},{"author":{"_account_id":1000001,"name":"Lorenz Brun","display_name":"Lorenz","email":"lorenz@monogon.tech","username":"lorenz","avatars":[{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"6e56e1b65235f03d8d12e6b090bec605f1bb27d0","unresolved":false,"context_lines":[{"line_number":243,"context_line":"\t\t}"},{"line_number":244,"context_line":"\t}"},{"line_number":245,"context_line":"\tif !hasValidHWAddr {"},{"line_number":246,"context_line":"\t\treturn nil, fmt.Errorf(\"iface HardwareAddr is invalid (only zeroes or invalid length): %x\", iface.HardwareAddr)"},{"line_number":247,"context_line":"\t}"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"\treturn \u0026Client{"}],"source_content_type":"text/x-go","patch_set":1,"id":"ee7cf8c0_15becad4","line":246,"range":{"start_line":246,"start_character":72,"end_line":246,"end_character":86},"in_reply_to":"c5884a02_75dee513","updated":"2024-06-13 09:50:56.000000000","message":"Done","commit_id":"37a3227acb42a8533e1b75a6d9455611a0b66197"},{"author":{"_account_id":1000001,"name":"Lorenz Brun","display_name":"Lorenz","email":"lorenz@monogon.tech","username":"lorenz","avatars":[{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"b5f433cb44fc9f58c5a5cb13d5ba6bbab297abf1","unresolved":true,"context_lines":[{"line_number":243,"context_line":"\t\t}"},{"line_number":244,"context_line":"\t}"},{"line_number":245,"context_line":"\tif !hasValidHWAddr {"},{"line_number":246,"context_line":"\t\treturn nil, fmt.Errorf(\"iface HardwareAddr is invalid (only zeroes or invalid length): %x\", iface.HardwareAddr)"},{"line_number":247,"context_line":"\t}"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"\treturn \u0026Client{"}],"source_content_type":"text/x-go","patch_set":1,"id":"a5966d97_43bee2c6","line":246,"range":{"start_line":246,"start_character":72,"end_line":246,"end_character":86},"in_reply_to":"d36aa04e_75ce73c1","updated":"2024-05-28 11:12:39.000000000","message":"We\u0027re checking that it\u0027s not zero-length. This is not really an attempt at full validation (that would require interrogating the interface to check what L2 protocol is being talked and having per-protocol MAC verification). I only added this to catch attempts at sending out empty client MAC addresses without looking at network packet traces.","commit_id":"37a3227acb42a8533e1b75a6d9455611a0b66197"}]}