)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1000000,"name":"Leopold Schabel","display_name":"Leo","email":"leo@monogon.tech","username":"leo","avatars":[{"url":"https://www.gravatar.com/avatar/98f8f79a6bb45adef37defa7ead8f3d2.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/98f8f79a6bb45adef37defa7ead8f3d2.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/98f8f79a6bb45adef37defa7ead8f3d2.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/98f8f79a6bb45adef37defa7ead8f3d2.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"ea3b350d9a1fd667f517bb97633ee1b05ce3f9c3","unresolved":true,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Having the thing go through a test_suite and a native_test broke passing"},{"line_number":13,"context_line":"SIGINT and caused the emulated environments to continue running in the"},{"line_number":14,"context_line":"background forked off the server when the use exited via Ctrl-C."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"For some reason, running in tests also allowed us to do a weird hack in"},{"line_number":17,"context_line":"which we could resolve the TPM config directory as a runfile and list"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"b8b01103_c833ad52","line":14,"range":{"start_line":14,"start_character":42,"end_line":14,"end_character":45},"updated":"2024-05-24 22:35:30.000000000","message":"*user","commit_id":"6df3b97a26f035085383e14bf94b92972344c47e"},{"author":{"_account_id":1000002,"name":"Serge Bazanski","display_name":"Serge","email":"serge@monogon.tech","username":"serge","avatars":[{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"540ca2b6e700bf3a1a480370dbe20652fa825e65","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Having the thing go through a test_suite and a native_test broke passing"},{"line_number":13,"context_line":"SIGINT and caused the emulated environments to continue running in the"},{"line_number":14,"context_line":"background forked off the server when the use exited via Ctrl-C."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"For some reason, running in tests also allowed us to do a weird hack in"},{"line_number":17,"context_line":"which we could resolve the TPM config directory as a runfile and list"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"2208c7db_4f6b21f6","line":14,"range":{"start_line":14,"start_character":42,"end_line":14,"end_character":45},"in_reply_to":"b8b01103_c833ad52","updated":"2024-06-04 15:54:07.000000000","message":"Done","commit_id":"6df3b97a26f035085383e14bf94b92972344c47e"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":1000001,"name":"Lorenz Brun","display_name":"Lorenz","email":"lorenz@monogon.tech","username":"lorenz","avatars":[{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"d8da0836b1270557d48a4725d6025dc1d87c9407","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"24035192_26b7187d","updated":"2024-05-23 15:39:13.000000000","message":"I don\u0027t have strong opinions on this, for me both options work.","commit_id":"6df3b97a26f035085383e14bf94b92972344c47e"},{"author":{"_account_id":1000000,"name":"Leopold Schabel","display_name":"Leo","email":"leo@monogon.tech","username":"leo","avatars":[{"url":"https://www.gravatar.com/avatar/98f8f79a6bb45adef37defa7ead8f3d2.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/98f8f79a6bb45adef37defa7ead8f3d2.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/98f8f79a6bb45adef37defa7ead8f3d2.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/98f8f79a6bb45adef37defa7ead8f3d2.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"2a47ccb79fc27a2311e3fb9827e92472b4fee667","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f71e4457_612f4283","updated":"2024-05-23 09:41:43.000000000","message":"The reason this hack existed is because running it as a test allowed it to depend on swtpm in the sandboxroot: https://review.monogon.dev/c/monogon/+/1078\n\nRunning it with `bazel run` only works inside the Nix shell or after manually installing missing dependencies on the host. Which is fine, I guess?","commit_id":"6df3b97a26f035085383e14bf94b92972344c47e"},{"author":{"_account_id":1000002,"name":"Serge Bazanski","display_name":"Serge","email":"serge@monogon.tech","username":"serge","avatars":[{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"143e1e629fe9d1f947bcd6a7f8228e88f8d57c69","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f7366ca8_a60d58c3","in_reply_to":"40e276d5_2319b617","updated":"2024-05-28 10:17:36.000000000","message":"I\u0027ve already started to Bazelify swtpm so we\u0027ll have one less ambient dep very soon :).","commit_id":"6df3b97a26f035085383e14bf94b92972344c47e"},{"author":{"_account_id":1000000,"name":"Leopold Schabel","display_name":"Leo","email":"leo@monogon.tech","username":"leo","avatars":[{"url":"https://www.gravatar.com/avatar/98f8f79a6bb45adef37defa7ead8f3d2.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/98f8f79a6bb45adef37defa7ead8f3d2.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/98f8f79a6bb45adef37defa7ead8f3d2.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/98f8f79a6bb45adef37defa7ead8f3d2.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"ea3b350d9a1fd667f517bb97633ee1b05ce3f9c3","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"40e276d5_2319b617","in_reply_to":"f71e4457_612f4283","updated":"2024-05-24 22:35:30.000000000","message":"To be clear, not an objection, just pointing out the original rationale for adding it. It\u0027s an ugly hack for a number of reasons, and since the wrapper apparently interferes with \"bazel run\" usage, I\u0027m certainly in favor of merging this.\n\nLonger-term, we either need to remove the remaining ambient dependencies and make sure everything meant to run on the host is fully static, or make it a requirement to use the nix shell, I guess? The Bazel sandbox certainly wasn\u0027t meant for this.","commit_id":"6df3b97a26f035085383e14bf94b92972344c47e"},{"author":{"_account_id":1000000,"name":"Leopold Schabel","display_name":"Leo","email":"leo@monogon.tech","username":"leo","avatars":[{"url":"https://www.gravatar.com/avatar/98f8f79a6bb45adef37defa7ead8f3d2.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/98f8f79a6bb45adef37defa7ead8f3d2.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/98f8f79a6bb45adef37defa7ead8f3d2.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/98f8f79a6bb45adef37defa7ead8f3d2.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"c0fefa7f17f26e8244816abca3fba7a2bd319b15","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e9bd1ba1_bd9440e2","in_reply_to":"f7366ca8_a60d58c3","updated":"2024-05-28 10:26:39.000000000","message":"Ack","commit_id":"6df3b97a26f035085383e14bf94b92972344c47e"}]}