)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000038,"name":"Jan Schär","display_name":"Jan","email":"jan@monogon.tech","username":"jan","avatars":[{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"88a0ecdc9037a9e1a5169fd946b2a448f7c334e3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e806dad1_f0c7d50e","updated":"2024-05-14 16:07:04.000000000","message":"I saw that you disabled encryption for the core test in this change. So we have the following configurations now:\n\n- core: 2 nodes, insecure\n- kubernetes: 2 nodes, encryption + integrity\n- ha: 3 nodes, encryption + integrity\n- ha cold: 3 nodes, insecure\n\nI think we could disable integrity for the ha test to avoid the disk zeroing there, and as a bonus we would have the encryption without integrity case covered by a test. But that can also be done in a later change.","commit_id":"e1df45574b1a389380c672d6c47e87ba5ddc403b"}],"metropolis/test/e2e/suites/core/BUILD.bazel":[{"author":{"_account_id":1000038,"name":"Jan Schär","display_name":"Jan","email":"jan@monogon.tech","username":"jan","avatars":[{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"88a0ecdc9037a9e1a5169fd946b2a448f7c334e3","unresolved":true,"context_lines":[{"line_number":13,"context_line":"        \"resources:iops:5000\","},{"line_number":14,"context_line":"        \"resources:cpu:3\","},{"line_number":15,"context_line":"        # 3x2048 for nodes plus some extra."},{"line_number":16,"context_line":"        \"resources:ram:7000\","},{"line_number":17,"context_line":"    ],"},{"line_number":18,"context_line":"    deps \u003d ["},{"line_number":19,"context_line":"        \"//metropolis/node\","}],"source_content_type":"text/x-python","patch_set":2,"id":"218f17b7_adda2c6f","line":16,"updated":"2024-05-14 16:07:04.000000000","message":"The core and kubernetes tests launch 2 nodes, while the two ha tests launch 3 nodes. Is it intentional that all four tests have the same resource requirements specified, or should it be lowered for the 2 node tests?","commit_id":"e1df45574b1a389380c672d6c47e87ba5ddc403b"},{"author":{"_account_id":1000002,"name":"Serge Bazanski","display_name":"Serge","email":"serge@monogon.tech","username":"serge","avatars":[{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"8053af41f44f8586a63b981eb46c0d5ba53ce521","unresolved":false,"context_lines":[{"line_number":13,"context_line":"        \"resources:iops:5000\","},{"line_number":14,"context_line":"        \"resources:cpu:3\","},{"line_number":15,"context_line":"        # 3x2048 for nodes plus some extra."},{"line_number":16,"context_line":"        \"resources:ram:7000\","},{"line_number":17,"context_line":"    ],"},{"line_number":18,"context_line":"    deps \u003d ["},{"line_number":19,"context_line":"        \"//metropolis/node\","}],"source_content_type":"text/x-python","patch_set":2,"id":"497311d2_bfc7b236","line":16,"in_reply_to":"218f17b7_adda2c6f","updated":"2024-05-15 09:27:34.000000000","message":"Done","commit_id":"e1df45574b1a389380c672d6c47e87ba5ddc403b"}]}