)]}'
{"metropolis/pkg/fsquota/fsxattrs/fsxattrs.go":[{"author":{"_account_id":1000002,"name":"Serge Bazanski","display_name":"Serge","email":"serge@monogon.tech","username":"serge","avatars":[{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"04aa2869df490b066d7bea8488d2477e68c1a689","unresolved":true,"context_lines":[{"line_number":46,"context_line":"\tFlagHasAttribute    FSXAttrFlag \u003d 0x80000000"},{"line_number":47,"context_line":")"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"// FS_IOC_FSGETXATTR and FS_IOC_FSSETXATTR are defined in uapi/linux/fs.h"},{"line_number":50,"context_line":"const ("},{"line_number":51,"context_line":"\tFS_IOC_FSGETXATTR \u003d 0x801c581f"},{"line_number":52,"context_line":"\tFS_IOC_FSSETXATTR \u003d 0x401c5820"}],"source_content_type":"text/x-go","patch_set":1,"id":"7b797a42_9d807d12","line":49,"range":{"start_line":49,"start_character":0,"end_line":49,"end_character":73},"updated":"2024-04-22 09:32:20.000000000","message":"If you\u0027re gonna export a docstring, make it actually explain something.","commit_id":"4d5e8112075ec751fe1c50993ad0ea736e596d08"},{"author":{"_account_id":1000019,"name":"Tim Windelschmidt","display_name":"Tim","email":"tim@monogon.tech","username":"fionera","avatars":[{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"e5841451d7cae837c5002a13dc7e3bcc3b584d68","unresolved":false,"context_lines":[{"line_number":46,"context_line":"\tFlagHasAttribute    FSXAttrFlag \u003d 0x80000000"},{"line_number":47,"context_line":")"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"// FS_IOC_FSGETXATTR and FS_IOC_FSSETXATTR are defined in uapi/linux/fs.h"},{"line_number":50,"context_line":"const ("},{"line_number":51,"context_line":"\tFS_IOC_FSGETXATTR \u003d 0x801c581f"},{"line_number":52,"context_line":"\tFS_IOC_FSSETXATTR \u003d 0x401c5820"}],"source_content_type":"text/x-go","patch_set":1,"id":"bd0166bd_9f8ba0cb","line":49,"range":{"start_line":49,"start_character":0,"end_line":49,"end_character":73},"in_reply_to":"7b797a42_9d807d12","updated":"2024-04-22 15:39:43.000000000","message":"Done","commit_id":"4d5e8112075ec751fe1c50993ad0ea736e596d08"}],"metropolis/pkg/smbios/structures.go":[{"author":{"_account_id":1000002,"name":"Serge Bazanski","display_name":"Serge","email":"serge@monogon.tech","username":"serge","avatars":[{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"04aa2869df490b066d7bea8488d2477e68c1a689","unresolved":true,"context_lines":[{"line_number":12,"context_line":"\tstructTypeMemoryDevice         \u003d 17"},{"line_number":13,"context_line":")"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"// UEFISpecificationSupported see Table 7.1.2.2 Bit 3"},{"line_number":16,"context_line":"const UEFISpecificationSupported \u003d 1 \u003c\u003c 3"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"// BIOSInformationRaw contains decoded data from the BIOS Information structure"}],"source_content_type":"text/x-go","patch_set":1,"id":"373f9c2f_2353393b","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":53},"updated":"2024-04-22 09:32:20.000000000","message":"Same - if you\u0027re gonna export a docstring, make it actually explain something.","commit_id":"4d5e8112075ec751fe1c50993ad0ea736e596d08"},{"author":{"_account_id":1000019,"name":"Tim Windelschmidt","display_name":"Tim","email":"tim@monogon.tech","username":"fionera","avatars":[{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"e5841451d7cae837c5002a13dc7e3bcc3b584d68","unresolved":false,"context_lines":[{"line_number":12,"context_line":"\tstructTypeMemoryDevice         \u003d 17"},{"line_number":13,"context_line":")"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"// UEFISpecificationSupported see Table 7.1.2.2 Bit 3"},{"line_number":16,"context_line":"const UEFISpecificationSupported \u003d 1 \u003c\u003c 3"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"// BIOSInformationRaw contains decoded data from the BIOS Information structure"}],"source_content_type":"text/x-go","patch_set":1,"id":"fe2b7d4e_1c020905","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":53},"in_reply_to":"373f9c2f_2353393b","updated":"2024-04-22 15:39:43.000000000","message":"Done","commit_id":"4d5e8112075ec751fe1c50993ad0ea736e596d08"}],"metropolis/test/nanoswitch/socks.go":[{"author":{"_account_id":1000002,"name":"Serge Bazanski","display_name":"Serge","email":"serge@monogon.tech","username":"serge","avatars":[{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"04aa2869df490b066d7bea8488d2477e68c1a689","unresolved":true,"context_lines":[{"line_number":9,"context_line":"\t\"source.monogon.dev/metropolis/pkg/supervisor\""},{"line_number":10,"context_line":")"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"// SOCKSPort must be kept in sync"},{"line_number":13,"context_line":"// ONCHANGE(//metropolis/test/launch/cluster:cluster.go)"},{"line_number":14,"context_line":"const SOCKSPort uint16 \u003d 1080"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"// socksHandler implements a socksproxy.Handler which permits and logs"}],"source_content_type":"text/x-go","patch_set":1,"id":"6ea435a8_8e559d65","line":13,"range":{"start_line":12,"start_character":0,"end_line":13,"end_character":56},"updated":"2024-04-22 09:32:20.000000000","message":"Keep as is. The idea is to have `ONCHANGE(foo): reason`, same as `TODO(foo): explanation`, without making that a docstring.","commit_id":"4d5e8112075ec751fe1c50993ad0ea736e596d08"},{"author":{"_account_id":1000002,"name":"Serge Bazanski","display_name":"Serge","email":"serge@monogon.tech","username":"serge","avatars":[{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"b46577a7b8859b3c4748767eb3b69359fd789a10","unresolved":true,"context_lines":[{"line_number":9,"context_line":"\t\"source.monogon.dev/metropolis/pkg/supervisor\""},{"line_number":10,"context_line":")"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"// SOCKSPort must be kept in sync"},{"line_number":13,"context_line":"// ONCHANGE(//metropolis/test/launch/cluster:cluster.go)"},{"line_number":14,"context_line":"const SOCKSPort uint16 \u003d 1080"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"// socksHandler implements a socksproxy.Handler which permits and logs"}],"source_content_type":"text/x-go","patch_set":1,"id":"c7c02359_1e36cbc4","line":13,"range":{"start_line":12,"start_character":0,"end_line":13,"end_character":56},"in_reply_to":"6164d0e6_b2118500","updated":"2024-04-22 11:11:26.000000000","message":"how about\n```\n// SOCKSPort is the port at which nanoswitch listens for SOCKS conenctions.\n//\n// ONCHANGE(//metropolis/test/launch/cluster:cluster.go): port must be kept in sync\n```","commit_id":"4d5e8112075ec751fe1c50993ad0ea736e596d08"},{"author":{"_account_id":1000019,"name":"Tim Windelschmidt","display_name":"Tim","email":"tim@monogon.tech","username":"fionera","avatars":[{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"384788412e681e956670c80a1070f51a666f30f4","unresolved":true,"context_lines":[{"line_number":9,"context_line":"\t\"source.monogon.dev/metropolis/pkg/supervisor\""},{"line_number":10,"context_line":")"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"// SOCKSPort must be kept in sync"},{"line_number":13,"context_line":"// ONCHANGE(//metropolis/test/launch/cluster:cluster.go)"},{"line_number":14,"context_line":"const SOCKSPort uint16 \u003d 1080"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"// socksHandler implements a socksproxy.Handler which permits and logs"}],"source_content_type":"text/x-go","patch_set":1,"id":"6164d0e6_b2118500","line":13,"range":{"start_line":12,"start_character":0,"end_line":13,"end_character":56},"in_reply_to":"6ea435a8_8e559d65","updated":"2024-04-22 10:53:24.000000000","message":"I can\u0027t exclude just a single line from a check which is why I made moved it into a second line. A nolint pragma would also be weird here. Only solution would be to disable this check","commit_id":"4d5e8112075ec751fe1c50993ad0ea736e596d08"},{"author":{"_account_id":1000019,"name":"Tim Windelschmidt","display_name":"Tim","email":"tim@monogon.tech","username":"fionera","avatars":[{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"78e712a6b64733a213f635d1f2e9bd14bea03d75","unresolved":false,"context_lines":[{"line_number":9,"context_line":"\t\"source.monogon.dev/metropolis/pkg/supervisor\""},{"line_number":10,"context_line":")"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"// SOCKSPort must be kept in sync"},{"line_number":13,"context_line":"// ONCHANGE(//metropolis/test/launch/cluster:cluster.go)"},{"line_number":14,"context_line":"const SOCKSPort uint16 \u003d 1080"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"// socksHandler implements a socksproxy.Handler which permits and logs"}],"source_content_type":"text/x-go","patch_set":1,"id":"51a93161_a4f88be8","line":13,"range":{"start_line":12,"start_character":0,"end_line":13,"end_character":56},"in_reply_to":"c7c02359_1e36cbc4","updated":"2024-04-22 15:39:22.000000000","message":"Done","commit_id":"4d5e8112075ec751fe1c50993ad0ea736e596d08"}]}