)]}'
{"cloud/agent/install.go":[{"author":{"_account_id":1000002,"name":"Serge Bazanski","display_name":"Serge","email":"serge@monogon.tech","username":"serge","avatars":[{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"ab4ab35dfba8cb2406cd49374bfc3b6024bb6160","unresolved":true,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"func installMetropolis(req *bpb.MetropolisInstallationRequest, netConfig *npb.Net, l logtree.LeveledLogger, isEFIBoot bool) error {"},{"line_number":54,"context_line":"\tif !isEFIBoot {"},{"line_number":55,"context_line":"\t\treturn errors.New(\"Monogon-OS can only be installed on EFI-booted machines, this one is not\")"},{"line_number":56,"context_line":"\t}"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"\t// Override the NodeParameters.NetworkConfig with the current NetworkConfig"}],"source_content_type":"text/x-go","patch_set":1,"id":"5020d7ac_d4184356","line":55,"range":{"start_line":55,"start_character":28,"end_line":55,"end_character":29},"updated":"2024-04-22 09:29:09.000000000","message":"Why? I though we call it \u0027Monogon OS\u0027, not \u0027Monogon-OS\u0027.","commit_id":"cf65a8a49b4a9c1fcabdb279be9c0863bedc5380"},{"author":{"_account_id":1000019,"name":"Tim Windelschmidt","display_name":"Tim","email":"tim@monogon.tech","username":"fionera","avatars":[{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"f090a8caeecada4a7410f9888dddcd21ffd7f45e","unresolved":true,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"func installMetropolis(req *bpb.MetropolisInstallationRequest, netConfig *npb.Net, l logtree.LeveledLogger, isEFIBoot bool) error {"},{"line_number":54,"context_line":"\tif !isEFIBoot {"},{"line_number":55,"context_line":"\t\treturn errors.New(\"Monogon-OS can only be installed on EFI-booted machines, this one is not\")"},{"line_number":56,"context_line":"\t}"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"\t// Override the NodeParameters.NetworkConfig with the current NetworkConfig"}],"source_content_type":"text/x-go","patch_set":1,"id":"c7406c9a_29f60793","line":55,"range":{"start_line":55,"start_character":28,"end_line":55,"end_character":29},"in_reply_to":"5020d7ac_d4184356","updated":"2024-04-22 10:57:36.000000000","message":"I couldn\u0027t find any way of getting staticcheck to not complain about this. I would just rephrase the sentence to make it start with a lower case letter","commit_id":"cf65a8a49b4a9c1fcabdb279be9c0863bedc5380"},{"author":{"_account_id":1000002,"name":"Serge Bazanski","display_name":"Serge","email":"serge@monogon.tech","username":"serge","avatars":[{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"92256469a23694869fa0fb949a17a3d1eb7994a3","unresolved":true,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"func installMetropolis(req *bpb.MetropolisInstallationRequest, netConfig *npb.Net, l logtree.LeveledLogger, isEFIBoot bool) error {"},{"line_number":54,"context_line":"\tif !isEFIBoot {"},{"line_number":55,"context_line":"\t\treturn errors.New(\"Monogon-OS can only be installed on EFI-booted machines, this one is not\")"},{"line_number":56,"context_line":"\t}"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"\t// Override the NodeParameters.NetworkConfig with the current NetworkConfig"}],"source_content_type":"text/x-go","patch_set":1,"id":"f75dc790_1347618c","line":55,"range":{"start_line":55,"start_character":28,"end_line":55,"end_character":29},"in_reply_to":"c7406c9a_29f60793","updated":"2024-04-22 11:06:14.000000000","message":"Please just add a no-lint guard instead. We should be fine using that escape hatch in some circumstances.","commit_id":"cf65a8a49b4a9c1fcabdb279be9c0863bedc5380"},{"author":{"_account_id":1000019,"name":"Tim Windelschmidt","display_name":"Tim","email":"tim@monogon.tech","username":"fionera","avatars":[{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"e257e8f4c63c158b2268e49b080a138b470adac1","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"func installMetropolis(req *bpb.MetropolisInstallationRequest, netConfig *npb.Net, l logtree.LeveledLogger, isEFIBoot bool) error {"},{"line_number":54,"context_line":"\tif !isEFIBoot {"},{"line_number":55,"context_line":"\t\treturn errors.New(\"Monogon-OS can only be installed on EFI-booted machines, this one is not\")"},{"line_number":56,"context_line":"\t}"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"\t// Override the NodeParameters.NetworkConfig with the current NetworkConfig"}],"source_content_type":"text/x-go","patch_set":1,"id":"458b4a18_16add3f6","line":55,"range":{"start_line":55,"start_character":28,"end_line":55,"end_character":29},"in_reply_to":"f75dc790_1347618c","updated":"2024-04-22 15:39:22.000000000","message":"Done","commit_id":"cf65a8a49b4a9c1fcabdb279be9c0863bedc5380"}],"metropolis/node/core/metrics/metrics.go":[{"author":{"_account_id":1000002,"name":"Serge Bazanski","display_name":"Serge","email":"serge@monogon.tech","username":"serge","avatars":[{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"ab4ab35dfba8cb2406cd49374bfc3b6024bb6160","unresolved":true,"context_lines":[{"line_number":140,"context_line":"\tif err !\u003d nil \u0026\u0026 ctx.Err() !\u003d nil {"},{"line_number":141,"context_line":"\t\treturn ctx.Err()"},{"line_number":142,"context_line":"\t}"},{"line_number":143,"context_line":"\treturn fmt.Errorf(\"serve: %w\", err)"},{"line_number":144,"context_line":"}"}],"source_content_type":"text/x-go","patch_set":1,"id":"a2109b3a_76468507","line":143,"range":{"start_line":143,"start_character":20,"end_line":143,"end_character":21},"updated":"2024-04-22 09:29:09.000000000","message":"That\u0027s the name of a function, keep as is.","commit_id":"cf65a8a49b4a9c1fcabdb279be9c0863bedc5380"},{"author":{"_account_id":1000019,"name":"Tim Windelschmidt","display_name":"Tim","email":"tim@monogon.tech","username":"fionera","avatars":[{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"16d841752482f17d301e538803b4bec5b56b7347","unresolved":false,"context_lines":[{"line_number":140,"context_line":"\tif err !\u003d nil \u0026\u0026 ctx.Err() !\u003d nil {"},{"line_number":141,"context_line":"\t\treturn ctx.Err()"},{"line_number":142,"context_line":"\t}"},{"line_number":143,"context_line":"\treturn fmt.Errorf(\"serve: %w\", err)"},{"line_number":144,"context_line":"}"}],"source_content_type":"text/x-go","patch_set":1,"id":"0bfc99a2_b9134f3a","line":143,"range":{"start_line":143,"start_character":20,"end_line":143,"end_character":21},"in_reply_to":"a2109b3a_76468507","updated":"2024-04-22 10:56:19.000000000","message":"Fixing in the next revision, have to change it to Serve() to let staticcheck also understand that this contains the function name: https://github.com/dominikh/go-tools/commit/a4a005d19a6cc388305c8640276d4379673b5337","commit_id":"cf65a8a49b4a9c1fcabdb279be9c0863bedc5380"}],"metropolis/node/core/roleserve/worker_heartbeat.go":[{"author":{"_account_id":1000002,"name":"Serge Bazanski","display_name":"Serge","email":"serge@monogon.tech","username":"serge","avatars":[{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"ab4ab35dfba8cb2406cd49374bfc3b6024bb6160","unresolved":true,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"\t\t_, err :\u003d stream.Recv()"},{"line_number":51,"context_line":"\t\tif err \u003d\u003d io.EOF {"},{"line_number":52,"context_line":"\t\t\treturn fmt.Errorf(\"stream closed by the server. restarting worker... \")"},{"line_number":53,"context_line":"\t\t}"},{"line_number":54,"context_line":"\t\tif err !\u003d nil {"},{"line_number":55,"context_line":"\t\t\treturn fmt.Errorf(\"while receiving a heartbeat reply: %w\", err)"}],"source_content_type":"text/x-go","patch_set":1,"id":"8e2c3299_efdd56d7","line":52,"range":{"start_line":52,"start_character":51,"end_line":52,"end_character":52},"updated":"2024-04-22 09:29:09.000000000","message":"`by the server, restarting worker...`","commit_id":"cf65a8a49b4a9c1fcabdb279be9c0863bedc5380"},{"author":{"_account_id":1000019,"name":"Tim Windelschmidt","display_name":"Tim","email":"tim@monogon.tech","username":"fionera","avatars":[{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"e257e8f4c63c158b2268e49b080a138b470adac1","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"\t\t_, err :\u003d stream.Recv()"},{"line_number":51,"context_line":"\t\tif err \u003d\u003d io.EOF {"},{"line_number":52,"context_line":"\t\t\treturn fmt.Errorf(\"stream closed by the server. restarting worker... \")"},{"line_number":53,"context_line":"\t\t}"},{"line_number":54,"context_line":"\t\tif err !\u003d nil {"},{"line_number":55,"context_line":"\t\t\treturn fmt.Errorf(\"while receiving a heartbeat reply: %w\", err)"}],"source_content_type":"text/x-go","patch_set":1,"id":"9b0b4720_a154e7cb","line":52,"range":{"start_line":52,"start_character":51,"end_line":52,"end_character":52},"in_reply_to":"8e2c3299_efdd56d7","updated":"2024-04-22 15:39:22.000000000","message":"Done","commit_id":"cf65a8a49b4a9c1fcabdb279be9c0863bedc5380"}],"third_party/sandboxroot/mirror/external.go":[{"author":{"_account_id":1000002,"name":"Serge Bazanski","display_name":"Serge","email":"serge@monogon.tech","username":"serge","avatars":[{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"ab4ab35dfba8cb2406cd49374bfc3b6024bb6160","unresolved":true,"context_lines":[{"line_number":186,"context_line":"\t\tlog.Printf(\"  Uploading to %s...\", objName)"},{"line_number":187,"context_line":"\t\twr :\u003d obj.NewWriter(ctx)"},{"line_number":188,"context_line":"\t\tif _, err :\u003d wr.Write(data); err !\u003d nil {"},{"line_number":189,"context_line":"\t\t\treturn fmt.Errorf(\"write failed: %w\", err)"},{"line_number":190,"context_line":"\t\t}"},{"line_number":191,"context_line":"\t\tif err :\u003d wr.Close(); err !\u003d nil {"},{"line_number":192,"context_line":"\t\t\treturn fmt.Errorf(\"close failed: %w\", err)"}],"source_content_type":"text/x-go","patch_set":1,"id":"3f0857a7_82541125","line":189,"range":{"start_line":189,"start_character":22,"end_line":189,"end_character":23},"updated":"2024-04-22 09:29:09.000000000","message":"Function name.","commit_id":"cf65a8a49b4a9c1fcabdb279be9c0863bedc5380"},{"author":{"_account_id":1000019,"name":"Tim Windelschmidt","display_name":"Tim","email":"tim@monogon.tech","username":"fionera","avatars":[{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"e257e8f4c63c158b2268e49b080a138b470adac1","unresolved":false,"context_lines":[{"line_number":186,"context_line":"\t\tlog.Printf(\"  Uploading to %s...\", objName)"},{"line_number":187,"context_line":"\t\twr :\u003d obj.NewWriter(ctx)"},{"line_number":188,"context_line":"\t\tif _, err :\u003d wr.Write(data); err !\u003d nil {"},{"line_number":189,"context_line":"\t\t\treturn fmt.Errorf(\"write failed: %w\", err)"},{"line_number":190,"context_line":"\t\t}"},{"line_number":191,"context_line":"\t\tif err :\u003d wr.Close(); err !\u003d nil {"},{"line_number":192,"context_line":"\t\t\treturn fmt.Errorf(\"close failed: %w\", err)"}],"source_content_type":"text/x-go","patch_set":1,"id":"492a1b9c_b00de2fa","line":189,"range":{"start_line":189,"start_character":22,"end_line":189,"end_character":23},"in_reply_to":"3f0857a7_82541125","updated":"2024-04-22 15:39:22.000000000","message":"Done","commit_id":"cf65a8a49b4a9c1fcabdb279be9c0863bedc5380"},{"author":{"_account_id":1000002,"name":"Serge Bazanski","display_name":"Serge","email":"serge@monogon.tech","username":"serge","avatars":[{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"ab4ab35dfba8cb2406cd49374bfc3b6024bb6160","unresolved":true,"context_lines":[{"line_number":189,"context_line":"\t\t\treturn fmt.Errorf(\"write failed: %w\", err)"},{"line_number":190,"context_line":"\t\t}"},{"line_number":191,"context_line":"\t\tif err :\u003d wr.Close(); err !\u003d nil {"},{"line_number":192,"context_line":"\t\t\treturn fmt.Errorf(\"close failed: %w\", err)"},{"line_number":193,"context_line":"\t\t}"},{"line_number":194,"context_line":"\t\treturn nil"},{"line_number":195,"context_line":"\t}"}],"source_content_type":"text/x-go","patch_set":1,"id":"518a657e_06a084bb","line":192,"range":{"start_line":192,"start_character":22,"end_line":192,"end_character":23},"updated":"2024-04-22 09:29:09.000000000","message":"Function name.","commit_id":"cf65a8a49b4a9c1fcabdb279be9c0863bedc5380"},{"author":{"_account_id":1000019,"name":"Tim Windelschmidt","display_name":"Tim","email":"tim@monogon.tech","username":"fionera","avatars":[{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"e257e8f4c63c158b2268e49b080a138b470adac1","unresolved":false,"context_lines":[{"line_number":189,"context_line":"\t\t\treturn fmt.Errorf(\"write failed: %w\", err)"},{"line_number":190,"context_line":"\t\t}"},{"line_number":191,"context_line":"\t\tif err :\u003d wr.Close(); err !\u003d nil {"},{"line_number":192,"context_line":"\t\t\treturn fmt.Errorf(\"close failed: %w\", err)"},{"line_number":193,"context_line":"\t\t}"},{"line_number":194,"context_line":"\t\treturn nil"},{"line_number":195,"context_line":"\t}"}],"source_content_type":"text/x-go","patch_set":1,"id":"ac98a2ef_0607c3e1","line":192,"range":{"start_line":192,"start_character":22,"end_line":192,"end_character":23},"in_reply_to":"518a657e_06a084bb","updated":"2024-04-22 15:39:22.000000000","message":"Done","commit_id":"cf65a8a49b4a9c1fcabdb279be9c0863bedc5380"}]}