)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000038,"name":"Jan Schär","display_name":"Jan","email":"jan@monogon.tech","username":"jan","avatars":[{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/fd0e7f48847aa0e46c8f361df2d6c26b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"1750c96d5035d7b582f01074f7c8378ded606147","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"d4bde194_14616f97","updated":"2024-04-09 16:03:34.000000000","message":"I think the way the code sets `fatal` doesn\u0027t quite make sense. Whether or not test failure should be fatal is a property of the subtest, not of the error. For example, if the test times out, it should still be considered fatal.\n\nMy suggestion would be to do something like this (where `TestEventual` returns the result of `t.Run`) instead of `FatalError`:\n\n```go\nfunc MustTestEventual(t *testing.T, name string, ctx context.Context, timeout time.Duration, f func(context.Context) error) {\n  if !TestEventual(t, name, ctx, timeout, f) {\n    t.Fatalf(\"%s: failed\", name)\n  }\n}\n```","commit_id":"5c1fb6b74e5c837ee866c783c6dcb7e1556ef859"},{"author":{"_account_id":1000002,"name":"Serge Bazanski","display_name":"Serge","email":"serge@monogon.tech","username":"serge","avatars":[{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"958f9d07e680ce2e9350e55cc9c1f96bbe8712eb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"8fe27876_db6d3d7b","in_reply_to":"d4bde194_14616f97","updated":"2024-04-11 12:58:16.000000000","message":"Yeah, makes sense! Fixed.","commit_id":"5c1fb6b74e5c837ee866c783c6dcb7e1556ef859"}]}