)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000001,"name":"Lorenz Brun","display_name":"Lorenz","email":"lorenz@monogon.tech","username":"lorenz","avatars":[{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"cebc74eb62a17fbe0b08709c40682858fc210eed","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"5ad3e8ed_5e6c0121","updated":"2024-04-09 11:41:40.000000000","message":"From a logic perspective this looks fine now, but it is obviously very time-sensitive, especially on the first iteration. I\u0027d go with this for now as it is definitely an improvement over the status quo, but IMO we should probably switch to something like systemd\u0027s boot IDs for this eventually.","commit_id":"6342dc04330144307a0dc32dda5357438a2a294c"},{"author":{"_account_id":1000002,"name":"Serge Bazanski","display_name":"Serge","email":"serge@monogon.tech","username":"serge","avatars":[{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"1cbf5aa903dae3b1a960fd2a200130a0c0ab8bfc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"a4571e09_e45c5a0c","in_reply_to":"5ad3e8ed_5e6c0121","updated":"2024-04-11 12:46:34.000000000","message":"Agreed.","commit_id":"6342dc04330144307a0dc32dda5357438a2a294c"}],"metropolis/test/launch/cluster/cluster.go":[{"author":{"_account_id":1000001,"name":"Lorenz Brun","display_name":"Lorenz","email":"lorenz@monogon.tech","username":"lorenz","avatars":[{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"b00a5297e61fd6deda45a43b03846c4693b386e2","unresolved":true,"context_lines":[{"line_number":1092,"context_line":"\t\t}"},{"line_number":1093,"context_line":"\t\tlaunch.Log(\"Cluster: node health: %+v\", cs.Health)"},{"line_number":1094,"context_line":""},{"line_number":1095,"context_line":"\t\tlhb :\u003d time.Now().Add(cs.TimeSinceHeartbeat.AsDuration())"},{"line_number":1096,"context_line":"\t\tif lhb.After(start) \u0026\u0026 cs.Health \u003d\u003d apb.Node_HEALTHY {"},{"line_number":1097,"context_line":"\t\t\tbreak"},{"line_number":1098,"context_line":"\t\t}"},{"line_number":1099,"context_line":"\t\ttime.Sleep(time.Second)"},{"line_number":1100,"context_line":"\t}"}],"source_content_type":"text/x-go","patch_set":5,"id":"61b73504_38b1ef0c","line":1097,"range":{"start_line":1095,"start_character":0,"end_line":1097,"end_character":0},"updated":"2024-03-21 15:00:07.000000000","message":"This looks suspicious as it will evaluate to true for any TimeSinceHeartbeat \u003e 0 during the initial iteration where time.Now() \u003d\u003d start.","commit_id":"71b81f1787bf352199c013262a6b6f6bd50fd10f"},{"author":{"_account_id":1000002,"name":"Serge Bazanski","display_name":"Serge","email":"serge@monogon.tech","username":"serge","avatars":[{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"92a6722a8053b13d84132211f576cdf75631e25e","unresolved":false,"context_lines":[{"line_number":1092,"context_line":"\t\t}"},{"line_number":1093,"context_line":"\t\tlaunch.Log(\"Cluster: node health: %+v\", cs.Health)"},{"line_number":1094,"context_line":""},{"line_number":1095,"context_line":"\t\tlhb :\u003d time.Now().Add(cs.TimeSinceHeartbeat.AsDuration())"},{"line_number":1096,"context_line":"\t\tif lhb.After(start) \u0026\u0026 cs.Health \u003d\u003d apb.Node_HEALTHY {"},{"line_number":1097,"context_line":"\t\t\tbreak"},{"line_number":1098,"context_line":"\t\t}"},{"line_number":1099,"context_line":"\t\ttime.Sleep(time.Second)"},{"line_number":1100,"context_line":"\t}"}],"source_content_type":"text/x-go","patch_set":5,"id":"bef42fb9_95753a22","line":1097,"range":{"start_line":1095,"start_character":0,"end_line":1097,"end_character":0},"in_reply_to":"61b73504_38b1ef0c","updated":"2024-04-09 10:52:01.000000000","message":"Ah right, we need to subtract here, not add.","commit_id":"71b81f1787bf352199c013262a6b6f6bd50fd10f"},{"author":{"_account_id":1000001,"name":"Lorenz Brun","display_name":"Lorenz","email":"lorenz@monogon.tech","username":"lorenz","avatars":[{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"cebc74eb62a17fbe0b08709c40682858fc210eed","unresolved":true,"context_lines":[{"line_number":1092,"context_line":"\t\t}"},{"line_number":1093,"context_line":"\t\tlaunch.Log(\"Cluster: node health: %+v\", cs.Health)"},{"line_number":1094,"context_line":""},{"line_number":1095,"context_line":"\t\tlhb :\u003d time.Now().Add(cs.TimeSinceHeartbeat.AsDuration() * -1)"},{"line_number":1096,"context_line":"\t\tif lhb.After(start) \u0026\u0026 cs.Health \u003d\u003d apb.Node_HEALTHY {"},{"line_number":1097,"context_line":"\t\t\tbreak"},{"line_number":1098,"context_line":"\t\t}"}],"source_content_type":"text/x-go","patch_set":7,"id":"5a04daaf_ecaec5a7","line":1095,"range":{"start_line":1095,"start_character":59,"end_line":1095,"end_character":63},"updated":"2024-04-09 11:41:40.000000000","message":"It should be possible to just put a - in front of the AsDuration expression, right?","commit_id":"6342dc04330144307a0dc32dda5357438a2a294c"},{"author":{"_account_id":1000002,"name":"Serge Bazanski","display_name":"Serge","email":"serge@monogon.tech","username":"serge","avatars":[{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"1cbf5aa903dae3b1a960fd2a200130a0c0ab8bfc","unresolved":false,"context_lines":[{"line_number":1092,"context_line":"\t\t}"},{"line_number":1093,"context_line":"\t\tlaunch.Log(\"Cluster: node health: %+v\", cs.Health)"},{"line_number":1094,"context_line":""},{"line_number":1095,"context_line":"\t\tlhb :\u003d time.Now().Add(cs.TimeSinceHeartbeat.AsDuration() * -1)"},{"line_number":1096,"context_line":"\t\tif lhb.After(start) \u0026\u0026 cs.Health \u003d\u003d apb.Node_HEALTHY {"},{"line_number":1097,"context_line":"\t\t\tbreak"},{"line_number":1098,"context_line":"\t\t}"}],"source_content_type":"text/x-go","patch_set":7,"id":"55b9a1a4_263b39e4","line":1095,"range":{"start_line":1095,"start_character":59,"end_line":1095,"end_character":63},"in_reply_to":"5a04daaf_ecaec5a7","updated":"2024-04-11 12:46:34.000000000","message":"If you insist.","commit_id":"6342dc04330144307a0dc32dda5357438a2a294c"}]}