)]}'
{"metropolis/node/core/pstore.go":[{"author":{"_account_id":1000002,"name":"Serge Bazanski","display_name":"Serge","email":"serge@monogon.tech","username":"serge","avatars":[{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"2af868c45c370c3e44dd9543e7eaa90649457883","unresolved":true,"context_lines":[{"line_number":25,"context_line":"\t}"},{"line_number":26,"context_line":"\tuserspaceLines, err :\u003d pstore.GetPmsgDump()"},{"line_number":27,"context_line":"\tif err !\u003d nil {"},{"line_number":28,"context_line":"\t\tlogger.Errorf(\"Failed to recover userspace logs from pstore: %v\", err)"},{"line_number":29,"context_line":"\t}"},{"line_number":30,"context_line":"\tfor _, line :\u003d range userspaceLines {"},{"line_number":31,"context_line":"\t\tlogger.Warning(line)"}],"source_content_type":"text/x-go","patch_set":1,"id":"89dc1bbd_e04a7e9d","line":28,"range":{"start_line":28,"start_character":2,"end_line":28,"end_character":72},"updated":"2024-02-12 15:39:36.000000000","message":"Does this distinguish between \u0027no logs\u0027 and \u0027cannot open logs\u0027? As in, how often are we gonna get this error message during boot? If often, it should at least be a Warning. Ideally, we would be able to distinguish expected from unexpected states here.","commit_id":"b5b409c35517fc6cd2ee3034ae46cd23092eda44"},{"author":{"_account_id":1000002,"name":"Serge Bazanski","display_name":"Serge","email":"serge@monogon.tech","username":"serge","avatars":[{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"0b639954182ed87bea02343cd178ada828326f3c","unresolved":false,"context_lines":[{"line_number":25,"context_line":"\t}"},{"line_number":26,"context_line":"\tuserspaceLines, err :\u003d pstore.GetPmsgDump()"},{"line_number":27,"context_line":"\tif err !\u003d nil {"},{"line_number":28,"context_line":"\t\tlogger.Errorf(\"Failed to recover userspace logs from pstore: %v\", err)"},{"line_number":29,"context_line":"\t}"},{"line_number":30,"context_line":"\tfor _, line :\u003d range userspaceLines {"},{"line_number":31,"context_line":"\t\tlogger.Warning(line)"}],"source_content_type":"text/x-go","patch_set":1,"id":"e0af3af4_7b70d5c1","line":28,"range":{"start_line":28,"start_character":2,"end_line":28,"end_character":72},"in_reply_to":"54076837_17eeeebb","updated":"2024-02-12 16:29:02.000000000","message":"Acknowledged","commit_id":"b5b409c35517fc6cd2ee3034ae46cd23092eda44"},{"author":{"_account_id":1000001,"name":"Lorenz Brun","display_name":"Lorenz","email":"lorenz@monogon.tech","username":"lorenz","avatars":[{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"43d2bdf38e55453f1c93286e24eb63379db3e6bd","unresolved":true,"context_lines":[{"line_number":25,"context_line":"\t}"},{"line_number":26,"context_line":"\tuserspaceLines, err :\u003d pstore.GetPmsgDump()"},{"line_number":27,"context_line":"\tif err !\u003d nil {"},{"line_number":28,"context_line":"\t\tlogger.Errorf(\"Failed to recover userspace logs from pstore: %v\", err)"},{"line_number":29,"context_line":"\t}"},{"line_number":30,"context_line":"\tfor _, line :\u003d range userspaceLines {"},{"line_number":31,"context_line":"\t\tlogger.Warning(line)"}],"source_content_type":"text/x-go","patch_set":1,"id":"54076837_17eeeebb","line":28,"range":{"start_line":28,"start_character":2,"end_line":28,"end_character":72},"in_reply_to":"89dc1bbd_e04a7e9d","updated":"2024-02-12 15:48:01.000000000","message":"Yes, no logs will return an empty lines slice and no error. This should really not happen as it indicates some platform issue.","commit_id":"b5b409c35517fc6cd2ee3034ae46cd23092eda44"},{"author":{"_account_id":1000002,"name":"Serge Bazanski","display_name":"Serge","email":"serge@monogon.tech","username":"serge","avatars":[{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"2af868c45c370c3e44dd9543e7eaa90649457883","unresolved":true,"context_lines":[{"line_number":28,"context_line":"\t\tlogger.Errorf(\"Failed to recover userspace logs from pstore: %v\", err)"},{"line_number":29,"context_line":"\t}"},{"line_number":30,"context_line":"\tfor _, line :\u003d range userspaceLines {"},{"line_number":31,"context_line":"\t\tlogger.Warning(line)"},{"line_number":32,"context_line":"\t}"},{"line_number":33,"context_line":"\tcleanErr :\u003d pstore.ClearAll()"},{"line_number":34,"context_line":"\tif cleanErr !\u003d nil {"}],"source_content_type":"text/x-go","patch_set":1,"id":"aefdbfbc_fdb3a6f6","line":31,"updated":"2024-02-12 15:39:36.000000000","message":"Doesn\u0027t this mean we will basically dump and entire pmsg\u0027s worth of old logs on every startup? Do we really wanna do that on every boot, vs. only doing that if there was an unexpected reboot?","commit_id":"b5b409c35517fc6cd2ee3034ae46cd23092eda44"},{"author":{"_account_id":1000002,"name":"Serge Bazanski","display_name":"Serge","email":"serge@monogon.tech","username":"serge","avatars":[{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"0b639954182ed87bea02343cd178ada828326f3c","unresolved":false,"context_lines":[{"line_number":28,"context_line":"\t\tlogger.Errorf(\"Failed to recover userspace logs from pstore: %v\", err)"},{"line_number":29,"context_line":"\t}"},{"line_number":30,"context_line":"\tfor _, line :\u003d range userspaceLines {"},{"line_number":31,"context_line":"\t\tlogger.Warning(line)"},{"line_number":32,"context_line":"\t}"},{"line_number":33,"context_line":"\tcleanErr :\u003d pstore.ClearAll()"},{"line_number":34,"context_line":"\tif cleanErr !\u003d nil {"}],"source_content_type":"text/x-go","patch_set":1,"id":"4017767c_b1d58991","line":31,"in_reply_to":"7c71b6e2_31a30aa8","updated":"2024-02-12 16:29:02.000000000","message":"Acknowledged","commit_id":"b5b409c35517fc6cd2ee3034ae46cd23092eda44"},{"author":{"_account_id":1000001,"name":"Lorenz Brun","display_name":"Lorenz","email":"lorenz@monogon.tech","username":"lorenz","avatars":[{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"43d2bdf38e55453f1c93286e24eb63379db3e6bd","unresolved":true,"context_lines":[{"line_number":28,"context_line":"\t\tlogger.Errorf(\"Failed to recover userspace logs from pstore: %v\", err)"},{"line_number":29,"context_line":"\t}"},{"line_number":30,"context_line":"\tfor _, line :\u003d range userspaceLines {"},{"line_number":31,"context_line":"\t\tlogger.Warning(line)"},{"line_number":32,"context_line":"\t}"},{"line_number":33,"context_line":"\tcleanErr :\u003d pstore.ClearAll()"},{"line_number":34,"context_line":"\tif cleanErr !\u003d nil {"}],"source_content_type":"text/x-go","patch_set":1,"id":"7c71b6e2_31a30aa8","line":31,"in_reply_to":"aefdbfbc_fdb3a6f6","updated":"2024-02-12 15:48:01.000000000","message":"We delete all of them on every boot, so this will only happen on the next reboot. pmsg will only contain critical events, the rest is not piped into it anyways.","commit_id":"b5b409c35517fc6cd2ee3034ae46cd23092eda44"}],"third_party/linux/external/enable-pmsg.patch":[{"author":{"_account_id":1000002,"name":"Serge Bazanski","display_name":"Serge","email":"serge@monogon.tech","username":"serge","avatars":[{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"2af868c45c370c3e44dd9543e7eaa90649457883","unresolved":true,"context_lines":[{"line_number":1,"context_line":"diff --git a/drivers/acpi/apei/erst.c b/drivers/acpi/apei/erst.c"},{"line_number":2,"context_line":"index bf65e3461531..fe2c331b4b99 100644"},{"line_number":3,"context_line":"--- a/drivers/acpi/apei/erst.c"},{"line_number":4,"context_line":"+++ b/drivers/acpi/apei/erst.c"}],"source_content_type":"text/x-diff","patch_set":1,"id":"c26da1b2_2abb527b","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":64},"updated":"2024-02-12 15:39:36.000000000","message":"Mention the reasoning for this patch inline, not just in the commit message.","commit_id":"b5b409c35517fc6cd2ee3034ae46cd23092eda44"},{"author":{"_account_id":1000001,"name":"Lorenz Brun","display_name":"Lorenz","email":"lorenz@monogon.tech","username":"lorenz","avatars":[{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"43d2bdf38e55453f1c93286e24eb63379db3e6bd","unresolved":false,"context_lines":[{"line_number":1,"context_line":"diff --git a/drivers/acpi/apei/erst.c b/drivers/acpi/apei/erst.c"},{"line_number":2,"context_line":"index bf65e3461531..fe2c331b4b99 100644"},{"line_number":3,"context_line":"--- a/drivers/acpi/apei/erst.c"},{"line_number":4,"context_line":"+++ b/drivers/acpi/apei/erst.c"}],"source_content_type":"text/x-diff","patch_set":1,"id":"dd162277_5d763ef5","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":64},"in_reply_to":"c26da1b2_2abb527b","updated":"2024-02-12 15:48:01.000000000","message":"Done","commit_id":"b5b409c35517fc6cd2ee3034ae46cd23092eda44"}]}