)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000001,"name":"Lorenz Brun","display_name":"Lorenz","email":"lorenz@monogon.tech","username":"lorenz","avatars":[{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"50c9652a6726fd41995fd5489f2a2d36739f3a31","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"20184864_def3c80b","updated":"2024-02-07 14:24:14.000000000","message":"Please provide reasoning in the commit description. Why do we need this?","commit_id":"5208094e2a6e324eafb8567b9d27be2382cfa76e"},{"author":{"_account_id":1000019,"name":"Tim Windelschmidt","display_name":"Tim","email":"tim@monogon.tech","username":"fionera","avatars":[{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"fa661d27dff06c4211637fe7f6285c72663cbc88","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"119278cb_caf010cd","in_reply_to":"20184864_def3c80b","updated":"2024-02-08 00:15:37.000000000","message":"Done","commit_id":"5208094e2a6e324eafb8567b9d27be2382cfa76e"}],"build/toolbase/gotoolchain/toolchain.go.in":[{"author":{"_account_id":1000002,"name":"Serge Bazanski","display_name":"Serge","email":"serge@monogon.tech","username":"serge","avatars":[{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"a3455fae3eee73257f53740656d56f6b98e17eca","unresolved":false,"context_lines":[{"line_number":11,"context_line":")"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"func mustRunfile(s string) string {"},{"line_number":14,"context_line":"\t// TODO(tim): I couldn\u0027t find out why there is a prefix."},{"line_number":15,"context_line":"\ts \u003d strings.TrimPrefix(s, \"external/\")"},{"line_number":16,"context_line":"\tres, err :\u003d runfiles.Rlocation(s)"},{"line_number":17,"context_line":"\tif err !\u003d nil {"}],"source_content_type":"text/x-properties","patch_set":2,"id":"89d5fc4d_3f686a6c","line":14,"range":{"start_line":14,"start_character":1,"end_line":14,"end_character":57},"updated":"2024-02-08 13:20:36.000000000","message":"I assume it\u0027s just rules_go\u0027s doing (eg. `go_context(ctx).sdk.root_file.dirname`). It might be worth checking their issue tracker to see if they\u0027re planning to fix this, too.","commit_id":"f93f5e1eccb6f4e5333d028e37c141e9db153dd7"},{"author":{"_account_id":1000002,"name":"Serge Bazanski","display_name":"Serge","email":"serge@monogon.tech","username":"serge","avatars":[{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"af322c90dccef57cb7f0194c216954c3535d21b6","unresolved":false,"context_lines":[{"line_number":11,"context_line":")"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"func mustRunfile(s string) string {"},{"line_number":14,"context_line":"\t// TODO(tim): I couldn\u0027t find out why there is a prefix."},{"line_number":15,"context_line":"\ts \u003d strings.TrimPrefix(s, \"external/\")"},{"line_number":16,"context_line":"\tres, err :\u003d runfiles.Rlocation(s)"},{"line_number":17,"context_line":"\tif err !\u003d nil {"}],"source_content_type":"text/x-properties","patch_set":2,"id":"84ee46e4_a3898d78","line":14,"range":{"start_line":14,"start_character":1,"end_line":14,"end_character":57},"in_reply_to":"19ce6987_d32fc6cf","updated":"2024-02-08 14:23:28.000000000","message":"Strange. I would expect File.dirname to return a sensible path on its own, but oh well.","commit_id":"f93f5e1eccb6f4e5333d028e37c141e9db153dd7"},{"author":{"_account_id":1000002,"name":"Serge Bazanski","display_name":"Serge","email":"serge@monogon.tech","username":"serge","avatars":[{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"055562f3662fb4efc2c27944105fe71133ca4a16","unresolved":false,"context_lines":[{"line_number":11,"context_line":")"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"func mustRunfile(s string) string {"},{"line_number":14,"context_line":"\t// TODO(tim): I couldn\u0027t find out why there is a prefix."},{"line_number":15,"context_line":"\ts \u003d strings.TrimPrefix(s, \"external/\")"},{"line_number":16,"context_line":"\tres, err :\u003d runfiles.Rlocation(s)"},{"line_number":17,"context_line":"\tif err !\u003d nil {"}],"source_content_type":"text/x-properties","patch_set":2,"id":"99343a1e_a428fa5f","line":14,"range":{"start_line":14,"start_character":1,"end_line":14,"end_character":57},"in_reply_to":"2d6667f2_d40a27ad","updated":"2024-02-08 13:40:50.000000000","message":"Have you tried setting `--nolegacy_external_runfiles` and seeing if maybe these paths change to non-external/ ones then?","commit_id":"f93f5e1eccb6f4e5333d028e37c141e9db153dd7"},{"author":{"_account_id":1000019,"name":"Tim Windelschmidt","display_name":"Tim","email":"tim@monogon.tech","username":"fionera","avatars":[{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"c520617f26a4b7d3ead0eb3fb4fde5f433b85efc","unresolved":false,"context_lines":[{"line_number":11,"context_line":")"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"func mustRunfile(s string) string {"},{"line_number":14,"context_line":"\t// TODO(tim): I couldn\u0027t find out why there is a prefix."},{"line_number":15,"context_line":"\ts \u003d strings.TrimPrefix(s, \"external/\")"},{"line_number":16,"context_line":"\tres, err :\u003d runfiles.Rlocation(s)"},{"line_number":17,"context_line":"\tif err !\u003d nil {"}],"source_content_type":"text/x-properties","patch_set":2,"id":"2d6667f2_d40a27ad","line":14,"range":{"start_line":14,"start_character":1,"end_line":14,"end_character":57},"in_reply_to":"89d5fc4d_3f686a6c","updated":"2024-02-08 13:23:27.000000000","message":"These are defined by us inside `build/toolbase/gotoolchain/def.bzl` and do exactly what you said:\n```\n        substitutions \u003d {\n            \"GOROOT\": go.sdk.root_file.dirname,\n            \"GOTOOL\": go.go.path,\n        },\n```\n\nI already played around with it but still didn\u0027t understood it.","commit_id":"f93f5e1eccb6f4e5333d028e37c141e9db153dd7"},{"author":{"_account_id":1000019,"name":"Tim Windelschmidt","display_name":"Tim","email":"tim@monogon.tech","username":"fionera","avatars":[{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"8ef7b9a4d6bd6e5966d338319925917339e2d067","unresolved":false,"context_lines":[{"line_number":11,"context_line":")"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"func mustRunfile(s string) string {"},{"line_number":14,"context_line":"\t// TODO(tim): I couldn\u0027t find out why there is a prefix."},{"line_number":15,"context_line":"\ts \u003d strings.TrimPrefix(s, \"external/\")"},{"line_number":16,"context_line":"\tres, err :\u003d runfiles.Rlocation(s)"},{"line_number":17,"context_line":"\tif err !\u003d nil {"}],"source_content_type":"text/x-properties","patch_set":2,"id":"19ce6987_d32fc6cf","line":14,"range":{"start_line":14,"start_character":1,"end_line":14,"end_character":57},"in_reply_to":"99343a1e_a428fa5f","updated":"2024-02-08 13:43:18.000000000","message":"All changes in this CL where developed with the flags already applied, so yes that doesn\u0027t change anything sadly.","commit_id":"f93f5e1eccb6f4e5333d028e37c141e9db153dd7"}]}