)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000010,"name":"Mateusz Zalega","display_name":"msgctl","email":"mateusz@monogon.tech","username":"mateusz","avatars":[{"url":"https://www.gravatar.com/avatar/30cae8ca0782f23ce0a60ac80fda3dd9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/30cae8ca0782f23ce0a60ac80fda3dd9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/30cae8ca0782f23ce0a60ac80fda3dd9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/30cae8ca0782f23ce0a60ac80fda3dd9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"b6e6d9a83f8b9b8cdb76a1689a088235ad6c6145","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a96f9df4_e09f7739","updated":"2021-08-13 16:46:14.000000000","message":"Not seeing any obvious problems here, I don\u0027t wanna hold you up and am OK with merging it at this time, though I can\u0027t say I have a deep architectural understanding of this part of the codebase.","commit_id":"ae6c5bdfcec009ab062e0424ba4db92e6ba466e0"}],"metropolis/pkg/pki/certificate_test.go":[{"author":{"_account_id":1000010,"name":"Mateusz Zalega","display_name":"msgctl","email":"mateusz@monogon.tech","username":"mateusz","avatars":[{"url":"https://www.gravatar.com/avatar/30cae8ca0782f23ce0a60ac80fda3dd9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/30cae8ca0782f23ce0a60ac80fda3dd9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/30cae8ca0782f23ce0a60ac80fda3dd9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/30cae8ca0782f23ce0a60ac80fda3dd9.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"b6e6d9a83f8b9b8cdb76a1689a088235ad6c6145","unresolved":true,"context_lines":[{"line_number":35,"context_line":"\t\tt.Fatalf(\"Failed to Ensure CA: %v\", err)"},{"line_number":36,"context_line":"\t}"},{"line_number":37,"context_line":"\tcaCert, err :\u003d x509.ParseCertificate(caBytes)"},{"line_number":38,"context_line":"\tif err !\u003d nil {"},{"line_number":39,"context_line":"\t\tt.Fatalf(\"Failed to parse newly emited CA cert: %v\", err)"},{"line_number":40,"context_line":"\t}"},{"line_number":41,"context_line":"\tif !caCert.IsCA {"}],"source_content_type":"text/x-go","patch_set":1,"id":"174c5665_98483692","line":38,"updated":"2021-08-13 16:46:14.000000000","message":"I saw this [1] being used throughout Metropolis code instead: https://pkg.go.dev/github.com/stretchr/testify/require\n\nIt might make this test shorter and more readable.","commit_id":"ae6c5bdfcec009ab062e0424ba4db92e6ba466e0"},{"author":{"_account_id":1000002,"name":"Serge Bazanski","display_name":"Serge","email":"serge@monogon.tech","username":"serge","avatars":[{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"c8b1cb729ba8d186b8946b3c9238ccd9bb3ee05c","unresolved":false,"context_lines":[{"line_number":35,"context_line":"\t\tt.Fatalf(\"Failed to Ensure CA: %v\", err)"},{"line_number":36,"context_line":"\t}"},{"line_number":37,"context_line":"\tcaCert, err :\u003d x509.ParseCertificate(caBytes)"},{"line_number":38,"context_line":"\tif err !\u003d nil {"},{"line_number":39,"context_line":"\t\tt.Fatalf(\"Failed to parse newly emited CA cert: %v\", err)"},{"line_number":40,"context_line":"\t}"},{"line_number":41,"context_line":"\tif !caCert.IsCA {"}],"source_content_type":"text/x-go","patch_set":1,"id":"0ee4faf1_c4e12f4f","line":38,"in_reply_to":"174c5665_98483692","updated":"2021-08-17 14:24:37.000000000","message":"Yeah, I\u0027m aware of this, but I find using plain Go testing to be good enough while also being typesafe (all those \u0027assert equal\u0027 test wrappers use interface{}).\n\nI guess we should probably settle on either one or the other throughout the codebase...","commit_id":"ae6c5bdfcec009ab062e0424ba4db92e6ba466e0"}]}