)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000001,"name":"Lorenz Brun","display_name":"Lorenz","email":"lorenz@monogon.tech","username":"lorenz","avatars":[{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"99ff57a055e196d4c7e74c7375ba43aaf154f11d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"9a15f89d_73d22561","updated":"2023-07-17 18:34:37.000000000","message":"That endpoint should only be on the control plane. Currently this causes all n nodes to open an additional watch for any changes.","commit_id":"1e998d0e45af96e049df57f46fa24293d2f645dc"},{"author":{"_account_id":1000019,"name":"Tim Windelschmidt","display_name":"Tim","email":"tim@monogon.tech","username":"fionera","avatars":[{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"c2fca1496937a401a3023839d85c844853b47a05","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"2d4a0bb7_5925f72c","in_reply_to":"0070a94b_b8e66d2d","updated":"2023-07-19 16:15:25.000000000","message":"Done","commit_id":"1e998d0e45af96e049df57f46fa24293d2f645dc"},{"author":{"_account_id":1000019,"name":"Tim Windelschmidt","display_name":"Tim","email":"tim@monogon.tech","username":"fionera","avatars":[{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"fa84ac98c775e036900c24093ccf943e763de5ba","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"bb684a76_00d8b52c","in_reply_to":"9a15f89d_73d22561","updated":"2023-07-18 10:54:16.000000000","message":"I dont know how much resources this requires but I dont know what would prevent us from having this on all nodes. Is it that expensive?","commit_id":"1e998d0e45af96e049df57f46fa24293d2f645dc"},{"author":{"_account_id":1000001,"name":"Lorenz Brun","display_name":"Lorenz","email":"lorenz@monogon.tech","username":"lorenz","avatars":[{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"01823e2658cdb616f18186b1e870e164a9f845a8","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"0070a94b_b8e66d2d","in_reply_to":"bb684a76_00d8b52c","updated":"2023-07-18 11:59:42.000000000","message":"The thing is there is very little value in serving this from non-controlplane nodes. Prometheus is not going to ask every node for every other node. And watches are potentially O(n^2) for the control plane as every node both generates events and watches all others.","commit_id":"1e998d0e45af96e049df57f46fa24293d2f645dc"}],"metropolis/node/core/metrics/metrics.go":[{"author":{"_account_id":1000002,"name":"Serge Bazanski","display_name":"Serge","email":"serge@monogon.tech","username":"serge","avatars":[{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"372f16d5831668f699eb62b26dcfe477c73623c1","unresolved":true,"context_lines":[{"line_number":268,"context_line":""},{"line_number":269,"context_line":"\t// If sdResp is nil, which only happens if we are not a master node"},{"line_number":270,"context_line":"\t// or we are still booting, we respond with NotImplemented."},{"line_number":271,"context_line":"\tif s.sdResp \u003d\u003d nil {"},{"line_number":272,"context_line":"\t\tw.WriteHeader(http.StatusNotImplemented)"},{"line_number":273,"context_line":"\t\treturn"},{"line_number":274,"context_line":"\t}"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"\tw.Header().Set(\"Content-Type\", \"application/json\")"},{"line_number":277,"context_line":"\tw.WriteHeader(http.StatusOK)"}],"source_content_type":"text/x-go","patch_set":5,"id":"8002f89a_fa20d388","line":274,"range":{"start_line":271,"start_character":0,"end_line":274,"end_character":2},"updated":"2023-07-20 16:01:10.000000000","message":"Please write a test that actually exercises this.","commit_id":"6e6a38bd899822c50866349b23e58ff3d79f38a5"},{"author":{"_account_id":1000019,"name":"Tim Windelschmidt","display_name":"Tim","email":"tim@monogon.tech","username":"fionera","avatars":[{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"ea5e93ba5e2674155eef0f8923e006bcccc03830","unresolved":false,"context_lines":[{"line_number":268,"context_line":""},{"line_number":269,"context_line":"\t// If sdResp is nil, which only happens if we are not a master node"},{"line_number":270,"context_line":"\t// or we are still booting, we respond with NotImplemented."},{"line_number":271,"context_line":"\tif s.sdResp \u003d\u003d nil {"},{"line_number":272,"context_line":"\t\tw.WriteHeader(http.StatusNotImplemented)"},{"line_number":273,"context_line":"\t\treturn"},{"line_number":274,"context_line":"\t}"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"\tw.Header().Set(\"Content-Type\", \"application/json\")"},{"line_number":277,"context_line":"\tw.WriteHeader(http.StatusOK)"}],"source_content_type":"text/x-go","patch_set":5,"id":"ed3f33f9_acd5ed6b","line":274,"range":{"start_line":271,"start_character":0,"end_line":274,"end_character":2},"in_reply_to":"8002f89a_fa20d388","updated":"2023-07-20 18:24:53.000000000","message":"Done","commit_id":"6e6a38bd899822c50866349b23e58ff3d79f38a5"}]}