)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000002,"name":"Serge Bazanski","display_name":"Serge","email":"serge@monogon.tech","username":"serge","avatars":[{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"f2e12bbf2df6daa89298cb188bdf3860ce77ea85","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"f70e9b0c_ec732550","updated":"2023-07-24 10:59:01.000000000","message":"Trusting the tests here, as this is somewhat unreviewable.","commit_id":"3998320f3b958689cba6fa29a4e69bf61294cbd6"}],"cloud/agent/install.go":[{"author":{"_account_id":1000002,"name":"Serge Bazanski","display_name":"Serge","email":"serge@monogon.tech","username":"serge","avatars":[{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"b6ce2ab64e156da65a03e7bb6775b7c78d01e8b8","unresolved":true,"context_lines":[{"line_number":128,"context_line":""},{"line_number":129,"context_line":"\tinstallParams :\u003d osimage.Params{"},{"line_number":130,"context_line":"\t\tPartitionSize: osimage.PartitionSizeInfo{"},{"line_number":131,"context_line":"\t\t\tESP:    384,"},{"line_number":132,"context_line":"\t\t\tSystem: 4096,"},{"line_number":133,"context_line":"\t\t\tData:   128,"},{"line_number":134,"context_line":"\t\t},"}],"source_content_type":"text/x-go","patch_set":21,"id":"a67163fc_0b7dcdfa","line":131,"range":{"start_line":131,"start_character":3,"end_line":131,"end_character":15},"updated":"2023-07-25 14:33:01.000000000","message":"Why do we need to change this?","commit_id":"a38e319c14da63ba9de6f012b5355f93ce83ca01"},{"author":{"_account_id":1000001,"name":"Lorenz Brun","display_name":"Lorenz","email":"lorenz@monogon.tech","username":"lorenz","avatars":[{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"520d3f57ca79b45be761e3e5a95bed2f88bb3e76","unresolved":false,"context_lines":[{"line_number":128,"context_line":""},{"line_number":129,"context_line":"\tinstallParams :\u003d osimage.Params{"},{"line_number":130,"context_line":"\t\tPartitionSize: osimage.PartitionSizeInfo{"},{"line_number":131,"context_line":"\t\t\tESP:    384,"},{"line_number":132,"context_line":"\t\t\tSystem: 4096,"},{"line_number":133,"context_line":"\t\t\tData:   128,"},{"line_number":134,"context_line":"\t\t},"}],"source_content_type":"text/x-go","patch_set":21,"id":"07ae697b_f84ae346","line":131,"range":{"start_line":131,"start_character":3,"end_line":131,"end_character":15},"in_reply_to":"5f951250_01304b27","updated":"2023-07-26 15:45:40.000000000","message":"Moved to A/B change where it belongs.","commit_id":"a38e319c14da63ba9de6f012b5355f93ce83ca01"},{"author":{"_account_id":1000001,"name":"Lorenz Brun","display_name":"Lorenz","email":"lorenz@monogon.tech","username":"lorenz","avatars":[{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"b6f712c0c58949f7a80f87340a15501bac6e13b4","unresolved":true,"context_lines":[{"line_number":128,"context_line":""},{"line_number":129,"context_line":"\tinstallParams :\u003d osimage.Params{"},{"line_number":130,"context_line":"\t\tPartitionSize: osimage.PartitionSizeInfo{"},{"line_number":131,"context_line":"\t\t\tESP:    384,"},{"line_number":132,"context_line":"\t\t\tSystem: 4096,"},{"line_number":133,"context_line":"\t\t\tData:   128,"},{"line_number":134,"context_line":"\t\t},"}],"source_content_type":"text/x-go","patch_set":21,"id":"a87425d6_7e24fcc1","line":131,"range":{"start_line":131,"start_character":3,"end_line":131,"end_character":15},"in_reply_to":"a67163fc_0b7dcdfa","updated":"2023-07-25 19:17:43.000000000","message":"We don\u0027t technically need to, but because we now have higher utilization of that partition (for an A, B and backup loader) I wanted to add some more buffer. Also 256MiB is right at the lower limit for FAT32 at 4K block size (which didn\u0027t work under go-diskfs).","commit_id":"a38e319c14da63ba9de6f012b5355f93ce83ca01"},{"author":{"_account_id":1000002,"name":"Serge Bazanski","display_name":"Serge","email":"serge@monogon.tech","username":"serge","avatars":[{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"6a681563c35e53edaaf20dd44622a89bb01948fe","unresolved":true,"context_lines":[{"line_number":128,"context_line":""},{"line_number":129,"context_line":"\tinstallParams :\u003d osimage.Params{"},{"line_number":130,"context_line":"\t\tPartitionSize: osimage.PartitionSizeInfo{"},{"line_number":131,"context_line":"\t\t\tESP:    384,"},{"line_number":132,"context_line":"\t\t\tSystem: 4096,"},{"line_number":133,"context_line":"\t\t\tData:   128,"},{"line_number":134,"context_line":"\t\t},"}],"source_content_type":"text/x-go","patch_set":21,"id":"5f951250_01304b27","line":131,"range":{"start_line":131,"start_character":3,"end_line":131,"end_character":15},"in_reply_to":"a87425d6_7e24fcc1","updated":"2023-07-26 10:54:56.000000000","message":"Yeah, that would\u0027ve been better off as an independent change, so that `git blame` would stay useful. But that\u0027s for next time.","commit_id":"a38e319c14da63ba9de6f012b5355f93ce83ca01"}],"metropolis/cli/metroctl/cmd_install.go":[{"author":{"_account_id":1000002,"name":"Serge Bazanski","display_name":"Serge","email":"serge@monogon.tech","username":"serge","avatars":[{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"b6ce2ab64e156da65a03e7bb6775b7c78d01e8b8","unresolved":true,"context_lines":[{"line_number":27,"context_line":"}"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"var ("},{"line_number":30,"context_line":"\tbundlePath    \u003d installCmd.PersistentFlags().StringP(\"bundle\", \"b\", \"\", \"Path to the Metropolis bundle to be installed\")"},{"line_number":31,"context_line":"\tinstallerPath \u003d installCmd.PersistentFlags().StringP(\"installer\", \"i\", \"\", \"Path to the Metropolis installer to use when installing\")"},{"line_number":32,"context_line":")"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"var genusbCmd \u003d \u0026cobra.Command{"}],"source_content_type":"text/x-go","patch_set":21,"id":"7140015a_cca25f0b","line":31,"range":{"start_line":30,"start_character":0,"end_line":31,"end_character":134},"updated":"2023-07-25 14:33:01.000000000","message":"Why do we need to change this?","commit_id":"a38e319c14da63ba9de6f012b5355f93ce83ca01"},{"author":{"_account_id":1000001,"name":"Lorenz Brun","display_name":"Lorenz","email":"lorenz@monogon.tech","username":"lorenz","avatars":[{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"b6f712c0c58949f7a80f87340a15501bac6e13b4","unresolved":false,"context_lines":[{"line_number":27,"context_line":"}"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"var ("},{"line_number":30,"context_line":"\tbundlePath    \u003d installCmd.PersistentFlags().StringP(\"bundle\", \"b\", \"\", \"Path to the Metropolis bundle to be installed\")"},{"line_number":31,"context_line":"\tinstallerPath \u003d installCmd.PersistentFlags().StringP(\"installer\", \"i\", \"\", \"Path to the Metropolis installer to use when installing\")"},{"line_number":32,"context_line":")"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"var genusbCmd \u003d \u0026cobra.Command{"}],"source_content_type":"text/x-go","patch_set":21,"id":"d603f8b9_9aa8d81f","line":31,"range":{"start_line":30,"start_character":0,"end_line":31,"end_character":134},"in_reply_to":"7140015a_cca25f0b","updated":"2023-07-25 19:17:43.000000000","message":"Done","commit_id":"a38e319c14da63ba9de6f012b5355f93ce83ca01"},{"author":{"_account_id":1000002,"name":"Serge Bazanski","display_name":"Serge","email":"serge@monogon.tech","username":"serge","avatars":[{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"b6ce2ab64e156da65a03e7bb6775b7c78d01e8b8","unresolved":true,"context_lines":[{"line_number":46,"context_line":"var bootstrap bool"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"var ("},{"line_number":49,"context_line":"\tbootstrapTPMMode               string"},{"line_number":50,"context_line":"\tbootstrapStorageSecurityPolicy string"},{"line_number":51,"context_line":")"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"type externalFile struct {"}],"source_content_type":"text/x-go","patch_set":21,"id":"7e8f4843_55601656","line":50,"range":{"start_line":49,"start_character":0,"end_line":50,"end_character":38},"updated":"2023-07-25 14:33:01.000000000","message":"Why do we need to change this?","commit_id":"a38e319c14da63ba9de6f012b5355f93ce83ca01"},{"author":{"_account_id":1000001,"name":"Lorenz Brun","display_name":"Lorenz","email":"lorenz@monogon.tech","username":"lorenz","avatars":[{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"b6f712c0c58949f7a80f87340a15501bac6e13b4","unresolved":false,"context_lines":[{"line_number":46,"context_line":"var bootstrap bool"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"var ("},{"line_number":49,"context_line":"\tbootstrapTPMMode               string"},{"line_number":50,"context_line":"\tbootstrapStorageSecurityPolicy string"},{"line_number":51,"context_line":")"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"type externalFile struct {"}],"source_content_type":"text/x-go","patch_set":21,"id":"cff4e2cb_73cded4b","line":50,"range":{"start_line":49,"start_character":0,"end_line":50,"end_character":38},"in_reply_to":"7e8f4843_55601656","updated":"2023-07-25 19:17:43.000000000","message":"Done","commit_id":"a38e319c14da63ba9de6f012b5355f93ce83ca01"},{"author":{"_account_id":1000002,"name":"Serge Bazanski","display_name":"Serge","email":"serge@monogon.tech","username":"serge","avatars":[{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"b6ce2ab64e156da65a03e7bb6775b7c78d01e8b8","unresolved":true,"context_lines":[{"line_number":105,"context_line":"\tctx :\u003d clicontext.WithInterrupt(context.Background())"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"\t// TODO(lorenz): Have a key management story for this"},{"line_number":108,"context_line":"\tif err :\u003d os.MkdirAll(flags.configPath, 0o700); err !\u003d nil \u0026\u0026 !os.IsExist(err) {"},{"line_number":109,"context_line":"\t\tlog.Fatalf(\"Failed to create config directory: %v\", err)"},{"line_number":110,"context_line":"\t}"},{"line_number":111,"context_line":""}],"source_content_type":"text/x-go","patch_set":21,"id":"f82d7dc3_6b05deb1","line":108,"range":{"start_line":108,"start_character":41,"end_line":108,"end_character":46},"updated":"2023-07-25 14:33:01.000000000","message":"Why do we need to change this?","commit_id":"a38e319c14da63ba9de6f012b5355f93ce83ca01"},{"author":{"_account_id":1000001,"name":"Lorenz Brun","display_name":"Lorenz","email":"lorenz@monogon.tech","username":"lorenz","avatars":[{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"b6f712c0c58949f7a80f87340a15501bac6e13b4","unresolved":false,"context_lines":[{"line_number":105,"context_line":"\tctx :\u003d clicontext.WithInterrupt(context.Background())"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"\t// TODO(lorenz): Have a key management story for this"},{"line_number":108,"context_line":"\tif err :\u003d os.MkdirAll(flags.configPath, 0o700); err !\u003d nil \u0026\u0026 !os.IsExist(err) {"},{"line_number":109,"context_line":"\t\tlog.Fatalf(\"Failed to create config directory: %v\", err)"},{"line_number":110,"context_line":"\t}"},{"line_number":111,"context_line":""}],"source_content_type":"text/x-go","patch_set":21,"id":"864c4c4f_d264e2c0","line":108,"range":{"start_line":108,"start_character":41,"end_line":108,"end_character":46},"in_reply_to":"f82d7dc3_6b05deb1","updated":"2023-07-25 19:17:43.000000000","message":"Done","commit_id":"a38e319c14da63ba9de6f012b5355f93ce83ca01"}],"metropolis/cli/metroctl/core/install.go":[{"author":{"_account_id":1000002,"name":"Serge Bazanski","display_name":"Serge","email":"serge@monogon.tech","username":"serge","avatars":[{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"b6ce2ab64e156da65a03e7bb6775b7c78d01e8b8","unresolved":true,"context_lines":[{"line_number":42,"context_line":"\t// V2.9 Section 3.5.1.1. This file is booted by any compliant UEFI firmware"},{"line_number":43,"context_line":"\t// in absence of another bootable boot entry."},{"line_number":44,"context_line":"\tif err :\u003d espRoot.PlaceFile(\"EFI/BOOT/BOOTx64.EFI\", args.Installer); err !\u003d nil {"},{"line_number":45,"context_line":"\t\treturn err"},{"line_number":46,"context_line":"\t}"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"\tif args.NodeParams !\u003d nil {"}],"source_content_type":"text/x-go","patch_set":21,"id":"cca605ef_841c357d","line":45,"range":{"start_line":45,"start_character":9,"end_line":45,"end_character":12},"updated":"2023-07-25 14:33:01.000000000","message":"Should we wrap these errors?","commit_id":"a38e319c14da63ba9de6f012b5355f93ce83ca01"},{"author":{"_account_id":1000001,"name":"Lorenz Brun","display_name":"Lorenz","email":"lorenz@monogon.tech","username":"lorenz","avatars":[{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"b6f712c0c58949f7a80f87340a15501bac6e13b4","unresolved":true,"context_lines":[{"line_number":42,"context_line":"\t// V2.9 Section 3.5.1.1. This file is booted by any compliant UEFI firmware"},{"line_number":43,"context_line":"\t// in absence of another bootable boot entry."},{"line_number":44,"context_line":"\tif err :\u003d espRoot.PlaceFile(\"EFI/BOOT/BOOTx64.EFI\", args.Installer); err !\u003d nil {"},{"line_number":45,"context_line":"\t\treturn err"},{"line_number":46,"context_line":"\t}"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"\tif args.NodeParams !\u003d nil {"}],"source_content_type":"text/x-go","patch_set":21,"id":"d0892c87_d63d5ca8","line":45,"range":{"start_line":45,"start_character":9,"end_line":45,"end_character":12},"in_reply_to":"cca605ef_841c357d","updated":"2023-07-25 19:17:43.000000000","message":"Returns a PathError so should generally not need wrapping.","commit_id":"a38e319c14da63ba9de6f012b5355f93ce83ca01"},{"author":{"_account_id":1000002,"name":"Serge Bazanski","display_name":"Serge","email":"serge@monogon.tech","username":"serge","avatars":[{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"6a681563c35e53edaaf20dd44622a89bb01948fe","unresolved":false,"context_lines":[{"line_number":42,"context_line":"\t// V2.9 Section 3.5.1.1. This file is booted by any compliant UEFI firmware"},{"line_number":43,"context_line":"\t// in absence of another bootable boot entry."},{"line_number":44,"context_line":"\tif err :\u003d espRoot.PlaceFile(\"EFI/BOOT/BOOTx64.EFI\", args.Installer); err !\u003d nil {"},{"line_number":45,"context_line":"\t\treturn err"},{"line_number":46,"context_line":"\t}"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"\tif args.NodeParams !\u003d nil {"}],"source_content_type":"text/x-go","patch_set":21,"id":"30b3eb37_19834afa","line":45,"range":{"start_line":45,"start_character":9,"end_line":45,"end_character":12},"in_reply_to":"d0892c87_d63d5ca8","updated":"2023-07-26 10:54:56.000000000","message":"Ack","commit_id":"a38e319c14da63ba9de6f012b5355f93ce83ca01"},{"author":{"_account_id":1000002,"name":"Serge Bazanski","display_name":"Serge","email":"serge@monogon.tech","username":"serge","avatars":[{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"b6ce2ab64e156da65a03e7bb6775b7c78d01e8b8","unresolved":true,"context_lines":[{"line_number":59,"context_line":"\t\t\treturn err"},{"line_number":60,"context_line":"\t\t}"},{"line_number":61,"context_line":"\t}"},{"line_number":62,"context_line":"\tvar targetDev blockdev.BlockDev"},{"line_number":63,"context_line":"\tvar err error"},{"line_number":64,"context_line":"\ttargetDev, err \u003d blockdev.Open(args.TargetPath)"},{"line_number":65,"context_line":"\tif err !\u003d nil {"},{"line_number":66,"context_line":"\t\tif errors.Is(err, os.ErrNotExist) {"}],"source_content_type":"text/x-go","patch_set":21,"id":"56cd9836_864bd88e","line":63,"range":{"start_line":62,"start_character":0,"end_line":63,"end_character":14},"updated":"2023-07-25 14:33:01.000000000","message":"Merge this down into `targetDev, err :\u003d `","commit_id":"a38e319c14da63ba9de6f012b5355f93ce83ca01"},{"author":{"_account_id":1000001,"name":"Lorenz Brun","display_name":"Lorenz","email":"lorenz@monogon.tech","username":"lorenz","avatars":[{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"b6f712c0c58949f7a80f87340a15501bac6e13b4","unresolved":true,"context_lines":[{"line_number":59,"context_line":"\t\t\treturn err"},{"line_number":60,"context_line":"\t\t}"},{"line_number":61,"context_line":"\t}"},{"line_number":62,"context_line":"\tvar targetDev blockdev.BlockDev"},{"line_number":63,"context_line":"\tvar err error"},{"line_number":64,"context_line":"\ttargetDev, err \u003d blockdev.Open(args.TargetPath)"},{"line_number":65,"context_line":"\tif err !\u003d nil {"},{"line_number":66,"context_line":"\t\tif errors.Is(err, os.ErrNotExist) {"}],"source_content_type":"text/x-go","patch_set":21,"id":"e4895051_9569f3ff","line":63,"range":{"start_line":62,"start_character":0,"end_line":63,"end_character":14},"in_reply_to":"56cd9836_864bd88e","updated":"2023-07-25 19:17:43.000000000","message":"Sadly this is intentional as targetDev needs to be a blockdev.BlockDev interface instead of a specific implementation as another implementation is assigned a few lines further down.","commit_id":"a38e319c14da63ba9de6f012b5355f93ce83ca01"},{"author":{"_account_id":1000002,"name":"Serge Bazanski","display_name":"Serge","email":"serge@monogon.tech","username":"serge","avatars":[{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"6a681563c35e53edaaf20dd44622a89bb01948fe","unresolved":false,"context_lines":[{"line_number":59,"context_line":"\t\t\treturn err"},{"line_number":60,"context_line":"\t\t}"},{"line_number":61,"context_line":"\t}"},{"line_number":62,"context_line":"\tvar targetDev blockdev.BlockDev"},{"line_number":63,"context_line":"\tvar err error"},{"line_number":64,"context_line":"\ttargetDev, err \u003d blockdev.Open(args.TargetPath)"},{"line_number":65,"context_line":"\tif err !\u003d nil {"},{"line_number":66,"context_line":"\t\tif errors.Is(err, os.ErrNotExist) {"}],"source_content_type":"text/x-go","patch_set":21,"id":"e190d766_13befe34","line":63,"range":{"start_line":62,"start_character":0,"end_line":63,"end_character":14},"in_reply_to":"e4895051_9569f3ff","updated":"2023-07-26 10:54:56.000000000","message":"Ack","commit_id":"a38e319c14da63ba9de6f012b5355f93ce83ca01"},{"author":{"_account_id":1000002,"name":"Serge Bazanski","display_name":"Serge","email":"serge@monogon.tech","username":"serge","avatars":[{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"b6ce2ab64e156da65a03e7bb6775b7c78d01e8b8","unresolved":true,"context_lines":[{"line_number":79,"context_line":"\t\tName: \"MetropolisInstaller\","},{"line_number":80,"context_line":"\t}"},{"line_number":81,"context_line":"\tfatOpts :\u003d fat32.Options{Label: \"METRO_INST\"}"},{"line_number":82,"context_line":"\t// TODO: fat32.Size"},{"line_number":83,"context_line":"\tvar espSize int64 \u003d 512 * 1024 * 1024"},{"line_number":84,"context_line":"\t// TODO: Needs support for BlockCount \u003d -1"},{"line_number":85,"context_line":"\tif err :\u003d partTable.AddPartition(\u0026esp, espSize); err !\u003d nil {"}],"source_content_type":"text/x-go","patch_set":21,"id":"7c6c166a_34f26547","line":82,"range":{"start_line":82,"start_character":4,"end_line":82,"end_character":8},"updated":"2023-07-25 14:33:01.000000000","message":"TODO(lorenz) or TODO(issue/xxx)\n\nalso below.","commit_id":"a38e319c14da63ba9de6f012b5355f93ce83ca01"},{"author":{"_account_id":1000001,"name":"Lorenz Brun","display_name":"Lorenz","email":"lorenz@monogon.tech","username":"lorenz","avatars":[{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"b6f712c0c58949f7a80f87340a15501bac6e13b4","unresolved":false,"context_lines":[{"line_number":79,"context_line":"\t\tName: \"MetropolisInstaller\","},{"line_number":80,"context_line":"\t}"},{"line_number":81,"context_line":"\tfatOpts :\u003d fat32.Options{Label: \"METRO_INST\"}"},{"line_number":82,"context_line":"\t// TODO: fat32.Size"},{"line_number":83,"context_line":"\tvar espSize int64 \u003d 512 * 1024 * 1024"},{"line_number":84,"context_line":"\t// TODO: Needs support for BlockCount \u003d -1"},{"line_number":85,"context_line":"\tif err :\u003d partTable.AddPartition(\u0026esp, espSize); err !\u003d nil {"}],"source_content_type":"text/x-go","patch_set":21,"id":"a84f8c48_5c7e2c7d","line":82,"range":{"start_line":82,"start_character":4,"end_line":82,"end_character":8},"in_reply_to":"7c6c166a_34f26547","updated":"2023-07-25 19:17:43.000000000","message":"Done","commit_id":"a38e319c14da63ba9de6f012b5355f93ce83ca01"}],"metropolis/installer/main.go":[{"author":{"_account_id":1000002,"name":"Serge Bazanski","display_name":"Serge","email":"serge@monogon.tech","username":"serge","avatars":[{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"b6ce2ab64e156da65a03e7bb6775b7c78d01e8b8","unresolved":true,"context_lines":[{"line_number":172,"context_line":"\t}"},{"line_number":173,"context_line":"\t// Wait for up to 30 tries @ 1s (30s) for the ESP to show up"},{"line_number":174,"context_line":"\tvar espDev string"},{"line_number":175,"context_line":"\tretries :\u003d 30"},{"line_number":176,"context_line":"\tfor {"},{"line_number":177,"context_line":"\t\t// Look up the installer partition based on espUuid."},{"line_number":178,"context_line":"\t\tespDev, err \u003d sysfs.DeviceByPartUUID(espUuid)"}],"source_content_type":"text/x-go","patch_set":21,"id":"c5b31139_28664f57","line":175,"range":{"start_line":175,"start_character":1,"end_line":175,"end_character":14},"updated":"2023-07-25 14:33:01.000000000","message":"Why do we need to change this?","commit_id":"a38e319c14da63ba9de6f012b5355f93ce83ca01"},{"author":{"_account_id":1000001,"name":"Lorenz Brun","display_name":"Lorenz","email":"lorenz@monogon.tech","username":"lorenz","avatars":[{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"b6f712c0c58949f7a80f87340a15501bac6e13b4","unresolved":false,"context_lines":[{"line_number":172,"context_line":"\t}"},{"line_number":173,"context_line":"\t// Wait for up to 30 tries @ 1s (30s) for the ESP to show up"},{"line_number":174,"context_line":"\tvar espDev string"},{"line_number":175,"context_line":"\tretries :\u003d 30"},{"line_number":176,"context_line":"\tfor {"},{"line_number":177,"context_line":"\t\t// Look up the installer partition based on espUuid."},{"line_number":178,"context_line":"\t\tespDev, err \u003d sysfs.DeviceByPartUUID(espUuid)"}],"source_content_type":"text/x-go","patch_set":21,"id":"398ab086_bf0a44ab","line":175,"range":{"start_line":175,"start_character":1,"end_line":175,"end_character":14},"in_reply_to":"c5b31139_28664f57","updated":"2023-07-25 19:17:43.000000000","message":"Done","commit_id":"a38e319c14da63ba9de6f012b5355f93ce83ca01"}],"metropolis/installer/test/main.go":[{"author":{"_account_id":1000002,"name":"Serge Bazanski","display_name":"Serge","email":"serge@monogon.tech","username":"serge","avatars":[{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"b6ce2ab64e156da65a03e7bb6775b7c78d01e8b8","unresolved":true,"context_lines":[{"line_number":215,"context_line":"\tdefer ctxC()"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"\t// Prepare the block device image the installer will install to."},{"line_number":218,"context_line":"\tstoragePath, err :\u003d getStorage(4096 + 128 + 128 + 2)"},{"line_number":219,"context_line":"\tdefer os.Remove(storagePath)"},{"line_number":220,"context_line":"\tif err !\u003d nil {"},{"line_number":221,"context_line":"\t\tt.Errorf(err.Error())"}],"source_content_type":"text/x-go","patch_set":21,"id":"7ec0709d_5c4b1f00","line":218,"range":{"start_line":218,"start_character":1,"end_line":218,"end_character":53},"updated":"2023-07-25 14:33:01.000000000","message":"Why do we need to change this?","commit_id":"a38e319c14da63ba9de6f012b5355f93ce83ca01"},{"author":{"_account_id":1000001,"name":"Lorenz Brun","display_name":"Lorenz","email":"lorenz@monogon.tech","username":"lorenz","avatars":[{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"b6f712c0c58949f7a80f87340a15501bac6e13b4","unresolved":true,"context_lines":[{"line_number":215,"context_line":"\tdefer ctxC()"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"\t// Prepare the block device image the installer will install to."},{"line_number":218,"context_line":"\tstoragePath, err :\u003d getStorage(4096 + 128 + 128 + 2)"},{"line_number":219,"context_line":"\tdefer os.Remove(storagePath)"},{"line_number":220,"context_line":"\tif err !\u003d nil {"},{"line_number":221,"context_line":"\t\tt.Errorf(err.Error())"}],"source_content_type":"text/x-go","patch_set":21,"id":"97e284b9_44edfed0","line":218,"range":{"start_line":218,"start_character":1,"end_line":218,"end_character":53},"in_reply_to":"7ec0709d_5c4b1f00","updated":"2023-07-25 19:17:43.000000000","message":"The original value had insufficient alignment margin. The first 1MiB is used for the GPT header and standard 1MiB partition alignment. At that point there is no space left over for the alternate GPT at the end which occupies a few more blocks. The previous go-diskfs implementation either didn\u0027t align partitions properly or didn\u0027t account for the overrun properly.","commit_id":"a38e319c14da63ba9de6f012b5355f93ce83ca01"},{"author":{"_account_id":1000002,"name":"Serge Bazanski","display_name":"Serge","email":"serge@monogon.tech","username":"serge","avatars":[{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"6a681563c35e53edaaf20dd44622a89bb01948fe","unresolved":true,"context_lines":[{"line_number":215,"context_line":"\tdefer ctxC()"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"\t// Prepare the block device image the installer will install to."},{"line_number":218,"context_line":"\tstoragePath, err :\u003d getStorage(4096 + 128 + 128 + 2)"},{"line_number":219,"context_line":"\tdefer os.Remove(storagePath)"},{"line_number":220,"context_line":"\tif err !\u003d nil {"},{"line_number":221,"context_line":"\t\tt.Errorf(err.Error())"}],"source_content_type":"text/x-go","patch_set":21,"id":"ba47fb89_c1736fd3","line":218,"range":{"start_line":218,"start_character":1,"end_line":218,"end_character":53},"in_reply_to":"97e284b9_44edfed0","updated":"2023-07-26 10:54:56.000000000","message":"Can we make it clear what these numbers mean, eg. via a comment?","commit_id":"a38e319c14da63ba9de6f012b5355f93ce83ca01"},{"author":{"_account_id":1000001,"name":"Lorenz Brun","display_name":"Lorenz","email":"lorenz@monogon.tech","username":"lorenz","avatars":[{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"520d3f57ca79b45be761e3e5a95bed2f88bb3e76","unresolved":false,"context_lines":[{"line_number":215,"context_line":"\tdefer ctxC()"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"\t// Prepare the block device image the installer will install to."},{"line_number":218,"context_line":"\tstoragePath, err :\u003d getStorage(4096 + 128 + 128 + 2)"},{"line_number":219,"context_line":"\tdefer os.Remove(storagePath)"},{"line_number":220,"context_line":"\tif err !\u003d nil {"},{"line_number":221,"context_line":"\t\tt.Errorf(err.Error())"}],"source_content_type":"text/x-go","patch_set":21,"id":"9325da65_261d3cc2","line":218,"range":{"start_line":218,"start_character":1,"end_line":218,"end_character":53},"in_reply_to":"ba47fb89_c1736fd3","updated":"2023-07-26 15:45:40.000000000","message":"Done","commit_id":"a38e319c14da63ba9de6f012b5355f93ce83ca01"}],"metropolis/installer/test/testos/BUILD.bazel":[{"author":{"_account_id":1000002,"name":"Serge Bazanski","display_name":"Serge","email":"serge@monogon.tech","username":"serge","avatars":[{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"b6ce2ab64e156da65a03e7bb6775b7c78d01e8b8","unresolved":true,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"efi_unified_kernel_image("},{"line_number":19,"context_line":"    name \u003d \"kernel_efi\","},{"line_number":20,"context_line":"    cmdline \u003d \"quiet console\u003dttyS0 init\u003d/init\","},{"line_number":21,"context_line":"    kernel \u003d \"//third_party/linux\","},{"line_number":22,"context_line":"    verity \u003d \":verity_rootfs\","},{"line_number":23,"context_line":")"}],"source_content_type":"text/x-python","patch_set":21,"id":"1edf1c2c_18ff68f7","line":20,"range":{"start_line":20,"start_character":15,"end_line":20,"end_character":20},"updated":"2023-07-25 14:33:01.000000000","message":"Why do we need to do this?","commit_id":"a38e319c14da63ba9de6f012b5355f93ce83ca01"},{"author":{"_account_id":1000001,"name":"Lorenz Brun","display_name":"Lorenz","email":"lorenz@monogon.tech","username":"lorenz","avatars":[{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"b6f712c0c58949f7a80f87340a15501bac6e13b4","unresolved":true,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"efi_unified_kernel_image("},{"line_number":19,"context_line":"    name \u003d \"kernel_efi\","},{"line_number":20,"context_line":"    cmdline \u003d \"quiet console\u003dttyS0 init\u003d/init\","},{"line_number":21,"context_line":"    kernel \u003d \"//third_party/linux\","},{"line_number":22,"context_line":"    verity \u003d \":verity_rootfs\","},{"line_number":23,"context_line":")"}],"source_content_type":"text/x-python","patch_set":21,"id":"fea70fa8_0ed0616a","line":20,"range":{"start_line":20,"start_character":15,"end_line":20,"end_character":20},"in_reply_to":"1edf1c2c_18ff68f7","updated":"2023-07-25 19:17:43.000000000","message":"`loglevel\u003d0` stops the kernel from logging even panics like not finding the system partition. This is terrible for debugging. Quiet shuts it up for anything but errors/panics, which is what is required here.","commit_id":"a38e319c14da63ba9de6f012b5355f93ce83ca01"},{"author":{"_account_id":1000001,"name":"Lorenz Brun","display_name":"Lorenz","email":"lorenz@monogon.tech","username":"lorenz","avatars":[{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"520d3f57ca79b45be761e3e5a95bed2f88bb3e76","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"efi_unified_kernel_image("},{"line_number":19,"context_line":"    name \u003d \"kernel_efi\","},{"line_number":20,"context_line":"    cmdline \u003d \"quiet console\u003dttyS0 init\u003d/init\","},{"line_number":21,"context_line":"    kernel \u003d \"//third_party/linux\","},{"line_number":22,"context_line":"    verity \u003d \":verity_rootfs\","},{"line_number":23,"context_line":")"}],"source_content_type":"text/x-python","patch_set":21,"id":"d0db2944_67d06df0","line":20,"range":{"start_line":20,"start_character":15,"end_line":20,"end_character":20},"in_reply_to":"6d8a738c_dcecd43a","updated":"2023-07-26 15:45:40.000000000","message":"Ack","commit_id":"a38e319c14da63ba9de6f012b5355f93ce83ca01"},{"author":{"_account_id":1000002,"name":"Serge Bazanski","display_name":"Serge","email":"serge@monogon.tech","username":"serge","avatars":[{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"6a681563c35e53edaaf20dd44622a89bb01948fe","unresolved":true,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"efi_unified_kernel_image("},{"line_number":19,"context_line":"    name \u003d \"kernel_efi\","},{"line_number":20,"context_line":"    cmdline \u003d \"quiet console\u003dttyS0 init\u003d/init\","},{"line_number":21,"context_line":"    kernel \u003d \"//third_party/linux\","},{"line_number":22,"context_line":"    verity \u003d \":verity_rootfs\","},{"line_number":23,"context_line":")"}],"source_content_type":"text/x-python","patch_set":21,"id":"6d8a738c_dcecd43a","line":20,"range":{"start_line":20,"start_character":15,"end_line":20,"end_character":20},"in_reply_to":"fea70fa8_0ed0616a","updated":"2023-07-26 10:54:56.000000000","message":"In the future please send these small, independent fixes out as a separate change.","commit_id":"a38e319c14da63ba9de6f012b5355f93ce83ca01"}],"metropolis/node/build/mkimage/main.go":[{"author":{"_account_id":1000002,"name":"Serge Bazanski","display_name":"Serge","email":"serge@monogon.tech","username":"serge","avatars":[{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"b6ce2ab64e156da65a03e7bb6775b7c78d01e8b8","unresolved":true,"context_lines":[{"line_number":86,"context_line":"\t\tcfg.NodeParameters \u003d np"},{"line_number":87,"context_line":"\t}"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"\t// TODO: Flexibly-sized devices"},{"line_number":90,"context_line":"\tcfg.Output, err \u003d blockdev.CreateFile(outputPath, 512, 10*1024*1024)"},{"line_number":91,"context_line":"\tif err !\u003d nil {"},{"line_number":92,"context_line":"\t\tpanic(err)"}],"source_content_type":"text/x-go","patch_set":21,"id":"1add5b6d_bdbb7feb","line":89,"range":{"start_line":89,"start_character":4,"end_line":89,"end_character":8},"updated":"2023-07-25 14:33:01.000000000","message":"`TODO(lorenz)` or `TODO(issue/...)`","commit_id":"a38e319c14da63ba9de6f012b5355f93ce83ca01"},{"author":{"_account_id":1000001,"name":"Lorenz Brun","display_name":"Lorenz","email":"lorenz@monogon.tech","username":"lorenz","avatars":[{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"b6f712c0c58949f7a80f87340a15501bac6e13b4","unresolved":false,"context_lines":[{"line_number":86,"context_line":"\t\tcfg.NodeParameters \u003d np"},{"line_number":87,"context_line":"\t}"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"\t// TODO: Flexibly-sized devices"},{"line_number":90,"context_line":"\tcfg.Output, err \u003d blockdev.CreateFile(outputPath, 512, 10*1024*1024)"},{"line_number":91,"context_line":"\tif err !\u003d nil {"},{"line_number":92,"context_line":"\t\tpanic(err)"}],"source_content_type":"text/x-go","patch_set":21,"id":"bc5d5727_4d86ba06","line":89,"range":{"start_line":89,"start_character":4,"end_line":89,"end_character":8},"in_reply_to":"1add5b6d_bdbb7feb","updated":"2023-07-25 19:17:43.000000000","message":"Done","commit_id":"a38e319c14da63ba9de6f012b5355f93ce83ca01"}],"metropolis/node/build/mkimage/osimage/osimage.go":[{"author":{"_account_id":1000002,"name":"Serge Bazanski","display_name":"Serge","email":"serge@monogon.tech","username":"serge","avatars":[{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"b6ce2ab64e156da65a03e7bb6775b7c78d01e8b8","unresolved":true,"context_lines":[{"line_number":112,"context_line":"\trootInode :\u003d fat32.Inode{"},{"line_number":113,"context_line":"\t\tAttrs: fat32.AttrDirectory,"},{"line_number":114,"context_line":"\t}"},{"line_number":115,"context_line":"\trootInode.PlaceFile(strings.TrimPrefix(EFIPayloadPath, \"/\"), params.EFIPayload)"},{"line_number":116,"context_line":"\tif params.NodeParameters !\u003d nil {"},{"line_number":117,"context_line":"\t\trootInode.PlaceFile(nodeParamsPath, params.NodeParameters)"},{"line_number":118,"context_line":"\t}"}],"source_content_type":"text/x-go","patch_set":21,"id":"cefa9784_3ac61f99","line":115,"range":{"start_line":115,"start_character":11,"end_line":115,"end_character":20},"updated":"2023-07-25 14:33:01.000000000","message":"Check return value here (and elsewhere).","commit_id":"a38e319c14da63ba9de6f012b5355f93ce83ca01"},{"author":{"_account_id":1000001,"name":"Lorenz Brun","display_name":"Lorenz","email":"lorenz@monogon.tech","username":"lorenz","avatars":[{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"b6f712c0c58949f7a80f87340a15501bac6e13b4","unresolved":false,"context_lines":[{"line_number":112,"context_line":"\trootInode :\u003d fat32.Inode{"},{"line_number":113,"context_line":"\t\tAttrs: fat32.AttrDirectory,"},{"line_number":114,"context_line":"\t}"},{"line_number":115,"context_line":"\trootInode.PlaceFile(strings.TrimPrefix(EFIPayloadPath, \"/\"), params.EFIPayload)"},{"line_number":116,"context_line":"\tif params.NodeParameters !\u003d nil {"},{"line_number":117,"context_line":"\t\trootInode.PlaceFile(nodeParamsPath, params.NodeParameters)"},{"line_number":118,"context_line":"\t}"}],"source_content_type":"text/x-go","patch_set":21,"id":"5e5014d9_54d8e8a8","line":115,"range":{"start_line":115,"start_character":11,"end_line":115,"end_character":20},"in_reply_to":"cefa9784_3ac61f99","updated":"2023-07-25 19:17:43.000000000","message":"Done","commit_id":"a38e319c14da63ba9de6f012b5355f93ce83ca01"}],"metropolis/pkg/gpt/gpt.go":[{"author":{"_account_id":1000002,"name":"Serge Bazanski","display_name":"Serge","email":"serge@monogon.tech","username":"serge","avatars":[{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"b6ce2ab64e156da65a03e7bb6775b7c78d01e8b8","unresolved":true,"context_lines":[{"line_number":20,"context_line":"\t\"source.monogon.dev/metropolis/pkg/msguid\""},{"line_number":21,"context_line":")"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"var ("},{"line_number":24,"context_line":"\tgptSignature        \u003d [8]byte{\u0027E\u0027, \u0027F\u0027, \u0027I\u0027, \u0027 \u0027, \u0027P\u0027, \u0027A\u0027, \u0027R\u0027, \u0027T\u0027}"},{"line_number":25,"context_line":"\tgptRevision  uint32 \u003d 0x00010000 // First 2 bytes major, second 2 bytes minor"},{"line_number":26,"context_line":")"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"// See UEFI Specification 2.9 Table 5-5"},{"line_number":29,"context_line":"type header struct {"},{"line_number":30,"context_line":"\tSignature   [8]byte"}],"source_content_type":"text/x-go","patch_set":21,"id":"6bd7cf47_bc19e4c2","line":27,"range":{"start_line":23,"start_character":0,"end_line":27,"end_character":0},"updated":"2023-07-25 14:33:01.000000000","message":"Why do we need to change this?","commit_id":"a38e319c14da63ba9de6f012b5355f93ce83ca01"},{"author":{"_account_id":1000001,"name":"Lorenz Brun","display_name":"Lorenz","email":"lorenz@monogon.tech","username":"lorenz","avatars":[{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"b6f712c0c58949f7a80f87340a15501bac6e13b4","unresolved":false,"context_lines":[{"line_number":20,"context_line":"\t\"source.monogon.dev/metropolis/pkg/msguid\""},{"line_number":21,"context_line":")"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"var ("},{"line_number":24,"context_line":"\tgptSignature        \u003d [8]byte{\u0027E\u0027, \u0027F\u0027, \u0027I\u0027, \u0027 \u0027, \u0027P\u0027, \u0027A\u0027, \u0027R\u0027, \u0027T\u0027}"},{"line_number":25,"context_line":"\tgptRevision  uint32 \u003d 0x00010000 // First 2 bytes major, second 2 bytes minor"},{"line_number":26,"context_line":")"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"// See UEFI Specification 2.9 Table 5-5"},{"line_number":29,"context_line":"type header struct {"},{"line_number":30,"context_line":"\tSignature   [8]byte"}],"source_content_type":"text/x-go","patch_set":21,"id":"1aadf2a6_f72fc940","line":27,"range":{"start_line":23,"start_character":0,"end_line":27,"end_character":0},"in_reply_to":"6bd7cf47_bc19e4c2","updated":"2023-07-25 19:17:43.000000000","message":"Done","commit_id":"a38e319c14da63ba9de6f012b5355f93ce83ca01"},{"author":{"_account_id":1000002,"name":"Serge Bazanski","display_name":"Serge","email":"serge@monogon.tech","username":"serge","avatars":[{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"b6ce2ab64e156da65a03e7bb6775b7c78d01e8b8","unresolved":true,"context_lines":[{"line_number":56,"context_line":"\tName       [36]uint16"},{"line_number":57,"context_line":"}"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"var PartitionTypeEFISystem \u003d uuid.MustParse(\"C12A7328-F81F-11D2-BA4B-00A0C93EC93B\")"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"// Attribute is a bitfield of attributes set on a partition. Bits 0 to 47 are"},{"line_number":62,"context_line":"// reserved for UEFI specification use and all current assignments are in the"}],"source_content_type":"text/x-go","patch_set":21,"id":"a67aec06_3de7b78a","line":59,"range":{"start_line":59,"start_character":4,"end_line":59,"end_character":83},"updated":"2023-07-25 14:33:01.000000000","message":"Why do we need to change this?","commit_id":"a38e319c14da63ba9de6f012b5355f93ce83ca01"},{"author":{"_account_id":1000001,"name":"Lorenz Brun","display_name":"Lorenz","email":"lorenz@monogon.tech","username":"lorenz","avatars":[{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"b6f712c0c58949f7a80f87340a15501bac6e13b4","unresolved":false,"context_lines":[{"line_number":56,"context_line":"\tName       [36]uint16"},{"line_number":57,"context_line":"}"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"var PartitionTypeEFISystem \u003d uuid.MustParse(\"C12A7328-F81F-11D2-BA4B-00A0C93EC93B\")"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"// Attribute is a bitfield of attributes set on a partition. Bits 0 to 47 are"},{"line_number":62,"context_line":"// reserved for UEFI specification use and all current assignments are in the"}],"source_content_type":"text/x-go","patch_set":21,"id":"914c5e5f_96996f40","line":59,"range":{"start_line":59,"start_character":4,"end_line":59,"end_character":83},"in_reply_to":"a67aec06_3de7b78a","updated":"2023-07-25 19:17:43.000000000","message":"Done","commit_id":"a38e319c14da63ba9de6f012b5355f93ce83ca01"}],"metropolis/pkg/gpt/mbr.go":[{"author":{"_account_id":1000002,"name":"Serge Bazanski","display_name":"Serge","email":"serge@monogon.tech","username":"serge","avatars":[{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"b6ce2ab64e156da65a03e7bb6775b7c78d01e8b8","unresolved":true,"context_lines":[{"line_number":29,"context_line":"var mbrSignature \u003d [2]byte{0x55, 0xaa}"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"func makeProtectiveMBR(w io.Writer, blockCount int64, bootCode []byte) error {"},{"line_number":32,"context_line":"\trepresentedBlockCount :\u003d uint32(math.MaxUint32)"},{"line_number":33,"context_line":"\tif blockCount \u003c math.MaxUint32 {"},{"line_number":34,"context_line":"\t\trepresentedBlockCount \u003d uint32(blockCount)"},{"line_number":35,"context_line":"\t}"}],"source_content_type":"text/x-go","patch_set":21,"id":"f01f52f2_0a071ab4","line":32,"range":{"start_line":32,"start_character":1,"end_line":32,"end_character":48},"updated":"2023-07-25 14:33:01.000000000","message":"Why do we need to change this?","commit_id":"a38e319c14da63ba9de6f012b5355f93ce83ca01"},{"author":{"_account_id":1000001,"name":"Lorenz Brun","display_name":"Lorenz","email":"lorenz@monogon.tech","username":"lorenz","avatars":[{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"b6f712c0c58949f7a80f87340a15501bac6e13b4","unresolved":false,"context_lines":[{"line_number":29,"context_line":"var mbrSignature \u003d [2]byte{0x55, 0xaa}"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"func makeProtectiveMBR(w io.Writer, blockCount int64, bootCode []byte) error {"},{"line_number":32,"context_line":"\trepresentedBlockCount :\u003d uint32(math.MaxUint32)"},{"line_number":33,"context_line":"\tif blockCount \u003c math.MaxUint32 {"},{"line_number":34,"context_line":"\t\trepresentedBlockCount \u003d uint32(blockCount)"},{"line_number":35,"context_line":"\t}"}],"source_content_type":"text/x-go","patch_set":21,"id":"4320d512_67d1b4ce","line":32,"range":{"start_line":32,"start_character":1,"end_line":32,"end_character":48},"in_reply_to":"f01f52f2_0a071ab4","updated":"2023-07-25 19:17:43.000000000","message":"Done","commit_id":"a38e319c14da63ba9de6f012b5355f93ce83ca01"}]}