)]}'
{"cloud/bmaas/bmdb/model/migrations/1687875953_add_installation_report.up.sql":[{"author":{"_account_id":1000002,"name":"Serge Bazanski","display_name":"Serge","email":"serge@monogon.tech","username":"serge","avatars":[{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"a4c9df09c10f4cbb31a328cfa396fb2a4c4b2f95","unresolved":true,"context_lines":[{"line_number":1,"context_line":"-- Add column for storing the serialized cloud.bmaas.server.api.OSInstallationReport"},{"line_number":2,"context_line":"-- also add a column to display if the installation was successful or not."},{"line_number":3,"context_line":"ALTER TABLE machine_os_installation_report"},{"line_number":4,"context_line":"    ADD COLUMN successful BOOLEAN NOT NULL,"},{"line_number":5,"context_line":"    ADD COLUMN os_installation_report_raw BYTEA NOT NULL;"}],"source_content_type":"text/x-sql","patch_set":4,"id":"6d22d8a7_f0c77e03","line":4,"range":{"start_line":4,"start_character":15,"end_line":4,"end_character":25},"updated":"2023-06-28 11:52:13.000000000","message":"cloud.bmaas.server.api.OSInstallationReport currently has a oneof with members \u0027success\u0027 and \u0027error\u0027, which allows for the possibility to have more than two values. I think here this also should then be an enum instead of a bool.\n\nPerhaps even have two \u0027sparse\u0027 nullable columns, one set with the serialized \u0027success\u0027 field, the other one with the serialized \u0027error\u0027 field?","commit_id":"0e474493917cfb0f9cf2a44a035d7b815b8385e9"},{"author":{"_account_id":1000019,"name":"Tim Windelschmidt","display_name":"Tim","email":"tim@monogon.tech","username":"fionera","avatars":[{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"d76db457489299d1bdea92f69115f95a8ed101ba","unresolved":true,"context_lines":[{"line_number":1,"context_line":"-- Add column for storing the serialized cloud.bmaas.server.api.OSInstallationReport"},{"line_number":2,"context_line":"-- also add a column to display if the installation was successful or not."},{"line_number":3,"context_line":"ALTER TABLE machine_os_installation_report"},{"line_number":4,"context_line":"    ADD COLUMN successful BOOLEAN NOT NULL,"},{"line_number":5,"context_line":"    ADD COLUMN os_installation_report_raw BYTEA NOT NULL;"}],"source_content_type":"text/x-sql","patch_set":4,"id":"fb469733_7cc3ee14","line":4,"range":{"start_line":4,"start_character":15,"end_line":4,"end_character":25},"in_reply_to":"6d22d8a7_f0c77e03","updated":"2023-07-03 13:37:34.000000000","message":"I replaced it with an enum. Having sparse columns would only help when we want to filter on the actual error etc. I prefer to have the raw value and a generic result state.","commit_id":"0e474493917cfb0f9cf2a44a035d7b815b8385e9"},{"author":{"_account_id":1000002,"name":"Serge Bazanski","display_name":"Serge","email":"serge@monogon.tech","username":"serge","avatars":[{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"cbdc1f65a3114e715e6c18e8b53f23ec9fc15441","unresolved":false,"context_lines":[{"line_number":1,"context_line":"-- Add column for storing the serialized cloud.bmaas.server.api.OSInstallationReport"},{"line_number":2,"context_line":"-- also add a column to display if the installation was successful or not."},{"line_number":3,"context_line":"ALTER TABLE machine_os_installation_report"},{"line_number":4,"context_line":"    ADD COLUMN successful BOOLEAN NOT NULL,"},{"line_number":5,"context_line":"    ADD COLUMN os_installation_report_raw BYTEA NOT NULL;"}],"source_content_type":"text/x-sql","patch_set":4,"id":"f424efad_c408b0cb","line":4,"range":{"start_line":4,"start_character":15,"end_line":4,"end_character":25},"in_reply_to":"fb469733_7cc3ee14","updated":"2023-07-03 14:18:26.000000000","message":"Ack","commit_id":"0e474493917cfb0f9cf2a44a035d7b815b8385e9"},{"author":{"_account_id":1000002,"name":"Serge Bazanski","display_name":"Serge","email":"serge@monogon.tech","username":"serge","avatars":[{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"cbdc1f65a3114e715e6c18e8b53f23ec9fc15441","unresolved":true,"context_lines":[{"line_number":6,"context_line":"-- Add column for storing the serialized cloud.bmaas.server.api.OSInstallationReport"},{"line_number":7,"context_line":"-- also add a column to display if the installation was successful or not."},{"line_number":8,"context_line":"ALTER TABLE machine_os_installation_report"},{"line_number":9,"context_line":"    ADD COLUMN result machine_os_installation_result NOT NULL,"},{"line_number":10,"context_line":"    ADD COLUMN os_installation_report_raw BYTEA NOT NULL;"}],"source_content_type":"text/x-sql","patch_set":6,"id":"92a9e8a5_61d6a922","line":9,"range":{"start_line":9,"start_character":15,"end_line":9,"end_character":21},"updated":"2023-07-03 14:18:26.000000000","message":"os_installation_result\n\n(I know this convention sucks, but that\u0027s the convention we have...)","commit_id":"702d0f16615ad1c4bc6cc5e47a0586deecaf07bb"},{"author":{"_account_id":1000019,"name":"Tim Windelschmidt","display_name":"Tim","email":"tim@monogon.tech","username":"fionera","avatars":[{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"67465b017c9480a6d81e323b2af3595e4d8d0923","unresolved":false,"context_lines":[{"line_number":6,"context_line":"-- Add column for storing the serialized cloud.bmaas.server.api.OSInstallationReport"},{"line_number":7,"context_line":"-- also add a column to display if the installation was successful or not."},{"line_number":8,"context_line":"ALTER TABLE machine_os_installation_report"},{"line_number":9,"context_line":"    ADD COLUMN result machine_os_installation_result NOT NULL,"},{"line_number":10,"context_line":"    ADD COLUMN os_installation_report_raw BYTEA NOT NULL;"}],"source_content_type":"text/x-sql","patch_set":6,"id":"5369d2b1_215991ad","line":9,"range":{"start_line":9,"start_character":15,"end_line":9,"end_character":21},"in_reply_to":"92a9e8a5_61d6a922","updated":"2023-07-03 23:44:15.000000000","message":"Done","commit_id":"702d0f16615ad1c4bc6cc5e47a0586deecaf07bb"}],"cloud/bmaas/scruffy/hw_stats_test.go":[{"author":{"_account_id":1000002,"name":"Serge Bazanski","display_name":"Serge","email":"serge@monogon.tech","username":"serge","avatars":[{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"cbdc1f65a3114e715e6c18e8b53f23ec9fc15441","unresolved":true,"context_lines":[{"line_number":1,"context_line":"package scruffy"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"import ("},{"line_number":4,"context_line":"\t\"context\""}],"source_content_type":"text/x-go","patch_set":6,"id":"db0a0bcf_ade3130b","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":15},"updated":"2023-07-03 14:18:26.000000000","message":"I don\u0027t think that\u0027s supposed to be here in this change.","commit_id":"702d0f16615ad1c4bc6cc5e47a0586deecaf07bb"},{"author":{"_account_id":1000002,"name":"Serge Bazanski","display_name":"Serge","email":"serge@monogon.tech","username":"serge","avatars":[{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"af25cfcebeb2ec794ea4483335f87c0f6dce1163","unresolved":false,"context_lines":[{"line_number":1,"context_line":"package scruffy"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"import ("},{"line_number":4,"context_line":"\t\"context\""}],"source_content_type":"text/x-go","patch_set":6,"id":"f6e5ebfc_14958b18","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":15},"in_reply_to":"db0a0bcf_ade3130b","updated":"2023-07-03 14:18:57.000000000","message":"Ah, Gerrit tricked me. Nevermind.","commit_id":"702d0f16615ad1c4bc6cc5e47a0586deecaf07bb"}]}