)]}'
{"metropolis/node/core/roleserve/worker_rolefetch.go":[{"author":{"_account_id":1000001,"name":"Lorenz Brun","display_name":"Lorenz","email":"lorenz@monogon.tech","username":"lorenz","avatars":[{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"a636a39475f15ade7851d1212c75d51dc0c0b962","unresolved":true,"context_lines":[{"line_number":26,"context_line":"}"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"func (s *workerRoleFetch) run(ctx context.Context) error {"},{"line_number":29,"context_line":"\tw :\u003d s.curatorConnection.Watch()"},{"line_number":30,"context_line":"\tdefer w.Close()"},{"line_number":31,"context_line":"\tsupervisor.Logger(ctx).Infof(\"Waiting for curator connection...\")"},{"line_number":32,"context_line":"\tcc, err :\u003d w.Get(ctx)"}],"source_content_type":"text/x-go","patch_set":1,"id":"f2824f67_ccf4aeb6","line":29,"range":{"start_line":29,"start_character":8,"end_line":29,"end_character":25},"updated":"2023-06-21 15:59:57.000000000","message":"Previously when the RPC failed, it restarted the whole runnable and got a new curator connection. Now it always uses the same one (because the w.Get()) is only in the outer runnable. This sounds suspicious to me, because if the connection got recreated for some reason this would be broken, right?","commit_id":"af1701ed5e2bf21b6bca769e5f53df291b196c48"},{"author":{"_account_id":1000002,"name":"Serge Bazanski","display_name":"Serge","email":"serge@monogon.tech","username":"serge","avatars":[{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"2c9e56695998833b3916d137a1a1d13d5071a2e4","unresolved":false,"context_lines":[{"line_number":26,"context_line":"}"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"func (s *workerRoleFetch) run(ctx context.Context) error {"},{"line_number":29,"context_line":"\tw :\u003d s.curatorConnection.Watch()"},{"line_number":30,"context_line":"\tdefer w.Close()"},{"line_number":31,"context_line":"\tsupervisor.Logger(ctx).Infof(\"Waiting for curator connection...\")"},{"line_number":32,"context_line":"\tcc, err :\u003d w.Get(ctx)"}],"source_content_type":"text/x-go","patch_set":1,"id":"69d94751_7818cd2b","line":29,"range":{"start_line":29,"start_character":8,"end_line":29,"end_character":25},"in_reply_to":"f2824f67_ccf4aeb6","updated":"2023-06-21 19:51:43.000000000","message":"Done","commit_id":"af1701ed5e2bf21b6bca769e5f53df291b196c48"}]}
