)]}'
{"cloud/bmaas/bmdb/reflection/reflection.go":[{"author":{"_account_id":1000002,"name":"Serge Bazanski","display_name":"Serge","email":"serge@monogon.tech","username":"serge","avatars":[{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"cfc586905ef743175d4f5e7612fea22d9b396c4a","unresolved":true,"context_lines":[{"line_number":424,"context_line":"\t\t}"},{"line_number":425,"context_line":"\t\tr.time \u003d \u0026src2"},{"line_number":426,"context_line":"\tcase \"bigint\":"},{"line_number":427,"context_line":"\t\tsrc2 :\u003d fmt.Sprintf(\"%v\", src)"},{"line_number":428,"context_line":"\t\tr.text \u003d \u0026src2"},{"line_number":429,"context_line":"\tdefault:"},{"line_number":430,"context_line":"\t\treturn fmt.Errorf(\"unimplemented SQL type %q\", r.Type.NativeType)"}],"source_content_type":"text/x-go","patch_set":1,"id":"d4c74dd5_cfb91b59","line":427,"range":{"start_line":427,"start_character":2,"end_line":427,"end_character":32},"updated":"2023-04-24 17:20:28.000000000","message":"Please do a type assertion here just in case.","commit_id":"024c8f531c85eeab8347b20e70ec74a5215880c6"},{"author":{"_account_id":1000019,"name":"Tim Windelschmidt","display_name":"Tim","email":"tim@monogon.tech","username":"fionera","avatars":[{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"19337a6347456568fc53dc9d22f0e81174ac7114","unresolved":false,"context_lines":[{"line_number":424,"context_line":"\t\t}"},{"line_number":425,"context_line":"\t\tr.time \u003d \u0026src2"},{"line_number":426,"context_line":"\tcase \"bigint\":"},{"line_number":427,"context_line":"\t\tsrc2 :\u003d fmt.Sprintf(\"%v\", src)"},{"line_number":428,"context_line":"\t\tr.text \u003d \u0026src2"},{"line_number":429,"context_line":"\tdefault:"},{"line_number":430,"context_line":"\t\treturn fmt.Errorf(\"unimplemented SQL type %q\", r.Type.NativeType)"}],"source_content_type":"text/x-go","patch_set":1,"id":"0477bd2f_c35953fa","line":427,"range":{"start_line":427,"start_character":2,"end_line":427,"end_character":32},"in_reply_to":"d4c74dd5_cfb91b59","updated":"2023-04-24 20:22:07.000000000","message":"Ack","commit_id":"024c8f531c85eeab8347b20e70ec74a5215880c6"},{"author":{"_account_id":1000002,"name":"Serge Bazanski","display_name":"Serge","email":"serge@monogon.tech","username":"serge","avatars":[{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"52d0e9cab7203f9dd4316fea058dde2963e23f15","unresolved":true,"context_lines":[{"line_number":425,"context_line":"\t\tr.time \u003d \u0026src2"},{"line_number":426,"context_line":"\tcase \"bigint\":"},{"line_number":427,"context_line":"\t\tswitch src.(type) {"},{"line_number":428,"context_line":"\t\tcase uint, uint8, uint16, uint32, uint64,"},{"line_number":429,"context_line":"\t\t\tint, int8, int16, int32, int64:"},{"line_number":430,"context_line":"\t\t\tbreak"},{"line_number":431,"context_line":"\t\tdefault:"},{"line_number":432,"context_line":"\t\t\treturn fmt.Errorf(\"SQL type %q, but got %+v\", r.Type.NativeType, src)"}],"source_content_type":"text/x-go","patch_set":2,"id":"e0ef5fa6_6d7d65e2","line":429,"range":{"start_line":428,"start_character":7,"end_line":429,"end_character":34},"updated":"2023-04-25 09:35:38.000000000","message":"Doesn\u0027t the Postgres SQL driver guarantee this to be just one underlying Go type here?","commit_id":"280d95d4ea868361735eddb4334375d4ea8baf2c"},{"author":{"_account_id":1000019,"name":"Tim Windelschmidt","display_name":"Tim","email":"tim@monogon.tech","username":"fionera","avatars":[{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"959484866e89e810900304bfeeede50ac8879754","unresolved":false,"context_lines":[{"line_number":425,"context_line":"\t\tr.time \u003d \u0026src2"},{"line_number":426,"context_line":"\tcase \"bigint\":"},{"line_number":427,"context_line":"\t\tswitch src.(type) {"},{"line_number":428,"context_line":"\t\tcase uint, uint8, uint16, uint32, uint64,"},{"line_number":429,"context_line":"\t\t\tint, int8, int16, int32, int64:"},{"line_number":430,"context_line":"\t\t\tbreak"},{"line_number":431,"context_line":"\t\tdefault:"},{"line_number":432,"context_line":"\t\t\treturn fmt.Errorf(\"SQL type %q, but got %+v\", r.Type.NativeType, src)"}],"source_content_type":"text/x-go","patch_set":2,"id":"f0b60bd0_203b5fe7","line":429,"range":{"start_line":428,"start_character":7,"end_line":429,"end_character":34},"in_reply_to":"4608fbee_5fccae4c","updated":"2023-04-25 10:11:58.000000000","message":"Sure tho this wouldn\u0027t break things as all of these types are %v compatible 😊 \n\nIn the docs of lib/pq it says:\n\u003e integer types smallint, integer, and bigint are returned as int64\nTho I do see additional code that uses int16, int32 and int64.\n\nJust ran the code with a %T printf and it showed me only int64","commit_id":"280d95d4ea868361735eddb4334375d4ea8baf2c"},{"author":{"_account_id":1000002,"name":"Serge Bazanski","display_name":"Serge","email":"serge@monogon.tech","username":"serge","avatars":[{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"381e4a2c5c7dd1c0cedead7c44f8bd8d20212c0a","unresolved":true,"context_lines":[{"line_number":425,"context_line":"\t\tr.time \u003d \u0026src2"},{"line_number":426,"context_line":"\tcase \"bigint\":"},{"line_number":427,"context_line":"\t\tswitch src.(type) {"},{"line_number":428,"context_line":"\t\tcase uint, uint8, uint16, uint32, uint64,"},{"line_number":429,"context_line":"\t\t\tint, int8, int16, int32, int64:"},{"line_number":430,"context_line":"\t\t\tbreak"},{"line_number":431,"context_line":"\t\tdefault:"},{"line_number":432,"context_line":"\t\t\treturn fmt.Errorf(\"SQL type %q, but got %+v\", r.Type.NativeType, src)"}],"source_content_type":"text/x-go","patch_set":2,"id":"4608fbee_5fccae4c","line":429,"range":{"start_line":428,"start_character":7,"end_line":429,"end_character":34},"in_reply_to":"a52ce68c_c94dc621","updated":"2023-04-25 09:48:14.000000000","message":"Can you check this experimentally and/or by diving into the postgres driver sources? I\u0027d prefer for that behaviour to be well understood and documented in a comment around here somewhere :). Then we know how likely things are to actually break in the future, vs. hoping that our guess is correct.","commit_id":"280d95d4ea868361735eddb4334375d4ea8baf2c"},{"author":{"_account_id":1000019,"name":"Tim Windelschmidt","display_name":"Tim","email":"tim@monogon.tech","username":"fionera","avatars":[{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"9ef05400ad7f39238a9bfea2782dc847614ef6e6","unresolved":true,"context_lines":[{"line_number":425,"context_line":"\t\tr.time \u003d \u0026src2"},{"line_number":426,"context_line":"\tcase \"bigint\":"},{"line_number":427,"context_line":"\t\tswitch src.(type) {"},{"line_number":428,"context_line":"\t\tcase uint, uint8, uint16, uint32, uint64,"},{"line_number":429,"context_line":"\t\t\tint, int8, int16, int32, int64:"},{"line_number":430,"context_line":"\t\t\tbreak"},{"line_number":431,"context_line":"\t\tdefault:"},{"line_number":432,"context_line":"\t\t\treturn fmt.Errorf(\"SQL type %q, but got %+v\", r.Type.NativeType, src)"}],"source_content_type":"text/x-go","patch_set":2,"id":"a52ce68c_c94dc621","line":429,"range":{"start_line":428,"start_character":7,"end_line":429,"end_character":34},"in_reply_to":"e0ef5fa6_6d7d65e2","updated":"2023-04-25 09:39:03.000000000","message":"I wasn\u0027t sure which type it is and if we have any other integer type we can just add it to the case afterwards.","commit_id":"280d95d4ea868361735eddb4334375d4ea8baf2c"},{"author":{"_account_id":1000002,"name":"Serge Bazanski","display_name":"Serge","email":"serge@monogon.tech","username":"serge","avatars":[{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"544250a7005c56cf248d05c48ac88ad9aaf47a84","unresolved":false,"context_lines":[{"line_number":425,"context_line":"\t\tr.time \u003d \u0026src2"},{"line_number":426,"context_line":"\tcase \"bigint\":"},{"line_number":427,"context_line":"\t\tswitch src.(type) {"},{"line_number":428,"context_line":"\t\tcase uint, uint8, uint16, uint32, uint64,"},{"line_number":429,"context_line":"\t\t\tint, int8, int16, int32, int64:"},{"line_number":430,"context_line":"\t\t\tbreak"},{"line_number":431,"context_line":"\t\tdefault:"},{"line_number":432,"context_line":"\t\t\treturn fmt.Errorf(\"SQL type %q, but got %+v\", r.Type.NativeType, src)"}],"source_content_type":"text/x-go","patch_set":2,"id":"f49c947b_52d306ba","line":429,"range":{"start_line":428,"start_character":7,"end_line":429,"end_character":34},"in_reply_to":"f0b60bd0_203b5fe7","updated":"2023-04-25 10:33:09.000000000","message":"`%v` sketches me out again as it\u0027s very permissive. I always want to make sure that we know as early as possible when our assumptions are broken instead of potentially having some silent magical unintended behavior happen under the hood unnoticed for years.\n\nLet\u0027s go with type asserting that it\u0027s an int64?\n\n```\nif n, ok :\u003d src.(int64); ok {\n    r.text \u003d strconv.FormatInt(n, 10)\n} else {\n    return fmt.Errorf(\"SQL type %q, but got %T\", r.Type.NativeType, src)\n}\n```","commit_id":"280d95d4ea868361735eddb4334375d4ea8baf2c"},{"author":{"_account_id":1000019,"name":"Tim Windelschmidt","display_name":"Tim","email":"tim@monogon.tech","username":"fionera","avatars":[{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"0203ca8918a17a3f8b2a4c949019382176be9e10","unresolved":false,"context_lines":[{"line_number":425,"context_line":"\t\tr.time \u003d \u0026src2"},{"line_number":426,"context_line":"\tcase \"bigint\":"},{"line_number":427,"context_line":"\t\tswitch src.(type) {"},{"line_number":428,"context_line":"\t\tcase uint, uint8, uint16, uint32, uint64,"},{"line_number":429,"context_line":"\t\t\tint, int8, int16, int32, int64:"},{"line_number":430,"context_line":"\t\t\tbreak"},{"line_number":431,"context_line":"\t\tdefault:"},{"line_number":432,"context_line":"\t\t\treturn fmt.Errorf(\"SQL type %q, but got %+v\", r.Type.NativeType, src)"}],"source_content_type":"text/x-go","patch_set":2,"id":"9de7e8d6_05b2ef38","line":429,"range":{"start_line":428,"start_character":7,"end_line":429,"end_character":34},"in_reply_to":"f49c947b_52d306ba","updated":"2023-04-25 10:35:45.000000000","message":"I already did that 😄","commit_id":"280d95d4ea868361735eddb4334375d4ea8baf2c"}]}