)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1000002,"name":"Serge Bazanski","display_name":"Serge","email":"serge@monogon.tech","username":"serge","avatars":[{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"5962beb1100524a69c95bd7bba194c9784b31513","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Tim Windelschmidt \u003ctim@monogon.tech\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-04-24 19:11:12 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"cloud/agent: override NetworkConfig with current one if not set"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I27f75735907b7c993dcd7002a863cd8fe00699fa"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"0fd113e8_d85aea2e","line":7,"range":{"start_line":7,"start_character":13,"end_line":7,"end_character":63},"updated":"2023-04-24 17:24:58.000000000","message":"nit: `default to detected network config when installing OS` or something like that.\n\nComment message summaries should be grokable at a glance. I had to read the entire commit to understand what this actually meant.","commit_id":"a37824055c1b43121b17201875d050e824da8100"},{"author":{"_account_id":1000002,"name":"Serge Bazanski","display_name":"Serge","email":"serge@monogon.tech","username":"serge","avatars":[{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"e542ca898b9b98c668de5443ff1541834bfbed77","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Tim Windelschmidt \u003ctim@monogon.tech\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-04-24 19:11:12 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"cloud/agent: override NetworkConfig with current one if not set"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I27f75735907b7c993dcd7002a863cd8fe00699fa"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"49de19ff_f9d08cf4","line":7,"range":{"start_line":7,"start_character":13,"end_line":7,"end_character":63},"in_reply_to":"0fd113e8_d85aea2e","updated":"2023-04-24 17:31:24.000000000","message":"Protip is to formulate commits as “what I would ask someone to do”, in this case \u0027[make it] default to the detected network config when installing OS\u0027 :)","commit_id":"a37824055c1b43121b17201875d050e824da8100"},{"author":{"_account_id":1000019,"name":"Tim Windelschmidt","display_name":"Tim","email":"tim@monogon.tech","username":"fionera","avatars":[{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"62af9a4b71c5dbddba27cf09413ea0f91c37bf87","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Tim Windelschmidt \u003ctim@monogon.tech\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-04-24 19:11:12 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"cloud/agent: override NetworkConfig with current one if not set"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I27f75735907b7c993dcd7002a863cd8fe00699fa"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"d72a6de5_071cf2ba","line":7,"range":{"start_line":7,"start_character":13,"end_line":7,"end_character":63},"in_reply_to":"49de19ff_f9d08cf4","updated":"2023-04-24 20:22:07.000000000","message":"Thanks :) Done","commit_id":"a37824055c1b43121b17201875d050e824da8100"}],"cloud/agent/install.go":[{"author":{"_account_id":1000002,"name":"Serge Bazanski","display_name":"Serge","email":"serge@monogon.tech","username":"serge","avatars":[{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"5962beb1100524a69c95bd7bba194c9784b31513","unresolved":true,"context_lines":[{"line_number":29,"context_line":"\t}"},{"line_number":30,"context_line":"}"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"func installMetropolis(req *bpb.MetropolisInstallationRequest, config *npb.Net, l logtree.LeveledLogger, isEFIBoot bool) error {"},{"line_number":33,"context_line":"\tif !isEFIBoot {"},{"line_number":34,"context_line":"\t\treturn errors.New(\"Monogon OS can only be installed on EFI-booted machines, this one is not\")"},{"line_number":35,"context_line":"\t}"}],"source_content_type":"text/x-go","patch_set":1,"id":"b8e8f268_4f418f7a","line":32,"range":{"start_line":32,"start_character":63,"end_line":32,"end_character":69},"updated":"2023-04-24 17:24:58.000000000","message":"`netConfig` (also above)","commit_id":"a37824055c1b43121b17201875d050e824da8100"},{"author":{"_account_id":1000019,"name":"Tim Windelschmidt","display_name":"Tim","email":"tim@monogon.tech","username":"fionera","avatars":[{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"62af9a4b71c5dbddba27cf09413ea0f91c37bf87","unresolved":false,"context_lines":[{"line_number":29,"context_line":"\t}"},{"line_number":30,"context_line":"}"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"func installMetropolis(req *bpb.MetropolisInstallationRequest, config *npb.Net, l logtree.LeveledLogger, isEFIBoot bool) error {"},{"line_number":33,"context_line":"\tif !isEFIBoot {"},{"line_number":34,"context_line":"\t\treturn errors.New(\"Monogon OS can only be installed on EFI-booted machines, this one is not\")"},{"line_number":35,"context_line":"\t}"}],"source_content_type":"text/x-go","patch_set":1,"id":"0e16d257_f2b20348","line":32,"range":{"start_line":32,"start_character":63,"end_line":32,"end_character":69},"in_reply_to":"b8e8f268_4f418f7a","updated":"2023-04-24 20:22:07.000000000","message":"Done","commit_id":"a37824055c1b43121b17201875d050e824da8100"},{"author":{"_account_id":1000002,"name":"Serge Bazanski","display_name":"Serge","email":"serge@monogon.tech","username":"serge","avatars":[{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"5962beb1100524a69c95bd7bba194c9784b31513","unresolved":true,"context_lines":[{"line_number":34,"context_line":"\t\treturn errors.New(\"Monogon OS can only be installed on EFI-booted machines, this one is not\")"},{"line_number":35,"context_line":"\t}"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"\t// override the NodeParameters.NetworkConfig with the current NetworkConfig"},{"line_number":38,"context_line":"\t// if its missing"},{"line_number":39,"context_line":"\tif req.NodeParameters.NetworkConfig \u003d\u003d nil {"},{"line_number":40,"context_line":"\t\treq.NodeParameters.NetworkConfig \u003d config"}],"source_content_type":"text/x-go","patch_set":1,"id":"077babaa_61f4750c","line":37,"range":{"start_line":37,"start_character":4,"end_line":37,"end_character":5},"updated":"2023-04-24 17:24:58.000000000","message":"Nit: comments are sentences that start with a capital letter and end with a punctuation mark.","commit_id":"a37824055c1b43121b17201875d050e824da8100"},{"author":{"_account_id":1000019,"name":"Tim Windelschmidt","display_name":"Tim","email":"tim@monogon.tech","username":"fionera","avatars":[{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"62af9a4b71c5dbddba27cf09413ea0f91c37bf87","unresolved":false,"context_lines":[{"line_number":34,"context_line":"\t\treturn errors.New(\"Monogon OS can only be installed on EFI-booted machines, this one is not\")"},{"line_number":35,"context_line":"\t}"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"\t// override the NodeParameters.NetworkConfig with the current NetworkConfig"},{"line_number":38,"context_line":"\t// if its missing"},{"line_number":39,"context_line":"\tif req.NodeParameters.NetworkConfig \u003d\u003d nil {"},{"line_number":40,"context_line":"\t\treq.NodeParameters.NetworkConfig \u003d config"}],"source_content_type":"text/x-go","patch_set":1,"id":"b18e17c9_f2fab0f9","line":37,"range":{"start_line":37,"start_character":4,"end_line":37,"end_character":5},"in_reply_to":"077babaa_61f4750c","updated":"2023-04-24 20:22:07.000000000","message":"Ack","commit_id":"a37824055c1b43121b17201875d050e824da8100"}]}