)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1000002,"name":"Serge Bazanski","display_name":"Serge","email":"serge@monogon.tech","username":"serge","avatars":[{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"506d0530f99b4d1b440caf72aa594d57dd1ce834","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Tim Windelschmidt \u003ctim@monogon.tech\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-04-24 19:11:12 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"m/p/common: set visibility to public"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ibcc4ca969e2de31c95f8ab8479ce2d7f4fb740d7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1aaa4549_585436b3","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":36},"updated":"2023-04-24 17:20:47.000000000","message":"Please explain why.","commit_id":"548ee6518b231ab986726aa92169b464c88420d2"},{"author":{"_account_id":1000019,"name":"Tim Windelschmidt","display_name":"Tim","email":"tim@monogon.tech","username":"fionera","avatars":[{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"bda144c8bd82289fe1a3b50321d9b236817a1862","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Tim Windelschmidt \u003ctim@monogon.tech\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-04-24 19:11:12 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"m/p/common: set visibility to public"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ibcc4ca969e2de31c95f8ab8479ce2d7f4fb740d7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"b639da9f_34dd13ca","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":36},"in_reply_to":"1aaa4549_585436b3","updated":"2023-04-24 20:23:04.000000000","message":"I added another sentence. Have to find out how to write better messages in the future ^^","commit_id":"548ee6518b231ab986726aa92169b464c88420d2"},{"author":{"_account_id":1000002,"name":"Serge Bazanski","display_name":"Serge","email":"serge@monogon.tech","username":"serge","avatars":[{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"2c904bce1a2454b0d8f25efb7f6354c752355be6","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Tim Windelschmidt \u003ctim@monogon.tech\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-04-24 19:11:12 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"m/p/common: set visibility to public"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ibcc4ca969e2de31c95f8ab8479ce2d7f4fb740d7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"8bf8ee72_bc1fee38","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":36},"in_reply_to":"2a9f7a42_02b2f1fe","updated":"2023-04-25 09:46:47.000000000","message":"Ah, you\u0027re of course right this is needed when you want to access some of the messages directly.","commit_id":"548ee6518b231ab986726aa92169b464c88420d2"},{"author":{"_account_id":1000002,"name":"Serge Bazanski","display_name":"Serge","email":"serge@monogon.tech","username":"serge","avatars":[{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"19a6f020e71ded30ac27f77f154c096f157ce510","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Tim Windelschmidt \u003ctim@monogon.tech\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-04-24 19:11:12 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"m/p/common: set visibility to public"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ibcc4ca969e2de31c95f8ab8479ce2d7f4fb740d7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"cd8c9748_15630f8a","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":36},"in_reply_to":"b639da9f_34dd13ca","updated":"2023-04-25 09:34:14.000000000","message":"I\u0027m still confused about why we need this. What other change actually depends on this? My understanding is that if you use `//metropolis/proto/api` (which depends on and contains types from common/common.proto) then you shouldn\u0027t need to make common itself publicly visible?","commit_id":"548ee6518b231ab986726aa92169b464c88420d2"},{"author":{"_account_id":1000019,"name":"Tim Windelschmidt","display_name":"Tim","email":"tim@monogon.tech","username":"fionera","avatars":[{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/57e6137fdb8185cd15ac27ba188780ff.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"eb89202525f6dc4d0a652ca9f42153e0a9b70c76","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Tim Windelschmidt \u003ctim@monogon.tech\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-04-24 19:11:12 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"m/p/common: set visibility to public"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ibcc4ca969e2de31c95f8ab8479ce2d7f4fb740d7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"2a9f7a42_02b2f1fe","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":36},"in_reply_to":"cd8c9748_15630f8a","updated":"2023-04-25 09:37:54.000000000","message":"I have the following snippet in some local tooling:\n```\n\tbytes, err :\u003d proto.Marshal(\u0026apb.OSInstallationRequest{\n\t\tGeneration: 1,\n\t\tType: \u0026apb.OSInstallationRequest_Metropolis{Metropolis: \u0026apb.MetropolisInstallationRequest{\n\t\t\tBundleUrl: \"\",\n\t\t\tNodeParameters: \u0026api.NodeParameters{\n\t\t\t\tCluster: \u0026api.NodeParameters_ClusterBootstrap_{\n\t\t\t\t\tClusterBootstrap: \u0026api.NodeParameters_ClusterBootstrap{\n\t\t\t\t\t\tOwnerPublicKey:              pub,\n\t\t\t\t\t\tInitialClusterConfiguration: \u0026common.ClusterConfiguration{TpmMode: common.ClusterConfiguration_TPM_MODE_BEST_EFFORT},\n\t\t\t\t\t},\n\t\t\t\t},\n\t\t\t},\n\t\t\tRootDevice: \"nvme0n1\",\n\t\t}},\n\t})\n```\nthis requires the following imports\n```\n\tapb \"source.monogon.dev/cloud/bmaas/server/api\"\n\t\"source.monogon.dev/metropolis/cli/metroctl/core\"\n\t\"source.monogon.dev/metropolis/proto/api\"\n\t\"source.monogon.dev/metropolis/proto/common\"\n```\n\nsince we want to use the proto definitions in other tooling too we have to set it public","commit_id":"548ee6518b231ab986726aa92169b464c88420d2"}]}