)]}'
{"cloud/agent/api/hwreport.proto":[{"author":{"_account_id":1000002,"name":"Serge Bazanski","display_name":"Serge","email":"serge@monogon.tech","username":"serge","avatars":[{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"138133002290e31b116d062cfbc3e3b879e21c6c","unresolved":true,"context_lines":[{"line_number":97,"context_line":""},{"line_number":98,"context_line":"enum EFISupport {"},{"line_number":99,"context_line":"  // It is not known if EFI is supported by the node. EFI runtime services are"},{"line_number":100,"context_line":"  // not available. This occurs if the hardware report generator is too old,"},{"line_number":101,"context_line":"  // the firmware has no information about the presence of EFI and runtime"},{"line_number":102,"context_line":"  // services are not available or if runtime services are broken."},{"line_number":103,"context_line":"  EFI_UNKNOWN \u003d 0;"},{"line_number":104,"context_line":"  // The firmware indicates that EFI is not supported by the node. EFI runtime"},{"line_number":105,"context_line":"  // services are not available."}],"source_content_type":"text/x-protobuf","patch_set":1,"id":"98d4ca41_1604dc0a","line":102,"range":{"start_line":100,"start_character":20,"end_line":102,"end_character":66},"updated":"2023-04-19 14:35:14.000000000","message":"I don\u0027t like merging these two conditions under a single enum value but whatever.","commit_id":"4a0ac116223476323d9d8c8262f2f901fa0e7da1"},{"author":{"_account_id":1000001,"name":"Lorenz Brun","display_name":"Lorenz","email":"lorenz@monogon.tech","username":"lorenz","avatars":[{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"6cab9a0b05496f9386317f80e17a1c41c6a66456","unresolved":true,"context_lines":[{"line_number":97,"context_line":""},{"line_number":98,"context_line":"enum EFISupport {"},{"line_number":99,"context_line":"  // It is not known if EFI is supported by the node. EFI runtime services are"},{"line_number":100,"context_line":"  // not available. This occurs if the hardware report generator is too old,"},{"line_number":101,"context_line":"  // the firmware has no information about the presence of EFI and runtime"},{"line_number":102,"context_line":"  // services are not available or if runtime services are broken."},{"line_number":103,"context_line":"  EFI_UNKNOWN \u003d 0;"},{"line_number":104,"context_line":"  // The firmware indicates that EFI is not supported by the node. EFI runtime"},{"line_number":105,"context_line":"  // services are not available."}],"source_content_type":"text/x-protobuf","patch_set":1,"id":"73ae3acd_5eb31ff8","line":102,"range":{"start_line":100,"start_character":20,"end_line":102,"end_character":66},"in_reply_to":"02058f7c_64ef1634","updated":"2023-04-19 16:15:33.000000000","message":"The thing is UEFI doesn\u0027t specify an interface for querying if it\u0027s supported but not enabled. It just so happens that a lot of hardware has SMBIOS which can contain this information. So it kind of depends on what methods to discover this is implemented in the reporter, thus differentiating between the reporter being too old vs the firmware not having any info can be difficult in practice.\nThere is also a bit of a naming issue, the best I can come up is UNKNOWN and NOINFO.","commit_id":"4a0ac116223476323d9d8c8262f2f901fa0e7da1"},{"author":{"_account_id":1000002,"name":"Serge Bazanski","display_name":"Serge","email":"serge@monogon.tech","username":"serge","avatars":[{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"8ef4925081b622d18a0f6706144764a871364ffb","unresolved":true,"context_lines":[{"line_number":97,"context_line":""},{"line_number":98,"context_line":"enum EFISupport {"},{"line_number":99,"context_line":"  // It is not known if EFI is supported by the node. EFI runtime services are"},{"line_number":100,"context_line":"  // not available. This occurs if the hardware report generator is too old,"},{"line_number":101,"context_line":"  // the firmware has no information about the presence of EFI and runtime"},{"line_number":102,"context_line":"  // services are not available or if runtime services are broken."},{"line_number":103,"context_line":"  EFI_UNKNOWN \u003d 0;"},{"line_number":104,"context_line":"  // The firmware indicates that EFI is not supported by the node. EFI runtime"},{"line_number":105,"context_line":"  // services are not available."}],"source_content_type":"text/x-protobuf","patch_set":1,"id":"02058f7c_64ef1634","line":102,"range":{"start_line":100,"start_character":20,"end_line":102,"end_character":66},"in_reply_to":"467d1595_c20c7f0d","updated":"2023-04-19 15:05:56.000000000","message":"What I meant is \u0027hardware generator is too old\u0027 (ie. zero value) and \u0027the firmware has no information about the presence of EFI and runtime services are not available or if runtime services are broken\u0027.\n\nThe zero value should just mean \u0027the writer didn\u0027t populate this because it\u0027s not aware of this schema version\u0027.","commit_id":"4a0ac116223476323d9d8c8262f2f901fa0e7da1"},{"author":{"_account_id":1000001,"name":"Lorenz Brun","display_name":"Lorenz","email":"lorenz@monogon.tech","username":"lorenz","avatars":[{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"0ad1610cbb293585c18e74ce058313d9d6a5fa42","unresolved":false,"context_lines":[{"line_number":97,"context_line":""},{"line_number":98,"context_line":"enum EFISupport {"},{"line_number":99,"context_line":"  // It is not known if EFI is supported by the node. EFI runtime services are"},{"line_number":100,"context_line":"  // not available. This occurs if the hardware report generator is too old,"},{"line_number":101,"context_line":"  // the firmware has no information about the presence of EFI and runtime"},{"line_number":102,"context_line":"  // services are not available or if runtime services are broken."},{"line_number":103,"context_line":"  EFI_UNKNOWN \u003d 0;"},{"line_number":104,"context_line":"  // The firmware indicates that EFI is not supported by the node. EFI runtime"},{"line_number":105,"context_line":"  // services are not available."}],"source_content_type":"text/x-protobuf","patch_set":1,"id":"40f4669d_38024707","line":102,"range":{"start_line":100,"start_character":20,"end_line":102,"end_character":66},"in_reply_to":"528ee5da_7e422bdc","updated":"2023-04-19 17:15:28.000000000","message":"Done","commit_id":"4a0ac116223476323d9d8c8262f2f901fa0e7da1"},{"author":{"_account_id":1000002,"name":"Serge Bazanski","display_name":"Serge","email":"serge@monogon.tech","username":"serge","avatars":[{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"fd834b3c76e085ee9973627f6aa22f994bf1ea6b","unresolved":true,"context_lines":[{"line_number":97,"context_line":""},{"line_number":98,"context_line":"enum EFISupport {"},{"line_number":99,"context_line":"  // It is not known if EFI is supported by the node. EFI runtime services are"},{"line_number":100,"context_line":"  // not available. This occurs if the hardware report generator is too old,"},{"line_number":101,"context_line":"  // the firmware has no information about the presence of EFI and runtime"},{"line_number":102,"context_line":"  // services are not available or if runtime services are broken."},{"line_number":103,"context_line":"  EFI_UNKNOWN \u003d 0;"},{"line_number":104,"context_line":"  // The firmware indicates that EFI is not supported by the node. EFI runtime"},{"line_number":105,"context_line":"  // services are not available."}],"source_content_type":"text/x-protobuf","patch_set":1,"id":"528ee5da_7e422bdc","line":102,"range":{"start_line":100,"start_character":20,"end_line":102,"end_character":66},"in_reply_to":"73ae3acd_5eb31ff8","updated":"2023-04-19 16:20:59.000000000","message":"You can also do INVALID and UNKNOWN, just comment them well.","commit_id":"4a0ac116223476323d9d8c8262f2f901fa0e7da1"},{"author":{"_account_id":1000001,"name":"Lorenz Brun","display_name":"Lorenz","email":"lorenz@monogon.tech","username":"lorenz","avatars":[{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/75c04f6e9881c24ee621fba80667eed8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"ce9458e964b49c43224f3075e98bbaddc8bc3e39","unresolved":true,"context_lines":[{"line_number":97,"context_line":""},{"line_number":98,"context_line":"enum EFISupport {"},{"line_number":99,"context_line":"  // It is not known if EFI is supported by the node. EFI runtime services are"},{"line_number":100,"context_line":"  // not available. This occurs if the hardware report generator is too old,"},{"line_number":101,"context_line":"  // the firmware has no information about the presence of EFI and runtime"},{"line_number":102,"context_line":"  // services are not available or if runtime services are broken."},{"line_number":103,"context_line":"  EFI_UNKNOWN \u003d 0;"},{"line_number":104,"context_line":"  // The firmware indicates that EFI is not supported by the node. EFI runtime"},{"line_number":105,"context_line":"  // services are not available."}],"source_content_type":"text/x-protobuf","patch_set":1,"id":"467d1595_c20c7f0d","line":102,"range":{"start_line":100,"start_character":20,"end_line":102,"end_character":66},"in_reply_to":"98d4ca41_1604dc0a","updated":"2023-04-19 14:38:44.000000000","message":"Which two? We cannot reasonably distinguish a too-old hwreport version from other causes of non-reportability as that hwreport version might be missing the associated information sources.","commit_id":"4a0ac116223476323d9d8c8262f2f901fa0e7da1"}]}
