)]}'
{"cloud/bmaas/server/server.go":[{"author":{"_account_id":1000000,"name":"Leopold Schabel","display_name":"Leo","email":"leo@monogon.tech","username":"leo","avatars":[{"url":"https://www.gravatar.com/avatar/98f8f79a6bb45adef37defa7ead8f3d2.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/98f8f79a6bb45adef37defa7ead8f3d2.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/98f8f79a6bb45adef37defa7ead8f3d2.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/98f8f79a6bb45adef37defa7ead8f3d2.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"a5c7a9f5653968f70cdda9ffefe4402844431eec","unresolved":true,"context_lines":[{"line_number":83,"context_line":"\t\t\t}, backoff.WithContext(bo, ctx))"},{"line_number":84,"context_line":"\t\t\tif err !\u003d nil {"},{"line_number":85,"context_line":"\t\t\t\t// If something\u0027s really wrong just crash."},{"line_number":86,"context_line":"\t\t\t\tklog.Exitf(\"Gave up on starting session: %v\", err)"},{"line_number":87,"context_line":"\t\t\t}"},{"line_number":88,"context_line":"\t\t\tklog.Infof(\"New session: %s\", session.UUID)"},{"line_number":89,"context_line":"\t\t}"}],"source_content_type":"text/x-go","patch_set":1,"id":"6ac008c8_7f86ec24","line":86,"updated":"2023-04-19 13:29:43.000000000","message":"if this is essentially a panic, it should probably be a Fatalf (which would print a stacktrace like a panic)","commit_id":"6b064aecea2d46ff55320eecbb3efaefcf38ce4c"},{"author":{"_account_id":1000000,"name":"Leopold Schabel","display_name":"Leo","email":"leo@monogon.tech","username":"leo","avatars":[{"url":"https://www.gravatar.com/avatar/98f8f79a6bb45adef37defa7ead8f3d2.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/98f8f79a6bb45adef37defa7ead8f3d2.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/98f8f79a6bb45adef37defa7ead8f3d2.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/98f8f79a6bb45adef37defa7ead8f3d2.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"9a1da1ab63479e8300d9203d8f4ed1573c04467c","unresolved":false,"context_lines":[{"line_number":83,"context_line":"\t\t\t}, backoff.WithContext(bo, ctx))"},{"line_number":84,"context_line":"\t\t\tif err !\u003d nil {"},{"line_number":85,"context_line":"\t\t\t\t// If something\u0027s really wrong just crash."},{"line_number":86,"context_line":"\t\t\t\tklog.Exitf(\"Gave up on starting session: %v\", err)"},{"line_number":87,"context_line":"\t\t\t}"},{"line_number":88,"context_line":"\t\t\tklog.Infof(\"New session: %s\", session.UUID)"},{"line_number":89,"context_line":"\t\t}"}],"source_content_type":"text/x-go","patch_set":1,"id":"6f4c53bf_668535e1","line":86,"in_reply_to":"1a34c021_5c6886d4","updated":"2023-04-19 13:41:25.000000000","message":"Ack","commit_id":"6b064aecea2d46ff55320eecbb3efaefcf38ce4c"},{"author":{"_account_id":1000002,"name":"Serge Bazanski","display_name":"Serge","email":"serge@monogon.tech","username":"serge","avatars":[{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/52c41428b6369f2c02b9717425216f7d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"a3ccac0507c615416cdb5c1bd5305fa22b5f1ca7","unresolved":true,"context_lines":[{"line_number":83,"context_line":"\t\t\t}, backoff.WithContext(bo, ctx))"},{"line_number":84,"context_line":"\t\t\tif err !\u003d nil {"},{"line_number":85,"context_line":"\t\t\t\t// If something\u0027s really wrong just crash."},{"line_number":86,"context_line":"\t\t\t\tklog.Exitf(\"Gave up on starting session: %v\", err)"},{"line_number":87,"context_line":"\t\t\t}"},{"line_number":88,"context_line":"\t\t\tklog.Infof(\"New session: %s\", session.UUID)"},{"line_number":89,"context_line":"\t\t}"}],"source_content_type":"text/x-go","patch_set":1,"id":"1a34c021_5c6886d4","line":86,"in_reply_to":"6ac008c8_7f86ec24","updated":"2023-04-19 13:40:50.000000000","message":"It is a panic, but I think the stacktrace is unnecessary: we know exactly where this happened in the stack, and the filename/line are still printed on Exitf anyway.\n\nThe panic is more to trigger a restart of the entire bmsrv by the cluster scheduler rather than a panic because the program has no idea what to do.","commit_id":"6b064aecea2d46ff55320eecbb3efaefcf38ce4c"}]}